Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1149861 (binpac) - Review Request: binpac - A language for protocol parsers
Summary: Review Request: binpac - A language for protocol parsers
Keywords:
Status: CLOSED WONTFIX
Alias: binpac
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 979726
TreeView+ depends on / blocked
 
Reported: 2014-10-06 19:11 UTC by Fabian Affolter
Modified: 2014-11-25 22:19 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-25 22:19:20 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Fabian Affolter 2014-10-06 19:11:33 UTC 
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/binpac.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/binpac-0.42-1.fc20.src.rpm

Project URL: https://www.bro.org/sphinx/components/binpac/README.html

Description:
BinPAC is a high level language for describing protocol parsers and generates
C++ code. It is currently maintained and distributed with the Bro Network
Security Monitor distribution, however, the generated parsers may be used
with other programs besides Bro.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7778551

rpmlint output:
[fab@localhost SRPMS]$ rpmlint binpac-0.42-1.fc20.src.rpm 
binpac.src: W: spelling-error Summary(en_US) parsers -> parser, parses, parers
binpac.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[fab@localhost x86_64]$ rpmlint binpac*
binpac.x86_64: W: spelling-error Summary(en_US) parsers -> parser, parses, parers
binpac.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers
binpac.x86_64: W: no-manual-page-for-binary binpac
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

Fedora Account System Username: fab
Comment 1 Ralf Corsepius 2014-10-07 07:23:05 UTC 
This package has several issues:
- Building is non-verbose.
AFAIS, appending VERBOSE=1 to the make calls seems triggers verbose building.

- The *-devel package doesn't contain a library.
Unless this is a c++-template library (which I doubt it is), this doesn't make sense. Actually I think this package is only building a static library, which you later are removing from inside of the spec.

- The *-devel package ships /usr/include/binpac.h.in
I doubt this file is supposed to be shipped.
Comment 2 Parag AN(पराग) 2014-10-07 08:23:27 UTC 
some other improvements can be done

1) I see duplication of documentation files. Those should be present only in base package as -devel will also pull base package.

2) patch file is included with no comments why it is needed and/or no upstream submitted reference to this patch.
Comment 3 Fabian Affolter 2014-11-21 15:51:34 UTC 
Thanks for the comments.

* Wed Oct 08 2014 Fabian Affolter <mail> - 0.42-2
- Remove doc file from -devel package and unused file
- Don't remove the static lib
- Add a comment for the patch (rhbz#1149861)

Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/binpac.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/binpac-0.42-2.fc20.src.rpm
Note You need to log in before you can comment on or make changes to this bug.