Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1171547 - Focus problem after hiding terminal in XFCE - fedora 21
Summary: Focus problem after hiding terminal in XFCE - fedora 21
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: guake
Version: 21
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pierre-YvesChibon
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 965796
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-08 04:08 UTC by Eryu Guan
Modified: 2015-02-03 12:05 UTC (History)
6 users (show)

Fixed In Version: guake-0.5.2-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of: 965796
Environment:
Last Closed: 2015-02-03 11:59:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Eryu Guan 2014-12-08 04:08:18 UTC
This problem happens again on Fedora 21, guake-0.5.0-3.fc21.x86_64

This patch fixes the problem for me.

eguan@dhcp-13-216:~$ diff -u /usr/bin/guake.orig /usr/bin/guake
--- /usr/bin/guake.orig 2014-12-08 12:04:47.488432931 +0800
+++ /usr/bin/guake      2014-12-08 12:05:08.362576621 +0800
@@ -1055,7 +1055,7 @@
         if not self.term_list:
             self.add_tab()
 
-        self.window.set_keep_below(False)
+        self.window.set_keep_below(True)
         self.window.show_all()
 
         if self.selected_color is None:

+++ This bug was initially created as a clone of Bug #965796 +++

Description of problem:

This bug affects XFCE and maybe other DEs, but not Gnome.
When hiding the terminal with the hotkey, the window that had focus before opening the terminal doesn't regain focus.


Version-Release number of selected component (if applicable):

0.4.4-9, but going all the way back to F17.


How reproducible:

Everytime


Steps to Reproduce:
1. Open any window in XFCE so it has focus.
2. Open guake by hitting F12
3. Close guake by hitting F12


Actual results:

The window that had focus before opening guake doesn't have it, the desktop has focus instead.


Expected results:

The window should have focus.


Additional info:

This wrong behaviour is caused by a patch introduced to fix this bug:
http://guake.org/ticket/436
But this was a hack to work around a gnome 3.4 bug, which is fixed now and isn't necessary anymore. Changing the lines

self.window.set_keep_below(True)
self.window.hide() # Don't use hide_all here!

back to

self.window.hide() # Don't use hide_all here!

doesn't change any gnome behaviour but fixes the problem in XFCE.
(This hack isn't even present in the upstream code.)

I hope that explains it well enough.

--- Additional comment from Aiman on 2013-06-27 09:03:16 EDT ---

As above, I am experiencing the same issue on Xfce. When hiding the Guake window, focus is in limbo. It does not return to the previous focused window or any window at all. I have to manually click on a window for it to receive focus.

I initially thought the problem was the Gnome 3.4 bug. So when I went to check /usr/bin/guake I found part of the patch already there. So then I thought maybe the patch itself is the problem:

http://pkgs.fedoraproject.org/cgit/guake.git/commit/?id=af1c2f75195f4c9e5618693babce8c4c42d58607

I changed /usr/bin/guake to revert the patch and my focus issues are now solved.

Is this patch still necessary?

--- Additional comment from Peter Hatina on 2013-07-16 17:16:28 EDT ---

I can confirm, that reverting the patch makes Guake work properly under Xfce (F19).

--- Additional comment from Aiman on 2013-09-09 14:12:24 EDT ---

This issue is still present in Fedora 19.

--- Additional comment from Pierre-YvesChibon on 2013-09-30 06:15:48 EDT ---

I no longer have the problem on F19 w/o this patch, reverting it.

--- Additional comment from Fedora Update System on 2013-09-30 07:25:45 EDT ---

guake-0.4.4-11.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/guake-0.4.4-11.fc19

--- Additional comment from Fedora Update System on 2013-09-30 07:25:56 EDT ---

guake-0.4.4-11.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/guake-0.4.4-11.fc20

--- Additional comment from Fedora Update System on 2013-09-30 21:59:15 EDT ---

Package guake-0.4.4-11.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing guake-0.4.4-11.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-17980/guake-0.4.4-11.fc20
then log in and leave karma (feedback).

--- Additional comment from Fedora Update System on 2013-10-05 21:35:20 EDT ---

guake-0.4.4-11.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

--- Additional comment from Fedora Update System on 2013-11-23 22:49:45 EST ---

guake-0.4.4-11.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 1 Fedora Update System 2015-01-20 15:36:49 UTC
guake-0.5.2-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/guake-0.5.2-1.fc21

Comment 2 Fedora Update System 2015-01-20 15:37:02 UTC
guake-0.5.2-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/guake-0.5.2-1.fc20

Comment 3 Fedora Update System 2015-01-21 23:01:31 UTC
Package guake-0.5.2-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing guake-0.5.2-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-0976/guake-0.5.2-1.fc20
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2015-02-03 11:59:08 UTC
guake-0.5.2-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 5 Fedora Update System 2015-02-03 12:05:17 UTC
guake-0.5.2-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.