Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1198229 - evince-browser-plugin should be Gtk2 only
Summary: evince-browser-plugin should be Gtk2 only
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: evince
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Marek Kašík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-03 15:32 UTC by Martin Stransky
Modified: 2016-08-27 10:31 UTC (History)
1 user (show)

Fixed In Version: evince-3.21.4-2.fc25
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-27 10:31:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Martin Stransky 2015-03-03 15:32:21 UTC
Description of problem:

evince-browser-plugin causes Firefox freeze. It's because it's build with Gtk3 and NPAPI plugins are supposed to run Gtk2 only, see:

http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/npapi.h#428

The Firefox freeze can be workaround but providing Gtk3 NPAPI plugin does not make any sense - it breaks NPAPI specification and no browser can load it anyway.

Comment 1 Marek Kašík 2015-03-12 11:54:57 UTC
Hi,

I've proposed a patch to evince which returns an error in NP_Initialize() or at NPP_New() if browser supports Gtk+-1.2 or Gtk+-2.0 only. Firefox doesn't freeze with it but it shows a black rectangle instead. I would expect that it will perform a default action instead or ask.

I also proposed a change to WebKit since it always returns '2' for NPNVToolkit in NPN_GetValue() even if it actually supports Gtk3 and should return e.g. '3' (I know, this is not in NPAPI but since WebKit dlopens the plugin before to check whether it links against gtk3 it should be safe for gtk2 plugins too).

See https://bugzilla.gnome.org/show_bug.cgi?id=738270 and https://bugs.webkit.org/show_bug.cgi?id=142616 for additional info.

I'll wait for evince's and WebKit's upstream decision.

Comment 2 Fedora End Of Life 2016-07-19 12:54:57 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 3 Marek Kašík 2016-08-15 15:39:33 UTC
Upstream of WebKit had enough time to fix this. I've pushed a patch to Fedora 25 and rawhide which checks NPNVToolkit value and returns error if it is NPNVGtk12 or NPNVGtk2.

Comment 4 Fedora Update System 2016-08-15 15:46:08 UTC
evince-3.21.4-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-37f28e19bc

Comment 5 Fedora Update System 2016-08-15 18:26:30 UTC
evince-3.21.4-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-37f28e19bc

Comment 6 Fedora Update System 2016-08-27 10:31:29 UTC
evince-3.21.4-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.