Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1214467 - Review Request: flxmlrpc - An xmlrpc library for the NBEMS suite of programs
Summary: Review Request: flxmlrpc - An xmlrpc library for the NBEMS suite of programs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: gil cattaneo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-04-22 18:47 UTC by Richard Shaw
Modified: 2015-05-14 06:27 UTC (History)
2 users (show)

Fixed In Version: flxmlrpc-0.1.3-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-10 23:38:19 UTC
Type: ---
Embargoed:
puntogil: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Richard Shaw 2015-04-22 18:47:19 UTC
Spec URL: http://hobbes1069.fedorapeople.org//flxmlrpc.spec
SRPM URL: http://hobbes1069.fedorapeople.org//flxmlrpc-0.1.2-1.fc21.src.rpm

Description:
Implementation of the XmlRpc protocol written in C++, based upon XmlRpc++0.7
and modified to provide additional XmlRpc Variable types.  It is used in fldigi,
flrig, flnet, flmsg, flarq, flamp, fllog; a suite of programs written for
amateur radio emergency communications.

flxmlrpc is designed to make it easy to incorporate Fl_XmlRpc client and
server support into C++ applications. Or use both client and server objects
in your app for easy peer-to-peer support.

Comment 1 Richard Shaw 2015-04-22 18:50:25 UTC
Scratch rawhide build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=9539518

Comment 2 gil cattaneo 2015-04-22 20:18:26 UTC
Issues:
=======
- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find COPYING in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
 IGNORE

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "LGPL (v3 or later)", "GPL (v2 or later)", "Unknown or generated". 9
     files have unknown license. Detailed output of licensecheck in
     /home/gil/1214467-flxmlrpc/srpms/review-flxmlrpc/licensecheck.txt
 GPL (v2 or later)
 -----------------
 flxmlrpc-0.1.2/build-aux/ltmain.sh
 flxmlrpc-0.1.2/ltmain.sh
 IGNORE
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/licenses
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/licenses
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
     Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0: http://www.w1hkj.com/xmlrpc-mods/flxmlrpc-0.1.2.tar.gz
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[!]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see attached
     diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: flxmlrpc-0.1.2-1.fc23.i686.rpm
          flxmlrpc-devel-0.1.2-1.fc23.i686.rpm
          flxmlrpc-0.1.2-1.fc21.src.rpm
flxmlrpc.i686: W: spelling-error Summary(en_US) xmlrpc 
flxmlrpc.i686: W: summary-not-capitalized C xmlrpc library for the NBEMS suite of programs
flxmlrpc.i686: W: spelling-error %description -l en_US fldigi -> digital
flxmlrpc.i686: W: spelling-error %description -l en_US flrig -> frig, fl rig, fl-rig
flxmlrpc.i686: W: spelling-error %description -l en_US flnet -> fleet, fl net, fl-net
flxmlrpc.i686: W: spelling-error %description -l en_US flmsg -> flimsy
flxmlrpc.i686: W: spelling-error %description -l en_US flarq -> flare
flxmlrpc.i686: W: spelling-error %description -l en_US flamp -> flap, lamp, flame
flxmlrpc.i686: W: spelling-error %description -l en_US fllog -> flog, fl log, fl-log
flxmlrpc.i686: W: invalid-url URL: http://www.w1hkj.com <urlopen error timed out>
flxmlrpc.i686: E: zero-length /usr/share/doc/flxmlrpc/ChangeLog
flxmlrpc-devel.i686: W: invalid-url URL: http://www.w1hkj.com <urlopen error timed out>
flxmlrpc-devel.i686: W: no-documentation
flxmlrpc.src: W: spelling-error Summary(en_US) xmlrpc 
flxmlrpc.src: W: summary-not-capitalized C xmlrpc library for the NBEMS suite of programs
flxmlrpc.src: W: spelling-error %description -l en_US fldigi -> digital
flxmlrpc.src: W: spelling-error %description -l en_US flrig -> frig, fl rig, fl-rig
flxmlrpc.src: W: spelling-error %description -l en_US flnet -> fleet, fl net, fl-net
flxmlrpc.src: W: spelling-error %description -l en_US flmsg -> flimsy
flxmlrpc.src: W: spelling-error %description -l en_US flarq -> flare
flxmlrpc.src: W: spelling-error %description -l en_US flamp -> flap, lamp, flame
flxmlrpc.src: W: spelling-error %description -l en_US fllog -> flog, fl log, fl-log
flxmlrpc.src: W: invalid-url URL: http://www.w1hkj.com <urlopen error timed out>
flxmlrpc.src: W: invalid-url Source0: http://www.w1hkj.com/xmlrpc-mods/flxmlrpc-0.1.2.tar.gz <urlopen error timed out>
3 packages and 0 specfiles checked; 1 errors, 23 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Diff spec file in url and in SRPM
---------------------------------
--- /home/gil/1214467-flxmlrpc/srpms/flxmlrpc.spec	2015-04-22 20:46:58.000000000 +0200
+++ /home/gil/1214467-flxmlrpc/srpms/review-flxmlrpc/srpm-unpacked/flxmlrpc.spec	2015-04-22 20:35:05.000000000 +0200
@@ -2,5 +2,5 @@
 Version:        0.1.2
 Release:        1%{?dist}
-Summary:        An xmlrpc library for the NBEMS suite of programs
+Summary:        xmlrpc library for the NBEMS suite of programs
 
 License:        LGPLv3+
@@ -8,4 +8,6 @@
 Source0:        http://www.w1hkj.com/xmlrpc-mods/%{name}-%{version}.tar.gz
 
+#BuildRequires:  
+#Requires:       
 
 %description


Requires
--------
flxmlrpc-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    flxmlrpc(x86-32)

flxmlrpc (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6
    libgcc_s.so.1
    libgcc_s.so.1(GCC_3.0)
    libm.so.6
    libstdc++.so.6
    libstdc++.so.6(CXXABI_1.3)
    rtld(GNU_HASH)



Provides
--------
flxmlrpc-devel:
    flxmlrpc-devel
    flxmlrpc-devel(x86-32)
    pkgconfig(flxmlrpc)

flxmlrpc:
    flxmlrpc
    flxmlrpc(x86-32)
    libflxmlrpc.so.1



Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -vpn flxmlrpc -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 3 gil cattaneo 2015-04-22 20:21:24 UTC
See above:
Diff spec file in url and in SRPM
[!]: Sources can be downloaded from URI in Source: tag
NON BLOCKING ISSUES
Please, fix before import

Comment 4 Richard Shaw 2015-04-22 21:04:44 UTC
Whoops! I updated the spec but forgot to create a new SRPM.

No worries, I'll definitely fix that before importing.

Comment 5 Richard Shaw 2015-04-22 21:23:54 UTC
I have uploaded a new SRPM if you want to check it out but if you run rpmlint directly on the spec file the source URL issue is not showing up.

Comment 6 gil cattaneo 2015-04-22 21:59:19 UTC
APPROVED

Comment 7 Richard Shaw 2015-04-23 13:17:15 UTC
New Package SCM Request
=======================
Package Name: flxmlrpc
Short Description: An xmlrpc library for the NBEMS suite of programs
Upstream URL: http://www.w1hkj.com/
Owners: hobbes1069
Branches: f20 f21 f22 epel7
InitialCC:

Comment 8 Richard Shaw 2015-04-23 13:17:35 UTC
Thanks for the quick review Gil!

Comment 9 Gwyn Ciesla 2015-04-23 14:25:57 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2015-04-28 13:21:09 UTC
flxmlrpc-0.1.3-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/flxmlrpc-0.1.3-1.el7

Comment 11 Fedora Update System 2015-04-28 13:21:15 UTC
flxmlrpc-0.1.3-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/flxmlrpc-0.1.3-1.fc20

Comment 12 Fedora Update System 2015-04-28 13:21:23 UTC
flxmlrpc-0.1.3-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/flxmlrpc-0.1.3-1.fc21

Comment 13 Fedora Update System 2015-04-28 13:21:29 UTC
flxmlrpc-0.1.3-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/flxmlrpc-0.1.3-1.fc22

Comment 14 Fedora Update System 2015-04-28 19:15:41 UTC
flxmlrpc-0.1.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 15 Fedora Update System 2015-05-10 23:38:19 UTC
flxmlrpc-0.1.3-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 16 Fedora Update System 2015-05-10 23:39:16 UTC
flxmlrpc-0.1.3-1.fc22 has been pushed to the Fedora 22 stable repository.

Comment 17 Fedora Update System 2015-05-14 06:27:27 UTC
flxmlrpc-0.1.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.