Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1222797 - RFE: Support GTK3 and new notification system to support newer GNOME desktops
Summary: RFE: Support GTK3 and new notification system to support newer GNOME desktops
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: setroubleshoot
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Lautrbach
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1230091 1309395 1530639 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-19 07:51 UTC by Kamil Páral
Modified: 2018-01-30 18:04 UTC (History)
8 users (show)

Fixed In Version: setroubleshoot-3.3.15-1.fc27
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-01-30 18:04:38 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
screenshot (413.51 KB, image/png)
2015-05-19 08:02 UTC, Kamil Páral 		no flags Details
View All

Description Kamil Páral 2015-05-19 07:51:27 UTC 
Description of problem:
If an alert occurs in Fedora 22, a new notification is added to the notification menu (top center). But after clicking on it, nothing happens. That is a bug, the setroubleshoot window should open instead showing the particular denial mentioned.

Also, a tray icon is added to the bottom left. After clicking on it, it runs setroubleshoot. But the icon should not be there, at least in GNOME. There's no reason to duplicate this as notifications and tray icons. The purpose of new GNOME notification system is that have a persistent overview of past alerts.

Version-Release number of selected component (if applicable):
setroubleshoot-server-3.2.24-1.fc22.x86_64
setroubleshoot-3.2.24-1.fc22.x86_64
setroubleshoot-plugins-3.0.61-1.fc22.noarch
gnome-shell-3.16.2-1.fc22.x86_64

How reproducible:
always

Steps to Reproduce:
1. cause an alert (I'm not sure how, but you'll surely know)
2. try to click on the notification in the notification menu, nothing happens
3. see that an icon was added to the tray (you might need to expand it first), shouldn't happen
Comment 1 Kamil Páral 2015-05-19 08:02:45 UTC 
Created attachment 1027004 [details]
screenshot

This is how it looks at the moment, after a denial happens.
Comment 2 Petr Lautrbach 2015-06-02 14:45:39 UTC 
It would need to rewrite seaplet to GTK+3 and to GNotification. I'd consider this as RFE for future releases.
Comment 3 Petr Lautrbach 2015-06-10 09:36:37 UTC 
*** Bug 1230091 has been marked as a duplicate of this bug. ***
Comment 4 Miroslav Grepl 2015-06-19 13:12:14 UTC 
(In reply to Petr Lautrbach from comment #2)
> It would need to rewrite seaplet to GTK+3 and to GNotification. I'd consider
> this as RFE for future releases.

I agree.
Comment 5 Jan Kurik 2015-07-15 14:08:01 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23
Comment 6 Petr Lautrbach 2016-04-29 15:05:56 UTC 
*** Bug 1309395 has been marked as a duplicate of this bug. ***
Comment 7 Fedora End Of Life 2017-07-25 18:55:19 UTC 
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
Comment 8 fednuc 2017-07-25 18:56:57 UTC 
Still a problem in F26. Someone please update the version.
Comment 9 Jan Kurik 2017-08-15 06:55:05 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle.
Changing version to '27'.
Comment 10 fednuc 2017-08-24 18:47:57 UTC 
Because of https://bugzilla.gnome.org/show_bug.cgi?id=785956 (removal of the legacy tray entirely from GNOME in 3.26), there will not now be a functional SELinux Troubleshooter notification until this bug is fixed.
Comment 11 fednuc 2017-11-22 22:15:58 UTC 
@Michael, this isn't an RFE, it is a functional regression on the *official/primary* Fedora desktop.

AFAICS supporting the "new" (actually not new at all at this point - bug is from *2015*) notification system is also orthogonal to GTK3 support, and could be handled without porting (in the worst case, with a notifier shim).
Comment 12 Petr Lautrbach 2017-11-23 06:39:16 UTC 
Stephen, all, are you familiar with new notification system? Would you be able to come up with some initial change and attach it here or create a PR on pagure.io/setroubleshoot or github.com/fedora-selinux/setroubleshoot?

I would really help to move things forward.
Comment 13 fednuc 2017-11-25 13:15:42 UTC 
In Python/GObject yes, but don't have time to familiarise myself with the source/work out if it's in the Py or C parts at the moment unfortunately.
Comment 14 Petr Lautrbach 2018-01-08 07:29:50 UTC 
I started rewrite of seapplet to use Gnome 3 notifications in https://pagure.io/fork/plautrba/setroubleshoot/commits/WIP-gnome3-notifications

Builds are available 

https://copr.fedorainfracloud.org/coprs/plautrba/setroubleshoot/

Original seapplet was renamed to seappletlegacy and the new seapplet.py is seapplet now.
Comment 15 Petr Lautrbach 2018-01-08 07:30:44 UTC 
*** Bug 1530639 has been marked as a duplicate of this bug. ***
Comment 16 Michael Cronenworth 2018-01-09 15:50:44 UTC 
Petr, thanks for your work. When I attempt to run the new seapplet I get the following message:

$ seapplet
Traceback (most recent call last):
  File "/usr/bin/seapplet", line 28, in <module>
    from pydbus import SystemBus
ModuleNotFoundError: No module named 'pydbus'

Installing "python3-pydbus" resolves the issue so you may wish to add a Requires for it.
Comment 17 Petr Lautrbach 2018-01-19 16:54:43 UTC 
So this is built from https://pagure.io/setroubleshoot/tree/764d0c3426cc93f0d57a21a361226b9abfb75459 in Rawhide now - setroubleshoot-3.3.15-1.fc28

If you want/need to use the original Gtk 2 seapplet, you can install setroubleshoot-legacy and change Exec= to /usr/bin/seappletlegacy in ~/.config/autostart/sealertauto.desktop
Comment 18 Fedora Update System 2018-01-22 08:56:24 UTC 
setroubleshoot-3.3.15-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8496be2ef4
Comment 19 Fedora Update System 2018-01-23 23:40:24 UTC 
setroubleshoot-3.3.15-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8496be2ef4
Comment 20 Fedora Update System 2018-01-30 18:04:38 UTC 
setroubleshoot-3.3.15-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.