Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1223349 - [abrt] geeqie: image_read_ahead_done_cb(): geeqie killed by SIGSEGV
Summary: [abrt] geeqie: image_read_ahead_done_cb(): geeqie killed by SIGSEGV
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: geeqie
Version: 22
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michael Schwendt
QA Contact: Fedora Extras Quality Assurance
URL: https://retrace.fedoraproject.org/faf...
Whiteboard: abrt_hash:f1321ae9134cbaca3306d4a7714...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-20 11:43 UTC by Richard Marko
Modified: 2016-02-01 02:23 UTC (History)
5 users (show)

Fixed In Version: geeqie-1.2-0.6.20150812git2b87884.fc23 geeqie-1.2-0.2.20150812git2b87884.fc22.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-10-03 18:00:19 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (20.35 KB, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
File: cgroup (190 bytes, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
File: core_backtrace (6.48 KB, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
File: dso_list (8.73 KB, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
File: environ (763 bytes, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
File: limits (1.29 KB, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
File: maps (50.60 KB, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
File: mountinfo (3.65 KB, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
File: namespaces (85 bytes, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
File: open_fds (791 bytes, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
File: proc_pid_status (976 bytes, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
File: var_log_messages (590 bytes, text/plain)
2015-05-20 11:43 UTC, Richard Marko
no flags Details
check for NULL (396 bytes, patch)
2015-08-07 20:41 UTC, Sami Farin
no flags Details | Diff

Description Richard Marko 2015-05-20 11:43:35 UTC
Description of problem:
Moved file currently opened by this app to another directory. Probably unretaled.

Version-Release number of selected component:
geeqie-1.2-0.1.20141130gita1afabd.fc22

Additional info:
reporter:       libreport-2.5.1
backtrace_rating: 4
cmdline:        geeqie --blank
crash_function: image_read_ahead_done_cb
executable:     /usr/bin/geeqie
global_pid:     2675
kernel:         4.0.3-300.fc22.x86_64
runlevel:       N 5
type:           CCpp
uid:            1000

Truncated backtrace:
Thread no. 1 (4 frames)
 #0 image_read_ahead_done_cb at image.c:480
 #1 _g_closure_invoke_va at gclosure.c:831
 #4 image_loader_emit_done_cb at image-load.c:273
 #9 gtk_main at gtkmain.c:1268

Comment 1 Richard Marko 2015-05-20 11:43:38 UTC
Created attachment 1027647 [details]
File: backtrace

Comment 2 Richard Marko 2015-05-20 11:43:39 UTC
Created attachment 1027648 [details]
File: cgroup

Comment 3 Richard Marko 2015-05-20 11:43:41 UTC
Created attachment 1027649 [details]
File: core_backtrace

Comment 4 Richard Marko 2015-05-20 11:43:42 UTC
Created attachment 1027650 [details]
File: dso_list

Comment 5 Richard Marko 2015-05-20 11:43:43 UTC
Created attachment 1027651 [details]
File: environ

Comment 6 Richard Marko 2015-05-20 11:43:44 UTC
Created attachment 1027652 [details]
File: limits

Comment 7 Richard Marko 2015-05-20 11:43:46 UTC
Created attachment 1027653 [details]
File: maps

Comment 8 Richard Marko 2015-05-20 11:43:48 UTC
Created attachment 1027654 [details]
File: mountinfo

Comment 9 Richard Marko 2015-05-20 11:43:49 UTC
Created attachment 1027655 [details]
File: namespaces

Comment 10 Richard Marko 2015-05-20 11:43:50 UTC
Created attachment 1027656 [details]
File: open_fds

Comment 11 Richard Marko 2015-05-20 11:43:51 UTC
Created attachment 1027657 [details]
File: proc_pid_status

Comment 12 Richard Marko 2015-05-20 11:43:52 UTC
Created attachment 1027658 [details]
File: var_log_messages

Comment 13 Sami Farin 2015-08-07 20:40:44 UTC
to reproduce: quickly keep pressing f (fullscreen) and page down (next file) keys.

attached patch is a kind of workaround, I did not inspect further is this threading issue etc

Comment 14 Sami Farin 2015-08-07 20:41:14 UTC
Created attachment 1060482 [details]
check for NULL

Comment 15 Michael Schwendt 2015-08-07 22:06:30 UTC
I've forwarded this to geeqie-devel@SF list.

Often such NULL-ptr checks only fix symptoms, not the cause of it.

What happens now if running into the error-condition while trying to load a valid file? I mean, it crashes for *valid* files because of some race-condition in rare cases (with your steps on how to reproduce it I've had to press F and PageDown dozens of times). Why would anything trigger this read-ahead callback with a NULL pointer? The source also does it upon error condition. So, the problem is elsewhere IMO.

Comment 16 Sami Farin 2015-08-07 22:30:49 UTC
Yes, it was fix for a symptom ("a kind of workaround"), I am letting other people spend time fixing the cause.

Comment 17 Michael Schwendt 2015-08-07 22:44:26 UTC
As a work-around, did you try "[ ] Preload next image" in general preferences?

Comment 18 Sami Farin 2015-08-08 07:10:18 UTC
I tried now. It seems to prevent the segfault from occurring.

Comment 19 Fedora Update System 2015-08-12 00:04:51 UTC
geeqie-1.2-0.2.20150812git2b87884.fc22.1 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/geeqie-1.2-0.2.20150812git2b87884.fc22.1

Comment 20 Fedora Update System 2015-08-13 16:56:13 UTC
Package geeqie-1.2-0.2.20150812git2b87884.fc22.1:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing geeqie-1.2-0.2.20150812git2b87884.fc22.1'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-13395/geeqie-1.2-0.2.20150812git2b87884.fc22.1
then log in and leave karma (feedback).

Comment 21 Fedora Update System 2015-08-27 03:52:30 UTC
geeqie-1.2-0.6.20150812git2b87884.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14376

Comment 22 Fedora Update System 2015-08-31 18:53:11 UTC
geeqie-1.2-0.6.20150812git2b87884.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update geeqie'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14376

Comment 23 Fedora Update System 2015-10-03 18:00:15 UTC
geeqie-1.2-0.6.20150812git2b87884.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2015-12-07 21:21:58 UTC
geeqie-1.2-0.2.20150812git2b87884.fc22.1 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.