Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1224648 - Review Request: dnf-plugin-spacewalk - DNF plugin for Spacewalk
Summary: Review Request: dnf-plugin-spacewalk - DNF plugin for Spacewalk
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-05-25 08:59 UTC by Michael Mráka
Modified: 2016-02-08 23:48 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-08 23:48:20 UTC
Type: ---
Embargoed:
msuchy: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Michael Mráka 2015-05-25 08:59:58 UTC 
Spec URL: https://raw.githubusercontent.com/spacewalkproject/spacewalk/master/client/rhel/dnf-plugin-spacewalk/dnf-plugin-spacewalk.spec
SRPM URL: http://koji.spacewalkproject.org/kojifiles/packages/dnf-plugin-spacewalk/2.4.5/1.fc21/src/dnf-plugin-spacewalk-2.4.5-1.fc21.src.rpm
Description: DNF plugin provides access to a Spacewalk server for software updates.
Fedora Account System Username: mmraka
Comment 1 Miroslav Suchý 2015-05-25 09:56:33 UTC 
Buildroot tag and relevant part in %clean is not needed unless you aim to RHEL5
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

Source0: https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz
There is no tar.gz of this name on this URL.

>%install
>rm -rf $RPM_BUILD_ROOT

Only needed for EL5. It can be safely removed for Fedoras and EL6+.

It would be nice if you can consistenly use macros - $FOO vs %{foo}. I suggest to replace $RPM_BUILD_ROOT by %{buildroot}

It would be nice if you can (as upstream) include LICENSE file (with %license macro).
Comment 2 Michael Mráka 2015-05-25 12:59:04 UTC 
Fixed.
Comment 3 Miroslav Suchý 2015-05-25 14:20:05 UTC 
Still valid:
Source0: https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz
There is no tar.gz of this name on this URL.
Comment 4 Miroslav Suchý 2015-05-25 14:24:18 UTC 
Either upload the tar.gz to this location. Or put there something like:

# source is created by:
# git clone https://github.com/spacewalkproject/spacewalk.git
# cd client/rhel/dnf-plugin-spacewalk/ && tito build --tgz
Source0:        %{name}-%{version}.tar.gz
Comment 5 Michael Mráka 2015-06-12 09:15:18 UTC 
Updated spec and srpm (dnf-plugin-spacewalk-2.4.12):

Spec URL: https://raw.githubusercontent.com/spacewalkproject/spacewalk/master/client/rhel/dnf-plugin-spacewalk/dnf-plugin-spacewalk.spec
SRPM URL: http://koji.spacewalkproject.org/kojifiles/packages/dnf-plugin-spacewalk/2.4.12/1.fc21/src/dnf-plugin-spacewalk-2.4.12-1.fc21.src.rpm
Comment 6 Miroslav Suchý 2015-06-15 08:12:25 UTC 
APPROVED
Comment 7 Michael Mráka 2015-08-13 09:18:16 UTC 
New Package SCM Request
=======================
Package Name: dnf-plugin-spacewalk
Short Description: DNF plugin for Spacewalk
Upstream URL: https://fedorahosted.org/spacewalk/
Owners: mmraka
Branches: f21 f22 f23
InitialCC:
Comment 8 Gwyn Ciesla 2015-08-17 13:25:13 UTC 
Git done (by process-git-requests).
Comment 9 Fedora Update System 2015-08-18 09:32:40 UTC 
dnf-plugin-spacewalk-2.4.13-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/dnf-plugin-spacewalk-2.4.13-1.fc21
Comment 10 Fedora Update System 2015-08-18 09:32:46 UTC 
dnf-plugin-spacewalk-2.4.13-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/dnf-plugin-spacewalk-2.4.13-1.fc22
Comment 11 Fedora Update System 2015-08-18 09:32:53 UTC 
dnf-plugin-spacewalk-2.4.13-1.fc23 has been submitted as an update for Fedora 23.
https://admin.fedoraproject.org/updates/dnf-plugin-spacewalk-2.4.13-1.fc23
Comment 12 Fedora Update System 2015-08-19 07:50:34 UTC 
Package dnf-plugin-spacewalk-2.4.13-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing dnf-plugin-spacewalk-2.4.13-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-13608/dnf-plugin-spacewalk-2.4.13-1.fc21
then log in and leave karma (feedback).
Comment 13 Fedora Update System 2015-08-22 02:52:06 UTC 
dnf-plugin-spacewalk-2.4.15-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update dnf-plugin-spacewalk'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-13612
Note You need to log in before you can comment on or make changes to this bug.