Since it's been retired more than 2 weeks it will need to be re-reviewed.

Spec URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets.spec 
SRPM URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets-0.36.3-18.fc22.src.rpm
Summary     : Architecture for desktop applets
Description: 'gDesklets' provides an advanced architecture for desktop applets -
tiny displays that sit on your desktop such as status meters, icon
bars, weather sensors, news tickers.

This package was orphan on F20 and retired on F21 , 
since it is maintained on https://launchpad.net/gdesklets

can you take this https://bugzilla.redhat.com/show_bug.cgi?id=1228162 ?

seem there are some issues:
1. in install section unneeded rm -rf %{buildroot}
2. see https://fedoraproject.org/wiki/Packaging:AppData
"If a package contains a GUI application, then it SHOULD also install a .appdata.xml file into %{_datadir}/appdata/. Installed .appdata.xml files MUST follow the AppData specification page."

an other issues: you must use %license macro for COPYING file

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in gdesklets
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
 IGNORE: already done
- Package contains BR: python2-devel or python3-devel
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
 Please, fix
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.
 IGNORE: already done
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/acls/name/gdesklets
  See:
  https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in gdesklets
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database
 Please, fix

===== MUST items =====

C/C++:
[?]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
  Please, fix license field should be GPLv2+
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "GPL (v2 or later) (with incorrect
     FSF address)", "Unknown or generated". 192 files have unknown license.
     Detailed output of licensecheck in
     /home/gil/1229518-gdesklets/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/icons/gnome/48x48,
     /usr/share/icons/gnome/48x48/mimetypes, /usr/share/icons/gnome
[?]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/gdesklets/Displays
     (gdesklets-quote-of-the-day, gdesklets), /usr/share/gdesklets
     (gdesklets-quote-of-the-day, gdesklets)
[x]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
     Note: Especially check following dirs for bundled code:
     /home/gil/1229518-gdesklets/upstream-
     unpacked/Source0/gdesklets-0.36.3/Sensors/External
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[?]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 143360 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python

===== SHOULD items =====

Generic:
[!]: update-mime-database is invoked in %post and %postun if package stores
     mime configuration in /usr/share/mime/packages.
     Note: mimeinfo files in: gdesklets
     See:
     http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[?]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: #%define alphatag beta
   Please, remove
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[!]: Package should not use obsolete m4 macros
     Note: Some obsoleted macros found, see the attachment.
     See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
[?]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 1003520 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: gdesklets-0.36.3-18.fc23.i686.rpm
          gdesklets-0.36.3-18.fc23.src.rpm
gdesklets.i686: W: invalid-url URL: https://launchpad.net/gdesklets <urlopen error _ssl.c:489: The handshake operation timed out>
gdesklets.i686: E: incorrect-fsf-address /usr/share/doc/gdesklets/COPYING
gdesklets.i686: W: non-conffile-in-etc /etc/xdg/autostart/gdesklets.desktop
gdesklets.i686: E: non-executable-script /usr/lib/gdesklets/Displays/15pieces/make_tiles.sh 0644L /bin/bash
gdesklets.i686: W: desktopfile-without-binary /usr/share/applications/gdesklets.desktop gdesklets
gdesklets.src:1: W: macro-in-comment %define
gdesklets.src:16: W: mixed-use-of-spaces-and-tabs (spaces: line 16, tab: line 3)
2 packages and 0 specfiles checked; 2 errors, 5 warnings.




Rpmlint (debuginfo)
-------------------
Checking: gdesklets-debuginfo-0.36.3-18.fc23.i686.rpm
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/utils/svg.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/utils/x11.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/libdesklets/system/gtop.c
1 packages and 0 specfiles checked; 3 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
INFO: mock.py version 1.2.9 starting (python version = 2.7.5)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled ccache
Mock Version: 1.2.9
INFO: Mock Version: 1.2.9
Traceback (most recent call last):
  File "/usr/sbin/mock", line 831, in <module>
    main()
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/sbin/mock", line 653, in main
    run_command(options, args, config_opts, commands, buildroot, state)
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/sbin/mock", line 708, in run_command
    commands.init()
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/backend.py", line 123, in init
    self.buildroot.initialize(**kwargs)
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/buildroot.py", line 84, in initialize
    self._init(prebuild=prebuild, do_log=do_log)
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/buildroot.py", line 128, in _init
    self._setup_devices()
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/buildroot.py", line 442, in _setup_devices
    os.symlink("/proc/self/mounts", self.make_chroot_path('etc', 'mtab'))
OSError: [Errno 17] File exists



Requires
--------
gdesklets (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/env
    gnome-python2-gconf
    libatk-1.0.so.0
    libc.so.6
    libcairo.so.2
    libfontconfig.so.1
    libfreetype.so.6
    libgdk-x11-2.0.so.0
    libgdk_pixbuf-2.0.so.0
    libgio-2.0.so.0
    libglib-2.0.so.0
    libgobject-2.0.so.0
    libgtk-x11-2.0.so.0
    libgtop-2.0.so.10
    libm.so.6
    libpango-1.0.so.0
    libpangocairo-1.0.so.0
    libpangoft2-1.0.so.0
    libpthread.so.0
    librsvg-2.so.2
    rtld(GNU_HASH)



Provides
--------
gdesklets:
    application()
    application(gdesklets.desktop)
    gdesklets
    gdesklets(x86-32)
    mimehandler(application/x-gdesklets-display)



Unversioned so-files
--------------------
gdesklets: /usr/lib/gdesklets/libdesklets/system/gtop.so
gdesklets: /usr/lib/gdesklets/utils/svg.so
gdesklets: /usr/lib/gdesklets/utils/tiling.so
gdesklets: /usr/lib/gdesklets/utils/x11.so

Source checksums
----------------
https://launchpad.net/gdesklets/0.3x/release-of-0.36.3/+download/gdesklets-0.36.3.tar.bz2 :
  CHECKSUM(SHA256) this package     : 805b0343635e5dcfd24d23ab10f0153ab5135dc971ba1712fbf4bddbeee26af5
  CHECKSUM(SHA256) upstream package : 805b0343635e5dcfd24d23ab10f0153ab5135dc971ba1712fbf4bddbeee26af5


AutoTools: Obsoleted m4s found
------------------------------
  AC_PROG_LIBTOOL found in: /home/gil/1229518-gdesklets/upstream-
  unpacked/Source0/gdesklets-0.36.3/configure.ac:20
  AM_CONFIG_HEADER found in: /home/gil/1229518-gdesklets/upstream-
  unpacked/Source0/gdesklets-0.36.3/configure.ac:8


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 1229518 -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

- Add patch to fix obsoleted m4s.
- Add desktop-database scriptlet and desktop-file-validate.
- Fix License tag and License macro.
- Spec clean up.
- Fix mixed-use-of-spaces-and-tabs.


Spec URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets.spec 
SRPM URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets-0.36.3-18.fc22.src.rpm

Issues:

https://fedoraproject.org/wiki/Packaging:AppData
"If a package contains a GUI application, then it SHOULD also install a .appdata.xml file into %{_datadir}/appdata/. Installed .appdata.xml files MUST follow the AppData specification page."

you should add a similar file, with the procedures reported in the above page

NOTE: i never used this software, please change "FIXME" with appropriate value

<?xml version="1.0" encoding="UTF-8"?>
​<component type="FIXME">
​  <id>gdesklets</id>
​  <extends>gdesklets.desktop</extends>
​  <name>gDesklets</name>
​  <summary>FIXME</summary>
​  <url type="homepage">https://launchpad.net/gdesklets</url>
​  <url type="bugtracker">https://bugs.launchpad.net/gdesklets</url>
​  <metadata_license>FIXME</metadata_license>
​  <project_license>GPL-2.0+</project_license>
​</component>

BuildRequires:  libappstream-glib

install -Dp %{SOURCE1} %{buildroot}/%{_datadir}/appdata/%{name}.appdata.xml
%endif

appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/%{name}.appdata.xml

and request to upstream to integrate it in their distribution
https://fedoraproject.org/wiki/Packaging:AppData#.metainfo.xml_file_creation

NON blocking issues:
gdesklets.i686: E: incorrect-fsf-address /usr/share/doc/gdesklets/COPYING
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/utils/svg.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/utils/x11.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/libdesklets/system/gtop.c

https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
Please, report to upstream the problem

desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
is unnecessary, cause desktop-file-install already validate the .desktop file

Created attachment 1037068 [details]
gdesklets.appdata.xml example

(In reply to gil cattaneo from comment #9)
> Created attachment 1037068 [details]
> gdesklets.appdata.xml example

Thanks you already have a new version uploaded, I hadn't use yet gdesklets.appdata.xml example , but I will update soon . 

- Dropped desktop-file-validate.
- Added AppData https://fedoraproject.org/wiki/Packaging:AppData

Spec URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets.spec 
SRPM URL: https://sergiomb.fedorapeople.org/gdesklets/gdesklets-0.36.3-18.fc22.src.rpm

(In reply to Sergio Monteiro Basto from comment #10)
> gdesklets.appdata.xml example , but I will update soon . 

Please, correct the description section, now you use comical.appdata.xml ones
are there some problems with the description in the attached file?

(In reply to gil cattaneo from comment #11)
> (In reply to Sergio Monteiro Basto from comment #10)
> > gdesklets.appdata.xml example , but I will update soon . 
> 
> Please, correct the description section, now you use comical.appdata.xml ones
> are there some problems with the description in the attached file?

fix also the summary "usually the same as the Comment value in the desktop file"
as reported @ http://people.freedesktop.org/~hughsient/appdata/

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in gdesklets
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/acls/name/gdesklets
  See:
  https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names


===== MUST items =====

C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/licenses
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/icons/gnome/48x48,
     /usr/share/appdata, /usr/share/icons/gnome/48x48/mimetypes,
     /usr/share/licenses, /usr/share/icons/gnome
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/gdesklets/Displays
     (gdesklets-quote-of-the-day, gdesklets), /usr/share/gdesklets
     (gdesklets-quote-of-the-day, gdesklets)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
     contains desktop file(s) with a MimeType: entry.
     Note: desktop file(s) with MimeType entry in gdesklets
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 122880 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel

===== SHOULD items =====

Generic:
[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0: https://launchpad.net/gdesklets/0.3x
     /release-of-0.36.3/+download/gdesklets-0.36.3.tar.bz2
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[!]: update-mime-database is invoked in %post and %postun if package stores
     mime configuration in /usr/share/mime/packages.
     Note: mimeinfo files in: gdesklets
     See:
     http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[?]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: #%define alphatag beta
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 1013760 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Package should not use obsolete m4 macros
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: gdesklets-0.36.3-18.fc23.i686.rpm
          gdesklets-0.36.3-18.fc23.src.rpm
gdesklets.i686: E: incorrect-fsf-address /usr/share/licenses/gdesklets/COPYING
gdesklets.i686: W: non-conffile-in-etc /etc/xdg/autostart/gdesklets.desktop
gdesklets.i686: E: script-without-shebang /usr/share/appdata/gdesklets.appdata.xml
gdesklets.i686: E: non-executable-script /usr/lib/gdesklets/Displays/15pieces/make_tiles.sh 0644L /bin/bash
gdesklets.i686: W: desktopfile-without-binary /usr/share/applications/gdesklets.desktop gdesklets
gdesklets.src:1: W: macro-in-comment %define
2 packages and 0 specfiles checked; 3 errors, 3 warnings.




Rpmlint (debuginfo)
-------------------
Checking: gdesklets-debuginfo-0.36.3-18.fc23.i686.rpm
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/utils/svg.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/utils/x11.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/libdesklets/system/gtop.c
1 packages and 0 specfiles checked; 3 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
INFO: mock.py version 1.2.9 starting (python version = 2.7.5)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled ccache
Mock Version: 1.2.9
INFO: Mock Version: 1.2.9
Traceback (most recent call last):
  File "/usr/sbin/mock", line 831, in <module>
    main()
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/sbin/mock", line 653, in main
    run_command(options, args, config_opts, commands, buildroot, state)
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/sbin/mock", line 708, in run_command
    commands.init()
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/backend.py", line 123, in init
    self.buildroot.initialize(**kwargs)
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/buildroot.py", line 84, in initialize
    self._init(prebuild=prebuild, do_log=do_log)
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/buildroot.py", line 128, in _init
    self._setup_devices()
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/buildroot.py", line 442, in _setup_devices
    os.symlink("/proc/self/mounts", self.make_chroot_path('etc', 'mtab'))
OSError: [Errno 17] File exists



Requires
--------
gdesklets (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/env
    gnome-python2-gconf
    libatk-1.0.so.0
    libc.so.6
    libcairo.so.2
    libfontconfig.so.1
    libfreetype.so.6
    libgdk-x11-2.0.so.0
    libgdk_pixbuf-2.0.so.0
    libgio-2.0.so.0
    libglib-2.0.so.0
    libgobject-2.0.so.0
    libgtk-x11-2.0.so.0
    libgtop-2.0.so.10
    libm.so.6
    libpango-1.0.so.0
    libpangocairo-1.0.so.0
    libpangoft2-1.0.so.0
    libpthread.so.0
    librsvg-2.so.2
    rtld(GNU_HASH)



Provides
--------
gdesklets:
    appdata()
    appdata(gdesklets.appdata.xml)
    application()
    application(gdesklets.desktop)
    gdesklets
    gdesklets(x86-32)
    mimehandler(application/x-gdesklets-display)



Unversioned so-files
--------------------
gdesklets: /usr/lib/gdesklets/libdesklets/system/gtop.so
gdesklets: /usr/lib/gdesklets/utils/svg.so
gdesklets: /usr/lib/gdesklets/utils/tiling.so
gdesklets: /usr/lib/gdesklets/utils/x11.so

Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 1229518 -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

NON blocking issues:
gdesklets.i686: E: incorrect-fsf-address /usr/share/doc/gdesklets/COPYING
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/utils/svg.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/utils/x11.c
gdesklets-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gdesklets-0.36.3/libdesklets/system/gtop.c

https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
Please, you should report to upstream the problem

Please, correct the description section, now you use comical.appdata.xml ones
are there some problems with the description in the attached file?
fix also the summary "usually the same as the Comment value in the desktop file"
as reported @ http://people.freedesktop.org/~hughsient/appdata/
Approved

(In reply to gil cattaneo from comment #13)

> INFO: enabled ccache
> Mock Version: 1.2.9
> INFO: Mock Version: 1.2.9
> Traceback (most recent call last):
>   File "/usr/sbin/mock", line 831, in <module>
>     main()

BTW: 
mock-1.2.10-1.fc21 fix this https://admin.fedoraproject.org/updates/search/mock
 
(In reply to gil cattaneo from comment #14)
> https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
> Please, you should report to upstream the problem

I will report upstream and also I will report others patches left .
 
> Please, correct the description section, now you use comical.appdata.xml ones
> are there some problems with the description in the attached file?
> fix also the summary "usually the same as the Comment value in the desktop
> file"
> as reported @ http://people.freedesktop.org/~hughsient/appdata/

Done 

> Approved

Thanks 


Package Change Request
======================
Package Name: gdesklets
New Branches: f21 f22 devel
Owners: sergiomb

Package Change Request
======================
Package Name: gdesklets
New Branches: f21 devel
Owners: sergiomb

I already have f22 approved with Request new branch in : 
https://admin.fedoraproject.org/pkgdb/package/gdesklets/

Complete.

Hi, 
I can't build it. Koji says:

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10010324
open (arm04-builder07.arm.fedoraproject.org) -> FAILED: BuildError: package gdesklets is blocked for tag f23

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10010476
open (arm02-builder21.arm.fedoraproject.org) -> FAILED: BuildError: package gdesklets is blocked for tag f22-updates-candidate


on https://koji.fedoraproject.org/koji/packageinfo?packageID=1828 
we got in tags :

Name Owner :	Included?
(...)
f20 	   sergiomb 	yes
f21 	     orphan 	no 	
f21-beta 	orphan 	no 	
f22-Alpha 	orphan 	no 	
f22-Beta 	orphan 	no

Shouldn't all the owners be me ( sergiomb ) ?

have request the package for the requested branch?
example https://fedorahosted.org/rel-eng/ticket/5104

sorry, i am not yet awake, i meant
you have requested to *unlock* the package to the branch in question?
see https://fedorahosted.org/rel-eng/ticket/5104

I'm not sure that is solved by rel-eng ticket see  https://fedorahosted.org/rel-eng/ticket/6148 :) 

koji list-pkgs --show-blocked --package gdesklets

gdesklets      f20                  sergiomb       
gdesklets      f21                  orphan          [BLOCKED]
gdesklets      f21-beta             orphan          [BLOCKED]
gdesklets      f22-Alpha            orphan          [BLOCKED]
gdesklets      f22-Beta             orphan          [BLOCKED]

(In reply to Sergio Monteiro Basto from comment #21)
> I'm not sure that is solved by rel-eng ticket see 
> https://fedorahosted.org/rel-eng/ticket/6148 :) 
> 
> koji list-pkgs --show-blocked --package gdesklets
> 
> gdesklets      f20                  sergiomb       
> gdesklets      f21                  orphan          [BLOCKED]
> gdesklets      f21-beta             orphan          [BLOCKED]
> gdesklets      f22-Alpha            orphan          [BLOCKED]
> gdesklets      f22-Beta             orphan          [BLOCKED]

this mean: you should open an rel-eng ticket as in previous comment#20

see:
https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Package

https://fedorahosted.org/rel-eng/ticket/6194

gdesklets-0.36.3-18.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/gdesklets-0.36.3-18.fc22

gdesklets-0.36.3-18.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/gdesklets-0.36.3-18.fc21

gdesklets-0.36.3-18.fc21 has been pushed to the Fedora 21 testing repository.

gdesklets-0.36.3-18.fc22 has been pushed to the Fedora 22 stable repository.

gdesklets-0.36.3-18.fc21 has been pushed to the Fedora 21 stable repository.