Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1231644 - orientation hack makes loading image 100x slower
Summary: orientation hack makes loading image 100x slower
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: geeqie
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
Assignee: Michael Schwendt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-15 07:12 UTC by Sami Farin
Modified: 2015-12-07 21:22 UTC (History)
2 users (show)

Fixed In Version: geeqie-1.2-0.6.20150812git2b87884.fc23 geeqie-1.2-0.2.20150812git2b87884.fc22.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-10-03 18:00:17 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
disable untested hack in rt_tile_render() (550 bytes, patch)
2015-06-15 07:12 UTC, Sami Farin 		no flags Details | Diff
View All

Description Sami Farin 2015-06-15 07:12:49 UTC 
Created attachment 1038799 [details]
disable untested hack in rt_tile_render()

Description of problem:
10 Mpixel images with EXIF_ORIENTATION_TOP_LEFT take five seconds to render, but just a jiffy with other orientations.

With the attached patch all is back to normal.

Version-Release number of selected component (if applicable):
1.2-0.1.20141130gita1afabd.fc22

How reproducible:
always

Steps to Reproduce:
1. view image with EXIF_ORIENTATION_TOP_LEFT in 100% size 
2.
3.

Actual results:
needs five seconds of CPU time to render

Expected results:
maybe 0.05s

Additional info:
CPU usage mostly in gdk_cairo_set_source_pixbuf.

Thread 1 (Thread 0x7faf01a4c9c0 (LWP 23974)):
#0  0x00007faf00db7dcc in IA__gdk_cairo_set_source_pixbuf (cr=0x7faf03da3d80, pixbuf=<optimized out>, pixbuf_x=-1920, pixbuf_y=-1280) at gdkcairo.c:239
#1  0x00007faf019a2328 in rt_tile_render (rt=rt@entry=0x7faf036379b0, it=it@entry=0x7faf03e028e0, x=<optimized out>, x@entry=0, y=<optimized out>, y@entry=0, w=w@entry=128, h=h@entry=128, new_data=1, fast=<optimized out>) at renderer-tiles.c:1428
#2  0x00007faf019a3593 in rt_queue_draw_idle_cb (fast=1, new_data=<optimized out>, h=128, w=128, y=0, x=0, it=0x7faf03e028e0, rt=0x7faf036379b0) at renderer-tiles.c:1466
#3  0x00007faf019a3593 in rt_queue_draw_idle_cb (data=0x7faf036379b0) at renderer-tiles.c:1600
#4  0x00007faf00a708ca in g_main_context_dispatch (context=0x7faf0351a570) at gmain.c:3122
#5  0x00007faf00a708ca in g_main_context_dispatch (context=context@entry=0x7faf0351a570) at gmain.c:3737
#6  0x00007faf00a70c70 in g_main_context_iterate (context=0x7faf0351a570, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3808
#7  0x00007faf00a70f92 in g_main_loop_run (loop=0x7faf037df210) at gmain.c:4002
#8  0x00007faf0119ef37 in IA__gtk_main () at gtkmain.c:1268
#9  0x00007faf01929ff2 in main (argc=1, argv=0x7ffe9b603148) at main.c:921
Comment 1 Michael Schwendt 2015-06-15 08:46:30 UTC 
Could you take that topic to geeqie-devel@ list, please?

  http://geeqie.org -> http://sourceforge.net/mail/?group_id=222125

What you refer to as "hack" has not been added by Fedora but is included in the source code announced as Geeqie 1.2.
Comment 2 Sami Farin 2015-06-15 09:21:31 UTC 
I did not say the hack was added by Fedora.

There seems to be old report about this bug.
http://sourceforge.net/p/geeqie/bugs/213/
Do you think they read -devel list, if they do not read bug reports?
Comment 3 Michael Schwendt 2015-06-15 10:43:54 UTC 
Well, the move from gitorious to geeqie.org has happened via activity on their mailing-list.

Other than that, the problem of not responding to tickets in the sf.net tracker is not new.
Comment 4 Michael Schwendt 2015-08-11 21:45:45 UTC 
There has just been a report of this on geeqie-devel list as "Bad optimization in renderer-tiles.c": http://sourceforge.net/p/geeqie/mailman/message/34365970/
Comment 5 Fedora Update System 2015-08-12 00:04:53 UTC 
geeqie-1.2-0.2.20150812git2b87884.fc22.1 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/geeqie-1.2-0.2.20150812git2b87884.fc22.1
Comment 6 Fedora Update System 2015-08-13 16:56:15 UTC 
Package geeqie-1.2-0.2.20150812git2b87884.fc22.1:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing geeqie-1.2-0.2.20150812git2b87884.fc22.1'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-13395/geeqie-1.2-0.2.20150812git2b87884.fc22.1
then log in and leave karma (feedback).
Comment 7 Fedora Update System 2015-08-27 03:52:26 UTC 
geeqie-1.2-0.6.20150812git2b87884.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-14376
Comment 8 Fedora Update System 2015-08-31 18:53:09 UTC 
geeqie-1.2-0.6.20150812git2b87884.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update geeqie'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-14376
Comment 9 Fedora Update System 2015-10-03 18:00:13 UTC 
geeqie-1.2-0.6.20150812git2b87884.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
Comment 10 Fedora Update System 2015-12-07 21:22:00 UTC 
geeqie-1.2-0.2.20150812git2b87884.fc22.1 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.