Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1255751 - Valgrind is available on all Fedora architectures except s/390
Summary: Valgrind is available on all Fedora architectures except s/390
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: cscppc
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kamil Dudka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ZedoraTracker ARM64, F-ExcludeArch-aarch64 F-ExcludeArch-ppc64le, PPC64LETracker
TreeView+ depends on / blocked
 
Reported: 2015-08-21 12:59 UTC by Marcin Juszkiewicz
Modified: 2015-08-21 16:43 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-21 16:43:11 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
spec change (895 bytes, text/plain)
2015-08-21 12:59 UTC, Marcin Juszkiewicz 		no flags Details
View All

Description Marcin Juszkiewicz 2015-08-21 12:59:11 UTC 
Created attachment 1065594 [details]
spec change

Description of problem:

cscppc has ifarch check for build dependency on valgrind. But it is not up-to-date as only s/390 lacks it nowadays.

Version-Release number of selected component (if applicable):

1.2.0-4
Comment 1 Kamil Dudka 2015-08-21 13:35:21 UTC 
This is intentional.  From maintaining curl I learned that valgrind on secondary arches breaks too often.  Instead of detecting bugs in curl, I was only debugging valgrind issues after update of gcc/glibc/valgrind.  See the following bugs for examples:

    bug #810992 - valgrind dies with ERROR = Iex.Binop: arg tys don't match op tys (OPENSSL_ppc64_probe)

    bug #816175 - FTBFS: build failure on PPC, valgrind error in test 582

    bug #886891 - FTBFS: lots of valgrind failures during self checks
Comment 2 Marcin Juszkiewicz 2015-08-21 14:38:21 UTC 
OK, understand your reason. But please put notes about it in spec or git log.

And specfile excludes one of primary architectures too.

Sometimes failures of one packages lead to improvements in other ;)
Comment 3 Kamil Dudka 2015-08-21 15:02:51 UTC 
(In reply to Marcin Juszkiewicz from comment #2)
> But please put notes about it in spec or git log.

Sounds like a good idea!  What about the following comment?

# The test-suite runs automatically trough valgrind if valgrind is available
# on the system.  By not installing valgrind into mock's chroot, we disable
# this feature for production builds on architectures where valgrind is known
# to be less reliable, in order to avoid unnecessary build failures (see RHBZ
# #810992, #816175, and #886891).  Nevertheless developers are free to install
# valgrind manually to improve test coverage on any architecture.
%ifarch %{ix86} x86_64
BuildRequires: valgrind
%endif


Note there is exactly the same issue in cswrap, no need to report it separately.
Comment 4 Marcin Juszkiewicz 2015-08-21 16:27:20 UTC 
Sounds fine for me.
Comment 5 Kamil Dudka 2015-08-21 16:43:11 UTC 
Fixed in dist-git:

http://pkgs.fedoraproject.org/cgit/cscppc.git/commit/?id=f32e056a
http://pkgs.fedoraproject.org/cgit/cswrap.git/commit/?id=3ca24081
Note You need to log in before you can comment on or make changes to this bug.