Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1258440 - Missing ftpasswd tool into the proftpd RPM
Summary: Missing ftpasswd tool into the proftpd RPM
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: proftpd
Version: el6
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-08-31 11:51 UTC by Olivier BONHOMME
Modified: 2015-10-01 18:57 UTC (History)
2 users (show)

Fixed In Version: proftpd-1.3.3g-6.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-10-01 18:57:03 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
ftpasswd script deployment (deleted)
2015-08-31 11:51 UTC, Olivier BONHOMME 		no flags Details
View All

Description Olivier BONHOMME 2015-08-31 11:51:15 UTC 
Created attachment 1068621 [details]
ftpasswd script deployment

Description of problem:

The very usefull tool ftpasswd available into the contrib directory from the proftpd upstream archive is not deployed into the RPM.

It should be be nice if this tool was provided with the proftpd server into the RPM.

Version-Release number of selected component (if applicable): 1.3.3g-4

You'll find as attachement a patch of the SPEC file which adds the installation of the ftpasswd script into the RPM.
Comment 1 Paul Howarth 2015-08-31 13:58:51 UTC 
How about as a separate proftpd-utils packages as per the Fedora version? That way we avoid pulling in perl as a dependency of the main package.

Here's a scratch build to try:
http://koji.fedoraproject.org/koji/taskinfo?taskID=10895317

See what you think.
Comment 2 Olivier BONHOMME 2015-08-31 16:44:15 UTC 
Hello Paul,

Thanks for your quick answer. 

I like the idea of the proftpd-utils packages in order to avoid the perl dependency. 

I tested your packages on a CentOS 6 system and it seems OK for me.

However, do you think it would be possible to embed the ftpasswd script from the last proftpd version available here : ftp://ftp.proftpd.org/distrib/source/proftpd-1.3.5a.tar.gz.

The benefit of this ftpasswd embedded on this upstream version is that it can generates sha256 and sha512 hash passwords whereas in the 1.3.3 version it is restricted to md5 and DES.

I don't know if it is possible due to the EPEL policy. Maybe including a patch which would be the diff between 1.3.3 and 1.3.5 versions for the ftpasswd script ?

Regards,
Comment 3 Paul Howarth 2015-09-06 15:25:29 UTC 
OK, sorry for the delay, here's a new scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=10980014
Comment 4 Olivier BONHOMME 2015-09-07 12:50:55 UTC 
Hello Paul,

Here are my tests results : 

- Installation of generated proftpd and proftpd-utils RPM OK
- Password generation with sha256 option OK
- Login Test with a user using the sha256 hash password OK
- Password generation with sha512 option OK
- Login Test with a user using the sha512 hash password OK

For me the feature is correctly implemented.
Comment 5 Paul Howarth 2015-09-07 13:25:27 UTC 
Thank you for testing. I will build and push this as a regular update to EPEL6 now.
Comment 6 Fedora Update System 2015-09-07 13:42:24 UTC 
proftpd-1.3.3g-5.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7979
Comment 7 Fedora Update System 2015-09-08 01:00:26 UTC 
proftpd-1.3.3g-5.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update proftpd'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7979
Comment 8 Olivier BONHOMME 2015-09-08 16:49:46 UTC 
Hello Paul,

Sorry to add this comment now since the RPM is in QA but I saw a little thing missing about ftpasswd.

I just wanted to test the --use-cracklib option with ftpasswd and the tool denied it to me because the perl lib was not available.

ftpasswd requires Crypt::Cracklib which is available in EPEL. Maybe it would be nice to add a Requires of this perl lib on the proftpd-utils package ? I hope it is not too late.

Regards,
Comment 9 Fedora Update System 2015-09-10 18:52:38 UTC 
proftpd-1.3.3g-6.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7979
Comment 10 Paul Howarth 2015-09-10 19:17:08 UTC 
The -6 build includes the dependency, which I've also added to the Fedora proftpd packages for F-23 and Rawhide. Older releases will get the update if there's something significant worth pushing an update for.
Comment 11 Fedora Update System 2015-09-12 04:59:49 UTC 
proftpd-1.3.3g-6.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update proftpd'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7979
Comment 12 Fedora Update System 2015-10-01 18:57:01 UTC 
proftpd-1.3.3g-6.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.