1278364 – Review Request: python-whitenoise - Static file serving for Python web apps

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1278364 - Review Request: python-whitenoise - Static file serving for Python web apps

Summary: Review Request: python-whitenoise - Static file serving for Python web apps

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	All
OS:	Linux
Priority:	medium
Severity:	medium
Target Milestone:	---
Assignee:	Julien Enselme
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2015-11-05 10:44 UTC by Piotr Popieluch
Modified:	2016-01-03 01:28 UTC (History)
CC List:	3 users (show)
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2015-12-28 22:57:08 UTC
Type:	---
Embargoed:
Dependent Products:
Flags:	jujens: fedora-review+

Attachments	(Terms of Use)

Description Piotr Popieluch 2015-11-05 10:44:54 UTC

Spec URL: https://piotrp.fedorapeople.org/python-whitenoise.spec
SRPM URL: https://piotrp.fedorapeople.org/python-whitenoise-2.0.4-1.fc22.src.rpm
Description: 
Radically simplified static file serving for python web apps. with a couple of
lines of config whitenoise allows your web app to serve its own static files,
making it a self-contained unit that can be deployed anywhere without relying
on nginx, amazon s3 or any other external service. (Especially useful on
Heroku, OpenShift and other PaaS providers.)
Fedora Account System Username: piotrp

Comment 1 Piotr Popieluch 2015-11-05 13:10:06 UTC

Spec URL: https://piotrp.fedorapeople.org/python-whitenoise.spec
SRPM URL: https://piotrp.fedorapeople.org/python-whitenoise-2.0.4-2.fc22.src.rpm

Comment 2 Piotr Popieluch 2015-11-10 20:23:48 UTC

Updated to support EL6 and EPEL7

Spec URL: https://piotrp.fedorapeople.org/python-whitenoise.spec
SRPM URL: https://piotrp.fedorapeople.org/python-whitenoise-2.0.4-3.fc23.src.rpm

Comment 3 Julien Enselme 2015-11-27 12:40:24 UTC

Mockbuild fails because tests cannot import django. Please add BuildRequires: python-django and BuildRequires: python3-django. Please note that tests are not executed for python2. Using nose or pytest to launch them may solve this problems.


+ /usr/bin/python3 setup.py test
running test
running egg_info
writing dependency_links to whitenoise.egg-info/dependency_links.txt
writing top-level names to whitenoise.egg-info/top_level.txt
writing whitenoise.egg-info/PKG-INFO
reading manifest file 'whitenoise.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
no previously-included directories found matching 'docs/_build'
writing manifest file 'whitenoise.egg-info/SOURCES.txt'
running build_ext
django (unittest.loader._FailedTest) ... ERROR
gzipstatic (unittest.loader._FailedTest) ... ERROR
storage_backport (unittest.loader._FailedTest) ... ERROR
gzipstatic (unittest.loader._FailedTest) ... ERROR
gzipstatic (unittest.loader._FailedTest) ... ERROR
======================================================================
ERROR: django (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: django
Traceback (most recent call last):
  File "/usr/lib64/python3.5/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
  File "/builddir/build/BUILD/python-whitenoise-2.0.4/python3/whitenoise/django.py", line 13, in <module>
    from django.conf import settings
ImportError: No module named 'django'
======================================================================
ERROR: gzipstatic (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: gzipstatic
Traceback (most recent call last):
  File "/usr/lib64/python3.5/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
  File "/builddir/build/BUILD/python-whitenoise-2.0.4/python3/whitenoise/management/commands/gzipstatic.py", line 3, in <module>
    import django
ImportError: No module named 'django'
======================================================================
ERROR: storage_backport (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: storage_backport
Traceback (most recent call last):
  File "/usr/lib64/python3.5/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
  File "/builddir/build/BUILD/python-whitenoise-2.0.4/python3/whitenoise/storage_backport.py", line 5, in <module>
    from django.contrib.staticfiles.storage import CachedStaticFilesStorage
ImportError: No module named 'django'
======================================================================
ERROR: gzipstatic (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: gzipstatic
Traceback (most recent call last):
  File "/usr/lib64/python3.5/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
  File "/builddir/build/BUILD/python-whitenoise-2.0.4/python3/whitenoise/management/commands/gzipstatic.py", line 3, in <module>
    import django
ImportError: No module named 'django'
======================================================================
ERROR: gzipstatic (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: gzipstatic
Traceback (most recent call last):
  File "/usr/lib64/python3.5/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
  File "/builddir/build/BUILD/python-whitenoise-2.0.4/python3/whitenoise/management/commands/gzipstatic.py", line 3, in <module>
    import django
ImportError: No module named 'django'
----------------------------------------------------------------------
Ran 5 tests in 0.001s

Comment 4 Upstream Release Monitoring 2015-11-27 23:21:00 UTC

piotrp's scratch build of python-whitenoise-2.0.6-1.fc23.src.rpm for epel7 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11997353

Comment 5 Upstream Release Monitoring 2015-11-27 23:27:05 UTC

piotrp's scratch build of python-whitenoise-2.0.6-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11997341

Comment 6 Piotr Popieluch 2015-11-27 23:59:49 UTC

Thank you. Actually the tests were not even included in the pypi tarbal

Changes:
- Update to new version
- Add missing BR
- Change source from pypi to github
- Use py.test
- Add doc subpackage

Spec URL: https://piotrp.fedorapeople.org/python-whitenoise.spec
SRPM URL: https://piotrp.fedorapeople.org/python-whitenoise-2.0.6-1.fc23.src.rpm

Testes mock+koji scratch for rawhide and epel7

Comment 7 Piotr Popieluch 2015-11-28 00:04:54 UTC

ftr: epel7 completed scratch build
https://koji.fedoraproject.org/koji/taskinfo?taskID=11997408

Comment 8 Julien Enselme 2015-11-29 15:46:24 UTC

- You should use the new macros %py(2|3)_build and %py(2|3)_install and build python2 and python3 version from the same folder. See: https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file Feel froo not to take into account this comment if this poses problems on el which seems to be one of your target. I don't have an experience of packages for el.
- I think you should only create on -doc package. One for both version of python seems redundant.
- See the review for other comments.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[X]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[X]: License field in the package spec file matches the actual license.
     Guidelines.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 56 files have
     unknown license. Detailed output of licensecheck in /tmp/1278364
     -python-whitenoise/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
Please install the license file with the doc packages.

[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
     names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 102400 bytes in 12 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[X]: Python eggs must not download any dependencies during the build
     process.
[X]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python
Please put the python2 package in its own subpackage. It will provide python-whitenoise thanks to the %python_provides macro.

[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
Please add fontawesome-fonts, levien-inconsolata-fonts, lato-fonts as requires and use symlink to provide these fonts. The RobotoSlab fonts are not packaged yet. If you intend to package them, please assign me for the review. Otherwise, I think they should be removed.

     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
python2-whitenoise is not provided. See remark above.

[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
     whitenoise-doc , python3-whitenoise , python3-whitenoise-doc
[?]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[X]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-whitenoise-2.0.6-1.fc24.noarch.rpm
          python-whitenoise-doc-2.0.6-1.fc24.noarch.rpm
          python3-whitenoise-2.0.6-1.fc24.noarch.rpm
          python3-whitenoise-doc-2.0.6-1.fc24.noarch.rpm
          python-whitenoise-2.0.6-1.fc24.src.rpm
python-whitenoise.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
python-whitenoise.noarch: W: spelling-error %description -l en_US nginx -> ginning, gigging
python3-whitenoise.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
python3-whitenoise.noarch: W: spelling-error %description -l en_US nginx -> ginning, gigging
python3-whitenoise.noarch: W: spelling-error %description -l en_US heroku -> Cherokee
python3-whitenoise.noarch: W: spelling-error %description -l en_US openshift -> open shift, open-shift, downshift
python3-whitenoise.noarch: W: spelling-error %description -l en_US paas -> pass, pas, paras
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/django.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/__pycache__/__init__.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/commands/__pycache__/gzipstatic.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/storage_backport.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/commands/__pycache__/__init__.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/gzip.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/__init__.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/base.cpython-35.opt-1.pyc
python-whitenoise.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
python-whitenoise.src: W: spelling-error %description -l en_US nginx -> ginning, gigging
5 packages and 0 specfiles checked; 0 errors, 17 warnings.




Rpmlint (installed packages)
----------------------------
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/base.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/__init__.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/commands/__pycache__/gzipstatic.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/django.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/storage_backport.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/commands/__pycache__/__init__.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/management/__pycache__/__init__.cpython-35.opt-1.pyc
python3-whitenoise.noarch: W: python-bytecode-without-source /usr/lib/python3.5/site-packages/whitenoise/__pycache__/gzip.cpython-35.opt-1.pyc
4 packages and 0 specfiles checked; 0 errors, 8 warnings.



Requires
--------
python-whitenoise (rpmlib, GLIBC filtered):
    python(abi)
    python-django

python3-whitenoise-doc (rpmlib, GLIBC filtered):

python3-whitenoise (rpmlib, GLIBC filtered):
    python(abi)
    python3-django

python-whitenoise-doc (rpmlib, GLIBC filtered):



Provides
--------
python-whitenoise:
    python-whitenoise
    python-whitenoise(x86-64)

python3-whitenoise-doc:
    python3-whitenoise-doc

python3-whitenoise:
    python3-whitenoise

python-whitenoise-doc:
    python-whitenoise-doc



Source checksums
----------------
https://github.com/evansd/whitenoise/archive/9fafc3843781d8934ef34e9f76dc1d10052916cf.tar.gz#/whitenoise-9fafc38.tar.gz :
  CHECKSUM(SHA256) this package     : d5e617580feb621de523c046c7ef469d26f5c0b5766683e029907b742fa81bb2
  CHECKSUM(SHA256) upstream package : d5e617580feb621de523c046c7ef469d26f5c0b5766683e029907b742fa81bb2


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1278364
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 9 Piotr Popieluch 2015-11-29 19:06:56 UTC

Thank you for review.

Unfortunately the new Python macros are not available in EL, therefore I need to use the old guidelines, as indicated in the warning on top of: https://fedoraproject.org/wiki/Packaging:Python

I am not sure about the doc, I had to create two doc packages in another review before. A quick search on available python packages show that more modules have both. 

I've modified the package to create a python2 sub-package which provides the python package.

Added the license.

new release:
Spec URL: https://piotrp.fedorapeople.org/python-whitenoise.spec
SRPM URL: https://piotrp.fedorapeople.org/python-whitenoise-2.0.6-2.fc23.src.rpm

Comment 10 Julien Enselme 2015-11-30 20:22:03 UTC

> Unfortunately the new Python macros are not available in EL, therefore I need to use the old guidelines, as indicated in the warning on top of: https://fedoraproject.org/wiki/Packaging:Python

It' fine then.

> I am not sure about the doc, I had to create two doc packages in another review before. A quick search on available python packages show that more modules have both.

I don't think there is any mention of that in the guidelines. You can leave the two doc packages.


I still find:
[!]: Avoid bundling fonts in non-fonts packages.
Please add fontawesome-fonts, levien-inconsolata-fonts, lato-fonts as requires and use symlink to provide these fonts. The RobotoSlab fonts are not packaged yet. If you intend to package them, please assign me for the review. Otherwise, I think they should be removed.

But this is a should item, so I won't block the review for that. Package approved.

Comment 11 Piotr Popieluch 2015-11-30 20:48:20 UTC

I'm sorry I've missed the font issue. I will check it next weekend.

Thank you for reviewing!

Comment 12 Gwyn Ciesla 2015-11-30 20:55:53 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-whitenoise

Comment 13 Piotr Popieluch 2015-12-16 20:57:30 UTC

I've taken a look at the fonts and there is an issue with inconsolate. I'm building with bundled fonts and opened bug #1292267 for unbundling the fonts so I can close this one.

Comment 14 Fedora Update System 2015-12-16 21:11:57 UTC

python-whitenoise-2.0.6-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-705afcd6ef

Comment 15 Fedora Update System 2015-12-16 21:12:27 UTC

python-whitenoise-2.0.6-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7b38c4dfd9

Comment 16 Fedora Update System 2015-12-17 10:27:53 UTC

python-whitenoise-2.0.6-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-whitenoise'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-705afcd6ef

Comment 17 Fedora Update System 2015-12-17 12:52:01 UTC

python-whitenoise-2.0.6-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update python-whitenoise'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-7b38c4dfd9

Comment 18 Fedora Update System 2015-12-28 22:57:05 UTC

python-whitenoise-2.0.6-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2016-01-03 01:28:10 UTC

python-whitenoise-2.0.6-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.