Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1300689 - Review Request: python-pika-pool - Pools for pikas
Summary: Review Request: python-pika-pool - Pools for pikas
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Chandan Kumar
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2016-01-21 13:15 UTC by Javier Peña
Modified: 2016-02-28 12:20 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2016-02-28 12:20:44 UTC
Type: ---
chkumar246: fedora-review+

Attachments (Terms of Use)

Description Javier Peña 2016-01-21 13:15:50 UTC
Spec URL:
Description: Pika connection pooling inspired by:


Fedora Account System Username: jpena

Koji scratch build available at

Please note the following:

- License file was not available in the GitHub repo, it is currently included as Source1. has been opened to fix this.
- python3 subpackage creation is currently disabled, since there is no python3 package for python-pika.

Comment 1 Chandan Kumar 2016-02-24 10:48:58 UTC
python3-pika is available.

Please update the spec file to python3.

Comment 2 Upstream Release Monitoring 2016-02-24 12:29:01 UTC
jpena's scratch build of python-pika-pool-0.1.3-2.fc24.src.rpm for rawhide completed

Comment 3 Javier Peña 2016-02-24 12:29:29 UTC
Thanks for the comment. I have updated the spec to enable python3 builds, and it works fine for me.


Koji scratch build available at

Comment 4 hguemar 2016-02-24 13:09:06 UTC
rechecked and package name should be python-pika_pool, we only normalize dot in upstream names, underscores should be kept

Comment 5 Javier Peña 2016-02-24 13:46:04 UTC
Oh, I didn't realize of that, the PyPi name was pika-pool so I got confused.

Updated files are:


Comment 6 Chandan Kumar 2016-02-24 14:32:37 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* BSD (3 clause)", "Unknown or generated". 4
     files have unknown license. Detailed output of licensecheck in
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.4/site-
     packages/__pycache__(python3-decorator, python3-six, python3-libs,
     python3-augeas, langtable-python3, python3-setuptools, python3-ntplib)
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[ ]: Python eggs must not download any dependencies during the build
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-pika_pool , python3-pika_pool
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.

Checking: python2-pika_pool-0.1.3-3.fc23.noarch.rpm
python2-pika_pool.noarch: W: spelling-error Summary(en_US) pikas -> pikes, pitas
python2-pika_pool.noarch: W: spelling-error %description -l en_US Pika -> Pike, Pisa, Pita
python2-pika_pool.noarch: W: spelling-error %description -l en_US pika -> pike, pita, pica
python2-pika_pool.noarch: W: spelling-error %description -l en_US sqlalchemy -> alchemy
python3-pika_pool.noarch: W: spelling-error Summary(en_US) pikas -> pikes, pitas
python3-pika_pool.noarch: W: spelling-error %description -l en_US Pika -> Pike, Pisa, Pita
python3-pika_pool.noarch: W: spelling-error %description -l en_US pika -> pike, pita, pica
python3-pika_pool.noarch: W: spelling-error %description -l en_US sqlalchemy -> alchemy
python-pika_pool.src: W: spelling-error Summary(en_US) pikas -> pikes, pitas
python-pika_pool.src: W: spelling-error %description -l en_US Pika -> Pike, Pisa, Pita
python-pika_pool.src: W: spelling-error %description -l en_US pika -> pike, pita, pica
python-pika_pool.src: W: spelling-error %description -l en_US sqlalchemy -> alchemy
3 packages and 0 specfiles checked; 0 errors, 12 warnings.

Rpmlint (installed packages)
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

python3-pika_pool (rpmlib, GLIBC filtered):

python2-pika_pool (rpmlib, GLIBC filtered):



Source checksums
---------------- :
  CHECKSUM(SHA256) this package     : f3985888cc2788cdbd293a68a8b5702a9c955db6f7b8b551aeac91e7f32da397
  CHECKSUM(SHA256) upstream package : f3985888cc2788cdbd293a68a8b5702a9c955db6f7b8b551aeac91e7f32da397

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -u
Buildroot used: fedora-23-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

The Package looks good to go. APPROVED.

Comment 7 Gwyn Ciesla 2016-02-24 17:05:19 UTC
Package request has been approved:

Comment 8 Fedora Update System 2016-02-25 09:07:57 UTC
python-pika_pool-0.1.3-3.fc23 has been submitted as an update to Fedora 23.

Comment 9 Fedora Update System 2016-02-26 20:53:55 UTC
python-pika_pool-0.1.3-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See for
instructions on how to install test updates.
You can provide feedback for this update here:

Comment 10 Neal Gompa 2016-02-27 01:16:59 UTC
@Javier, please use python2-pika as opposed to python-pika for the Python 2 dependency. It'd be good to not use unversioned python module names.

Comment 11 Fedora Update System 2016-02-28 12:20:41 UTC
python-pika_pool-0.1.3-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.