Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1308011 - rubygem-capybara_minitest_spec: FTBFS in rawhide
Summary: rubygem-capybara_minitest_spec: FTBFS in rawhide
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rubygem-capybara_minitest_spec
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jun Aruga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F24FTBFS
TreeView+ depends on / blocked
 
Reported: 2016-02-13 22:17 UTC by Fedora Release Engineering
Modified: 2016-04-15 21:35 UTC (History)
4 users (show)

Fixed In Version: rubygem-capybara_minitest_spec-1.0.5-1.fc25 rubygem-capybara_minitest_spec-1.0.5-1.fc24
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-15 21:35:33 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
build.log (27.85 KB, text/plain)
2016-02-13 22:17 UTC, Fedora Release Engineering
no flags Details
root.log (85.32 KB, text/plain)
2016-02-13 22:17 UTC, Fedora Release Engineering
no flags Details
state.log (713 bytes, text/plain)
2016-02-13 22:17 UTC, Fedora Release Engineering
no flags Details
Update to 1.0.5 to fix test suite for Ruby 2.3 compatibility (6.42 KB, patch)
2016-04-07 14:59 UTC, Jun Aruga
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1159539 0 unspecified CLOSED rubygem-capybara_minitest_spec-1.0.5 is available 2022-05-16 11:32:56 UTC

Internal Links: 1159539

Description Fedora Release Engineering 2016-02-13 22:17:50 UTC
Your package rubygem-capybara_minitest_spec failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12865759

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild

Comment 1 Fedora Release Engineering 2016-02-13 22:17:52 UTC
Created attachment 1126093 [details]
build.log

Comment 2 Fedora Release Engineering 2016-02-13 22:17:53 UTC
Created attachment 1126094 [details]
root.log

Comment 3 Fedora Release Engineering 2016-02-13 22:17:54 UTC
Created attachment 1126095 [details]
state.log

Comment 4 Jan Kurik 2016-02-24 15:07:00 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 5 Jun Aruga 2016-04-07 14:17:01 UTC
I will fix this!

Comment 6 Jun Aruga 2016-04-07 14:59:43 UTC
Created attachment 1144773 [details]
Update to 1.0.5 to fix test suite for Ruby 2.3 compatibility

I fixed the test suite issue.
Its test suite issue is happened with dependency package: minitest (>= 5.6.0).

So, I updated capybara_minitest_spec to latest version: 1.0.5 at first.
And created one patch file for the modification that is on master branch in upstream, but not affected to latest version.

f24 test suite had been failed because of minitest: v5.8.4
f23 test suite had been succeeded because of minitest: v5.4.3

files doc section
gemfiles is added at capybara_minitest_spec v1.0.5
HISTORY.md is deleted at capybara_minitest_spec v1.0.5

I also checked the spec file by rpmlint.

Could you my attachment file?
Thanks.

Comment 7 Jun Aruga 2016-04-07 15:41:58 UTC
Sorry additional information.
I suggested to update this package's version.
and the dependency is also ok. We do not need to consider other packages to update this package's version.

+ dnf repoquery --enablerepo=rawhide --whatrequires 'rubygem(capybara_minitest_spec)'
  => no result

+ dnf repoquery --enablerepo=rawhide --whatrequires 'rubygem-capybara_minitest_spec'
rubygem-capybara_minitest_spec-doc-0:1.0.3-2.fc23.noarch

+ dnf repoquery --enablerepo=rawhide-source --arch src --whatrequires 'rubygem(capybara_minitest_spec)'
  => no result

+ dnf repoquery --enablerepo=rawhide-source --arch src --whatrequires 'rubygem-capybara_minitest_spec'
  => no result

Comment 8 Pavel Valena 2016-04-11 00:43:13 UTC
The update and patch look good.

Just one thing: in the -doc subpackage, there is an empty 'gemfiles/' directory. I would rather exclude it, by

```
%exclude %{gem_instdir}/gemfiles
```

The directory is empty, because, the file 'gemfiles/Gemfile_minitest_4' is deleted by the patch fixing the test suite.

Comment 9 Jun Aruga 2016-04-11 07:57:23 UTC
Hi, Pavel
Thanks for the review.

Is the directory empty? I could see 'gemfiles/Gemfile_minitest_4' in my environment.
Could you tell me the detail you check it?

$ rpm2cpio rubygem-capybara_minitest_spec-doc-1.0.5-1.fc25.noarch.rpm | cpio -idmv
$ ls usr/share/gems/gems/capybara_minitest_spec-1.0.5/gemfiles/
Gemfile_minitest_4

Comment 10 Upstream Release Monitoring 2016-04-11 11:41:42 UTC
jaruga's rubygem-capybara_minitest_spec-1.0.5-1.fc25 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=753363

Comment 11 Fedora Update System 2016-04-11 12:21:15 UTC
rubygem-capybara_minitest_spec-1.0.5-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-70cff4cb98

Comment 12 Jun Aruga 2016-04-12 08:24:28 UTC
As a note, after discussing with him, below thing was his misunderstanding. as the patch was run in only check section.

So, we agreed regarding keeping below "gemfiles" line.

(In reply to Pavel Valena from comment #8)
> The update and patch look good.
> 
> Just one thing: in the -doc subpackage, there is an empty 'gemfiles/'
> directory. I would rather exclude it, by
> 
> ```
> %exclude %{gem_instdir}/gemfiles
> ```
> 
> The directory is empty, because, the file 'gemfiles/Gemfile_minitest_4' is
> deleted by the patch fixing the test suite.

Comment 13 Fedora Update System 2016-04-12 10:53:56 UTC
rubygem-capybara_minitest_spec-1.0.5-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-70cff4cb98

Comment 14 Jun Aruga 2016-04-13 07:05:33 UTC
As a note, I changed my comment in rubygem-capybara_minitest_spec.spec, from my uploaded patch, to simplify the comment.

Before
# To fix a test with minitest >= 5.6.0
# git clone https://github.com/ordinaryzelig/capybara_minitest_spec.git
# cd capybara_minitest_spec
# git format-patch -1 5e757d6c8b4e9f8d138118becdfee013acebdaa5 --stdout \
#   > rubygem-capybara_minitest_spec-1.0.5-fix-test-with-minitest-5.6-more.patch

=>

After
# https://github.com/ordinaryzelig/capybara_minitest_spec/commit/5e757d6c8b4e9f8d138118becdfee013acebdaa5.patch

Comment 15 Fedora Update System 2016-04-15 21:35:28 UTC
rubygem-capybara_minitest_spec-1.0.5-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.