Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1313841 - nasm 2.12 build failure on PowerPC
Summary: nasm 2.12 build failure on PowerPC
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: nasm
Version: rawhide
Hardware: powerpc
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Mikolaj Izdebski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F-ExcludeArch-ppc64le, PPC64LETracker
TreeView+ depends on / blocked
 
Reported: 2016-03-02 12:35 UTC by Michel Normand
Modified: 2016-03-03 20:26 UTC (History)
6 users (show)

Fixed In Version: nasm-2.12-2.fc24
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-03 07:39:36 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
nasm_change_unused.patch (1.33 KB, patch)
2016-03-02 12:37 UTC, Michel Normand 		no flags Details | Diff
View All

Description Michel Normand 2016-03-02 12:35:50 UTC 
Description of problem: nasm 2.12 build failure on PowerPC

as reported by koji
http://ppc.koji.fedoraproject.org/kojifiles/work/tasks/7405/3187405/build.log
===
gcc -c -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -W -Wall -std=c99 -pedantic -Werror=implicit -Werror=missing-braces -Werror=return-type -Werror=trigraphs -Werror=pointer-arith -Werror=missing-prototypes -Werror=missing-declarations -Werror=comment -Werror=vla -DHAVE_CONFIG_H -I. -I. -o realpath.o realpath.c
In file included from /usr/include/bits/sigcontext.h:27:0,
                 from /usr/include/signal.h:306,
                 from /usr/include/sys/param.h:28,
                 from realpath.c:47:
/usr/include/asm/sigcontext.h:17:23: error: expected identifier or '(' before '[' token
  unsigned long _unused[4];
===
Comment 1 Michel Normand 2016-03-02 12:37:40 UTC 
Created attachment 1132295 [details]
nasm_change_unused.patch

The attached patch is suggested correction
Comment 2 Michel Normand 2016-03-02 13:27:37 UTC 
related scratch build passed without error.
http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=3189786
Comment 3 Mikolaj Izdebski 2016-03-03 07:23:09 UTC 
Forwarded upstream: http://bugzilla.nasm.us/show_bug.cgi?id=3392339
Comment 4 Mikolaj Izdebski 2016-03-03 07:39:36 UTC 
Fixed in nasm-2.12-2.fc24
http://ppc.koji.fedoraproject.org/koji/buildinfo?buildID=386004
Comment 5 H. Peter Anvin 2016-03-03 20:26:26 UTC 
There is more to it than that.  The symbol "_unused" is in application namespace, and this code leaks it.  It should be changed to __unused or something else that isn't in application namespace.
Note You need to log in before you can comment on or make changes to this bug.