Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1315022 - Review Request: xfpanel-switch - A simple application to manage Xfce panel layouts
Summary: Review Request: xfpanel-switch - A simple application to manage Xfce panel la...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: gil cattaneo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-05 20:32 UTC by Mukundan Ragavan
Modified: 2016-03-20 20:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-20 20:24:11 UTC
Type: ---
Embargoed:
puntogil: fedora-review+

Attachments (Terms of Use)
appdata file (deleted)
2016-03-06 12:56 UTC, Mukundan Ragavan 		no flags Details
Italian translation (deleted)
2016-03-06 13:44 UTC, gil cattaneo 		no flags Details
View All

Description Mukundan Ragavan 2016-03-05 20:32:04 UTC 
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/xfpanel-switch/xfpanel-switch.spec
SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/xfpanel-switch/xfpanel-switch-1.0.3-1.fc23.src.rpm

Description:

A simple application to manage Xfce panel layouts

With the modular Xfce Panel, a multitude of panel layouts can be created. This tool makes it possible to backup, restore, import, and export these panel layouts.

Fedora Account System Username: nonamedotc
Comment 1 Upstream Release Monitoring 2016-03-05 20:34:02 UTC 
nonamedotc's scratch build of xfpanel-switch-1.0.3-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13242791
Comment 2 gil cattaneo 2016-03-06 07:23:56 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package contains BR: python2-devel or python3-devel
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL", "GPL (v3 or later)", "Unknown or generated". 6 files
     have unknown license. Detailed output of licensecheck in
     /home/gil/1315022-xfpanel-switch/licensecheck.txt
[?]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/xfpanel-switch
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/xfpanel-switch, /usr/share/xfpanel-switch/xfpanel-switch
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: xfpanel-switch-1.0.3-1.fc25.noarch.rpm
          xfpanel-switch-1.0.3-1.fc25.src.rpm
xfpanel-switch.noarch: E: description-line-too-long C With the modular Xfce Panel, a multitude of panel layouts can be created. This tool makes it possible to backup,
xfpanel-switch.noarch: W: no-version-in-last-changelog
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/GNOME 2.tar.bz2
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/Redmond.tar.bz2
xfpanel-switch.noarch: E: script-without-shebang /usr/share/xfpanel-switch/xfpanel-switch/xfpanel-switch.glade
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/Xfce 4.12.tar.bz2
xfpanel-switch.noarch: W: dangling-symlink /usr/share/xfpanel-switch/locale /usr/share/locale
xfpanel-switch.noarch: W: no-manual-page-for-binary xfpanel-switch
xfpanel-switch.noarch: W: install-file-in-docs /usr/share/doc/xfpanel-switch/INSTALL
xfpanel-switch.src: E: description-line-too-long C With the modular Xfce Panel, a multitude of panel layouts can be created. This tool makes it possible to backup,
xfpanel-switch.src: W: no-version-in-last-changelog
xfpanel-switch.src:33: W: configure-without-libdir-spec
2 packages and 0 specfiles checked; 3 errors, 9 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
xfpanel-switch.noarch: E: description-line-too-long C With the modular Xfce Panel, a multitude of panel layouts can be created. This tool makes it possible to backup,
xfpanel-switch.noarch: W: no-version-in-last-changelog
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/Redmond.tar.bz2
xfpanel-switch.noarch: E: script-without-shebang /usr/share/xfpanel-switch/xfpanel-switch/xfpanel-switch.glade
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/GNOME 2.tar.bz2
xfpanel-switch.noarch: W: dangling-symlink /usr/share/xfpanel-switch/locale /usr/share/locale
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/Xfce 4.12.tar.bz2
xfpanel-switch.noarch: W: no-manual-page-for-binary xfpanel-switch
xfpanel-switch.noarch: W: install-file-in-docs /usr/share/doc/xfpanel-switch/INSTALL
1 packages and 0 specfiles checked; 2 errors, 7 warnings.



Requires
--------
xfpanel-switch (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/env
    xfce4-panel



Provides
--------
xfpanel-switch:
    application()
    application(xfpanel-switch.desktop)
    xfpanel-switch



Source checksums
----------------
https://launchpad.net/xfpanel-switch/1.0/1.0.3/+download/xfpanel-switch-1.0.3.tar.bz2 :
  CHECKSUM(SHA256) this package     : 40c6bea0415554b0bec00a861c47587c7a80efc4cf8b87ab528d16291e793fce
  CHECKSUM(SHA256) upstream package : 40c6bea0415554b0bec00a861c47587c7a80efc4cf8b87ab528d16291e793fce


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1315022 -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Comment 3 gil cattaneo 2016-03-06 07:38:59 UTC 
Issues:
=======
- Package contains BR: python2-devel or python3-devel
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.

Please, use desktop-file-validate
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
and see
https://fedoraproject.org/wiki/Packaging:Scriptlets#desktop-database

[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/xfpanel-switch, /usr/share/xfpanel-switch/xfpanel-switch

xfpanel-switch.noarch: E: description-line-too-long C With the modular Xfce Panel, a multitude of panel layouts can be created. This tool makes it possible to backup,

xfpanel-switch.noarch: W: no-version-in-last-changelog

xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/Redmond.tar.bz2
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/GNOME 2.tar.bz2
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/Xfce 4.12.tar.bz2

xfpanel-switch.noarch: W: install-file-in-docs /usr/share/doc/xfpanel-switch/INSTALL

Maybe you could remove:
mkdir -p %{buildroot}%{_datadir}/licenses/%{name}
cp -p COPYING %{buildroot}%{_datadir}/licenses/%{name}/
and use (for EPEL only, see https://fedorahosted.org/fpc/ticket/586)
%{!?_licensedir:%global license %%doc}
%license COPYING
Missing appadata file. Please, can you add one?
https://fedoraproject.org/wiki/Packaging:Guidelines#AppData_files
Comment 4 gil cattaneo 2016-03-06 07:40:33 UTC 
xfpanel-switch.noarch: W: install-file-in-docs /usr/share/doc/xfpanel-switch/INSTALL
please, remove
Comment 5 Mukundan Ragavan 2016-03-06 12:52:59 UTC 
(In reply to gil cattaneo from comment #3)
> Issues:
> =======
> - Package contains BR: python2-devel or python3-devel

Done.

> - Package installs a %{name}.desktop using desktop-file-install or desktop-
>   file-validate if there is such a file.
> 
> Please, use desktop-file-validate
> https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-
> install_usage
> and see
> https://fedoraproject.org/wiki/Packaging:Scriptlets#desktop-database
> 

Done.

> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/xfpanel-switch,
> /usr/share/xfpanel-switch/xfpanel-switch
> 
> xfpanel-switch.noarch: E: description-line-too-long C With the modular Xfce
> Panel, a multitude of panel layouts can be created. This tool makes it
> possible to backup,
>

Fixed.
 
> xfpanel-switch.noarch: W: no-version-in-last-changelog
> 

Fixed.

> xfpanel-switch.noarch: W: spurious-executable-perm
> /usr/share/xfpanel-switch/layouts/Redmond.tar.bz2
> xfpanel-switch.noarch: W: spurious-executable-perm
> /usr/share/xfpanel-switch/layouts/GNOME 2.tar.bz2
> xfpanel-switch.noarch: W: spurious-executable-perm
> /usr/share/xfpanel-switch/layouts/Xfce 4.12.tar.bz2
> 
> xfpanel-switch.noarch: W: install-file-in-docs
> /usr/share/doc/xfpanel-switch/INSTALL
>

Removed.

> Missing appadata file. Please, can you add one?
> https://fedoraproject.org/wiki/Packaging:Guidelines#AppData_files

Added a simple appdata file now. Will file a bug report upstream to have it included in the tarball.

(In reply to gil cattaneo from comment #4)
> xfpanel-switch.noarch: W: install-file-in-docs
> /usr/share/doc/xfpanel-switch/INSTALL
> please, remove

Done.
Comment 6 Mukundan Ragavan 2016-03-06 12:54:52 UTC 
As for this - 

> Maybe you could remove:
> mkdir -p %{buildroot}%{_datadir}/licenses/%{name}
> cp -p COPYING %{buildroot}%{_datadir}/licenses/%{name}/
> and use (for EPEL only, see https://fedorahosted.org/fpc/ticket/586)
> %{!?_licensedir:%global license %%doc}
> %license COPYING


I cannot get this to work at all. rpm building fails with

error: Installed (but unpackaged) file(s) found:
   /usr/share/doc/xfpanel-switch/COPYING
    Installed (but unpackaged) file(s) found:
   /usr/share/doc/xfpanel-switch/COPYING


So, I have done this now - 

%{__install} -Dp -m644 COPYING %{buildroot}%{_datadir}/licenses/%{name}/COPYING
Comment 7 Mukundan Ragavan 2016-03-06 12:56:30 UTC 
Created attachment 1133481 [details]
appdata file

$ appstream-util validate-relax xfpanel-switch.appdata.xml 
xfpanel-switch.appdata.xml: OK
Comment 8 Mukundan Ragavan 2016-03-06 12:58:42 UTC 
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/xfpanel-switch/xfpanel-switch.spec
SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/xfpanel-switch/xfpanel-switch-1.0.3-2.fc23.src.rpm
Comment 9 gil cattaneo 2016-03-06 13:44:47 UTC 
Created attachment 1133486 [details]
Italian translation

attached it.po file, add to the source directory (xfpanel-switch-1.0.3/po) if desired
Comment 10 gil cattaneo 2016-03-06 13:45:07 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL", "GPL (v3 or later)", "Unknown or generated". 6 files
     have unknown license. Detailed output of licensecheck in
     /home/gil/1315022-xfpanel-switch/licensecheck.txt
[?]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/xfpanel-switch
[?]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/xfpanel-switch
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: xfpanel-switch-1.0.3-2.fc25.noarch.rpm
          xfpanel-switch-1.0.3-2.fc25.src.rpm
xfpanel-switch.noarch: E: description-line-too-long C tool makes it possible to backup, restore, import, and export these panel layouts.
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/GNOME 2.tar.bz2
xfpanel-switch.noarch: W: dangling-symlink /usr/share/xfpanel-switch/locale /usr/share/locale
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/Redmond.tar.bz2
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/Xfce 4.12.tar.bz2
xfpanel-switch.noarch: E: script-without-shebang /usr/share/xfpanel-switch/xfpanel-switch/xfpanel-switch.glade
xfpanel-switch.noarch: W: no-manual-page-for-binary xfpanel-switch
xfpanel-switch.src: E: description-line-too-long C tool makes it possible to backup, restore, import, and export these panel layouts.
xfpanel-switch.src:38: W: configure-without-libdir-spec
2 packages and 0 specfiles checked; 3 errors, 6 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
xfpanel-switch.noarch: E: description-line-too-long C tool makes it possible to backup, restore, import, and export these panel layouts.
xfpanel-switch.noarch: E: script-without-shebang /usr/share/xfpanel-switch/xfpanel-switch/xfpanel-switch.glade
xfpanel-switch.noarch: W: dangling-symlink /usr/share/xfpanel-switch/locale /usr/share/locale
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/GNOME 2.tar.bz2
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/Xfce 4.12.tar.bz2
xfpanel-switch.noarch: W: spurious-executable-perm /usr/share/xfpanel-switch/layouts/Redmond.tar.bz2
xfpanel-switch.noarch: W: no-manual-page-for-binary xfpanel-switch
1 packages and 0 specfiles checked; 2 errors, 5 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /home/gil/1315022-xfpanel-switch/srpm/xfpanel-switch.spec	2016-03-06 14:08:18.365465493 +0100
+++ /home/gil/1315022-xfpanel-switch/srpm-unpacked/xfpanel-switch.spec	2016-03-06 13:42:26.000000000 +0100
@@ -23,7 +23,6 @@
 A simple application to manage Xfce panel layouts
 
-With the modular Xfce Panel, a multitude of panel layouts can be created. 
-This tool makes it possible to backup, restore, import, and export these 
-panel layouts.
+With the modular Xfce Panel, a multitude of panel layouts can be created. This 
+tool makes it possible to backup, restore, import, and export these panel layouts.
 
 %prep


Requires
--------
xfpanel-switch (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/env
    xfce4-panel



Provides
--------
xfpanel-switch:
    appdata()
    appdata(xfpanel-switch.appdata.xml)
    application()
    application(xfpanel-switch.desktop)
    xfpanel-switch



Source checksums
----------------
https://launchpad.net/xfpanel-switch/1.0/1.0.3/+download/xfpanel-switch-1.0.3.tar.bz2 :
  CHECKSUM(SHA256) this package     : 40c6bea0415554b0bec00a861c47587c7a80efc4cf8b87ab528d16291e793fce
  CHECKSUM(SHA256) upstream package : 40c6bea0415554b0bec00a861c47587c7a80efc4cf8b87ab528d16291e793fce


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1315022 -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Comment 11 gil cattaneo 2016-03-06 13:46:32 UTC 
ISSUES:
xfpanel-switch.src: E: description-line-too-long C tool makes it possible to backup, restore, import, and export these panel layouts.
Please, fix before import
Approved
Comment 12 gil cattaneo 2016-03-06 13:51:57 UTC 
can you take this https://bugzilla.redhat.com/show_bug.cgi?id=1208381 for me?
Comment 13 Mukundan Ragavan 2016-03-06 14:31:01 UTC 
(In reply to gil cattaneo from comment #12)
> can you take this https://bugzilla.redhat.com/show_bug.cgi?id=1208381 for me?

Thanks for the review. Taken.
Comment 14 Raphael Groner 2016-03-06 16:24:30 UTC 
(In reply to Mukundan Ragavan from comment #7)
> Created attachment 1133481 [details]
> appdata file
> 
> $ appstream-util validate-relax xfpanel-switch.appdata.xml 
> xfpanel-switch.appdata.xml: OK

(In reply to gil cattaneo from comment #9)
> Created attachment 1133486 [details]
> Italian translation
> 
> attached it.po file, add to the source directory (xfpanel-switch-1.0.3/po)
> if desired

Please send those both additions as patches to upstream.
Comment 15 Gwyn Ciesla 2016-03-07 13:59:24 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/xfpanel-switch
Comment 16 Fedora Update System 2016-03-08 00:34:23 UTC 
xfpanel-switch-1.0.3-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-858811aa83
Comment 17 Fedora Update System 2016-03-09 22:56:48 UTC 
xfpanel-switch-1.0.3-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-858811aa83
Comment 18 Fedora Update System 2016-03-17 20:52:00 UTC 
xfpanel-switch-1.0.3-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.