Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1330300 - Early anaconda errors no longer displayed in tmux 2.2
Summary: Early anaconda errors no longer displayed in tmux 2.2
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ZedoraTracker
TreeView+ depends on / blocked
 
Reported: 2016-04-25 19:58 UTC by Adam Williamson
Modified: 2016-05-17 15:12 UTC (History)
14 users (show)

Fixed In Version: anaconda-24.13.5-1 anaconda-24.13.5-1.fc24
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-17 15:12:27 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Adam Williamson 2016-04-25 19:58:17 UTC 
The anaconda environment uses tmux. Here is an early anaconda crash before tmux 2.2 landed:

https://openqa.fedoraproject.org/tests/13043/modules/_boot_to_anaconda/steps/8

here is the same crash after 2.2 landed:

https://openqa.fedoraproject.org/tests/14367/modules/_boot_to_anaconda/steps/7

It seems that with tmux 2.2, any time anaconda crashes early, instead of the error showing up on the console somehow, we just see a generic tmux error. This makes debugging errors harder - especially openQA ones as we have to reproduce the test manually and poke around in the environment to find the error.
Comment 1 Sven Lankes 2016-04-26 06:55:23 UTC 
Where can I find /usr/share/anaconda/tmux.conf without digging too deep into anaconda internals?
Comment 2 Adam Williamson 2016-04-26 07:14:33 UTC 
I think it's:

https://github.com/rhinstaller/anaconda/blob/master/data/tmux.conf
Comment 3 David Shea 2016-04-26 20:21:15 UTC 
For some further background on how anaconda uses tmux:

boot.iso is created with anaconda.target as the default target, which runs anaconda.service, which is Type=forking and executes "tmux -u -f /usr/share/anaconda/tmux.conf start", and the tmux.conf has the detach-client command at the end.

anaconda-tmux is activated once tty1 is setup. That one is Type=idle and runs "/usr/bin/tmux -u attach -t anaconda".

The idea had been to start the tmux server and session in the console-less anaconda.service and then attach to it in the console service, but now it leaves us with a busted window saying "/usr/share/anaconda/tmux.conf:20: no current client", where line 20 is the detach-client. Commenting out the detach-client seems to make things work.
Comment 4 Adam Williamson 2016-04-26 20:44:31 UTC 
or rather, as wwoods noted on IRC, it makes the broken cases we happen to have run across so far work again, but there are lots of exciting known unknowns: are there are other broken cases? If so, does that fix them all? Are there other cases which are broken by removing the detach-client? Apparently there's a ton of potential corner cases here with serial line installs and weird s390 stuff and all the rest of it, and that line was presumably put in there for a reason.
Comment 5 Sven Lankes 2016-04-27 15:09:11 UTC 
(In reply to David Shea from comment #3)

> anaconda-tmux is activated once tty1 is setup. That one is
> Type=idle and runs "/usr/bin/tmux -u attach -t anaconda".

So this last line is supposed to attach to the existing session and then actually start anaconda? Or is it supposed to attach to the existing session named 'anaconda'? If so - where is anaconda actually started then?
Comment 6 David Shea 2016-04-27 15:15:23 UTC 
In tmux.conf, there is a line:

> new-session -s anaconda -n main "anaconda"

that starts the session named "anaconda", with a window named "main", and in that window it runs the program "anaconda". After that it creates some more windows with a shell and some logs and stuff.

The attach directive in anaconda-tmux@<console>.service attaches to this session named "anaconda" that is already running.
Comment 7 Jan Stodola 2016-05-09 13:50:08 UTC 
tmux-2.2-1.fc24 has been pushed to the Fedora 24 stable repository.

David, how is this going to be fixed in F24?

I can see the following anaconda commit for the master branch, but I guess we will need it for f24-branch too
https://github.com/rhinstaller/anaconda/pull/608

This is currently blocking installation on s390x, since user cannot select between vnc/text mode installation.
Comment 8 David Shea 2016-05-09 14:15:05 UTC 
Cherry-picked to f24-branch
Comment 9 Fedora Update System 2016-05-13 18:32:21 UTC 
python-blivet-1.20.2-1.fc24 anaconda-24.13.5-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1a7f1df025
Comment 10 Fedora Update System 2016-05-15 06:56:38 UTC 
anaconda-24.13.5-1.fc24, python-blivet-1.20.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1a7f1df025
Comment 11 Fedora Update System 2016-05-17 15:12:09 UTC 
anaconda-24.13.5-1.fc24, python-blivet-1.20.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.