Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1335654 - Review Request: shim-unsigned-aarch64 - UEFI shim for aarch64
Summary: Review Request: shim-unsigned-aarch64 - UEFI shim for aarch64
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Peter Robinson
URL:
Whiteboard:
Depends On:
Blocks: 1319083
TreeView+ depends on / blocked
 
Reported: 2016-05-12 19:13 UTC by Peter Jones
Modified: 2016-05-18 10:03 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-05-18 10:03:49 UTC
Type: ---
Embargoed:
pbrobinson: fedora-review+


Attachments (Terms of Use)

Description Peter Jones 2016-05-12 19:13:17 UTC
Spec URL: http://pjones.fedorapeople.org/shim-aarch64/shim-aarch64.spec
SRPM URL: http://pjones.fedorapeople.org/shim-aarch64/shim-aarch64-0.9-1.fc24.src.rpm
Description: The shim package for aarch64
Fedora Account System Username: pjones

Comment 1 Peter Jones 2016-05-12 19:14:49 UTC
This is actually the same package as "shim", but we've discovered that having the same package making shim-unsigned for each architecture intertwines them much more than seems to actually work.  So we're splitting it out to one per target architecture.

This is the one for Aarch64.

Comment 2 Peter Jones 2016-05-16 15:59:46 UTC
And the review.txt is here: http://pjones.fedorapeople.org/shim-aarch64/review.txt

As always, it is filled with misleading results.

Comment 3 Peter Robinson 2016-05-16 16:37:43 UTC
So mostly fine. Just a couple of queries around package naming, should probably be called shim-unsigned-aarch64 with provides/obsoletes for shim-unsigned to avoid conflicts and smooth upgrade, but other than that all OK.

shim-aarch64-0.9-1.fc25.src.rpm
shim-unsigned-0.9-1.fc25.aarch64.rpm



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "BSD (2 clause)", "*No copyright* BSD",
     "Unknown or generated". 396 files have unknown license. Detailed
     output of licensecheck in /home/pjones/shim-aarch64/1335654-shim-
     aarch64/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in shim-
     unsigned , shim-unsigned-aa64-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[-]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 1863680 bytes in /usr/share
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: shim-unsigned-0.9-1.fc25.aarch64.rpm
          shim-unsigned-aa64-debuginfo-0.9-1.fc25.noarch.rpm
          shim-aarch64-0.9-1.fc25.src.rpm
shim-unsigned.aarch64: W: no-documentation
shim-unsigned-aa64-debuginfo.noarch: E: zero-length /usr/src/debug/shim-0.9/Cryptlib/Base.h
shim-unsigned-aa64-debuginfo.noarch: E: zero-length /usr/src/debug/shim-0.9/Cryptlib/Library/BaseMemoryLib.h
shim-unsigned-aa64-debuginfo.noarch: E: zero-length /usr/src/debug/shim-0.9/Cryptlib/Library/MemoryAllocationLib.h
shim-unsigned-aa64-debuginfo.noarch: E: version-control-internal-file /usr/src/debug/shim-0.9/.gitignore
shim-unsigned-aa64-debuginfo.noarch: E: script-without-shebang /usr/src/debug/shim-0.9/Cryptlib/OpenSSL/update.sh
shim-unsigned-aa64-debuginfo.noarch: E: zero-length /usr/src/debug/shim-0.9/Cryptlib/Library/DebugLib.h
shim-aarch64.src: W: strange-permission shim-find-debuginfo.sh 775
shim-aarch64.src:80: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 80)
shim-aarch64.src: W: patch-not-applied Patch1: 0001-Typo-on-aarch64.patch
shim-aarch64.src: W: invalid-url Source0: https://github.com/rhinstaller/shim/releases/download/0.9/shim-0.9.tar.bz2 HTTP Error 403: Forbidden
3 packages and 0 specfiles checked; 6 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
shim-unsigned-aa64-debuginfo.noarch: E: zero-length /usr/src/debug/shim-0.9/Cryptlib/Library/MemoryAllocationLib.h
shim-unsigned-aa64-debuginfo.noarch: E: zero-length /usr/src/debug/shim-0.9/Cryptlib/Base.h
shim-unsigned-aa64-debuginfo.noarch: E: zero-length /usr/src/debug/shim-0.9/Cryptlib/Library/DebugLib.h
shim-unsigned-aa64-debuginfo.noarch: E: zero-length /usr/src/debug/shim-0.9/Cryptlib/Library/BaseMemoryLib.h
shim-unsigned-aa64-debuginfo.noarch: E: script-without-shebang /usr/src/debug/shim-0.9/Cryptlib/OpenSSL/update.sh
shim-unsigned-aa64-debuginfo.noarch: E: version-control-internal-file /usr/src/debug/shim-0.9/.gitignore
shim-unsigned.aarch64: W: spelling-error Summary(en_US) bootloader -> boot loader, boot-loader, boatload
shim-unsigned.aarch64: W: spelling-error %description -l en_US bootloader -> boot loader, boot-loader, boatload
shim-unsigned.aarch64: W: no-documentation
2 packages and 0 specfiles checked; 6 errors, 3 warnings.



Requires
--------
shim-unsigned-aa64-debuginfo (rpmlib, GLIBC filtered):

shim-unsigned (rpmlib, GLIBC filtered):



Provides
--------
shim-unsigned-aa64-debuginfo:
    shim-debuginfo
    shim-unsigned-aa64-debuginfo

shim-unsigned:
    shim-unsigned
    shim-unsigned(aarch-64)



Source checksums
----------------
https://github.com/rhinstaller/shim/releases/download/0.9/shim-0.9.tar.bz2 :
  CHECKSUM(SHA256) this package     : f524af773af0c8bfce132c9cf1d43c501b479abf2d12fe26d9f419a3d9688ab5
  CHECKSUM(SHA256) upstream package : f524af773af0c8bfce132c9cf1d43c501b479abf2d12fe26d9f419a3d9688ab5


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1335654
Buildroot used: fedora-rawhide-aarch64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Peter Robinson 2016-05-16 16:38:40 UTC
Other than the naming query APPROVED

Comment 5 Peter Jones 2016-05-16 17:18:09 UTC
Sure, I'll go with shim-unsigned-aarch64.

Comment 6 Patrick Uiterwijk 2016-05-17 08:51:31 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/shim-unsigned-aarch64


Note You need to log in before you can comment on or make changes to this bug.