Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1351308 - [gtk3] Site Manager stretches beyond available vertical space if there are many site entries
Summary: [gtk3] Site Manager stretches beyond available vertical space if there are ma...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: filezilla
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nicolas Chauvet (kwizart)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-29 17:00 UTC by Noah
Modified: 2016-07-19 22:23 UTC (History)
2 users (show)

Fixed In Version: filezilla-3.17.0.1-2.fc24 filezilla-3.14.1-3.fc23
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-12 15:01:26 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
sitemanager.xml with many site entries, for reproduction purposes (41.69 KB, application/xml)
2016-06-29 17:00 UTC, Noah
no flags Details
screen capture illustrating the problem (134.23 KB, image/png)
2016-06-29 17:01 UTC, Noah
no flags Details

Description Noah 2016-06-29 17:00:52 UTC
Created attachment 1174052 [details]
sitemanager.xml with many site entries, for reproduction purposes

Description of problem:
If there are many site entries in Site Manager (probably just enough to result in a vertical scrollbar being added to the entries pane) (additional reproduction requirements listed below), the Site Manager window will stretch vertically beyond the available space. This issue started with the gtk3 builds of Filezilla in Fedora 22 and continue through the current release of Fedora (does not affect gtk2 builds in Fedora 21 and earlier).

Version-Release number of selected component (if applicable):
3.17.0.1

How reproducible:
100%

Steps to Reproduce:
0. ensure FileZilla is closed
1. delete contents of ~/.config/filezilla (this ensures you're starting with default settings)
2. copy attached sitemanager.xml to ~/.config/filezilla (this ensures there are enough site entries to reproduce the bug)
3. open FileZilla, maximize the FileZilla window (required for reproduction), and then close FileZilla (reproduction will not occur until next open)
4. open FileZilla
5. open Site Manager

Actual results:
Site Manager window stretches too far vertically (even after repositioning, if necessary), cutting off about half of the row of buttons at the bottom of the screen (see screen capture which I will attach) (note: this happens even if the Mate Desktop panels are hidden), and also making it impossible to resize the window vertically.

Expected results:
The Site Manager window should not stretch beyond available space.

Comment 1 Noah 2016-06-29 17:01:29 UTC
Created attachment 1174053 [details]
screen capture illustrating the problem

Comment 2 Gwyn Ciesla 2016-06-29 17:33:56 UTC
I've tried to log an issue on this:

https://trac.filezilla-project.org/

But it won't send the email to confirm, so I can't log an issue.  It also won't let me register for the forum.  Reached out via email.

Comment 4 Noah 2016-06-30 11:30:10 UTC
(from link above) botg: "I think this can be solved by updating your version of wxWidgets.
Instead of the latest stable release, please try the latest revision from the WX_3_0_BRANCH from its repository."

I went through the song and dance of compiling a later version of wxWidgets, but FileZilla only recognized the original version installed from the Fedora repos. Any ideas about how I might address this other than also custom compiling FileZilla?

Comment 5 Gwyn Ciesla 2016-06-30 18:52:22 UTC
The cleanest way would be to build an wxGTK3 RPM from 3.1.0 and test that.  I may try that shortly.

Comment 6 Fedora Update System 2016-07-08 15:00:59 UTC
filezilla-3.17.0.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e6d61287bf

Comment 7 Fedora Update System 2016-07-08 15:01:05 UTC
filezilla-3.14.1-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-fe0fec5495

Comment 8 Fedora Update System 2016-07-08 15:01:09 UTC
filezilla-3.12.0.2-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4fb472f180

Comment 9 Noah 2016-07-09 13:01:01 UTC
Works great in Fedora 24 -- thanks! (note to anyone else who may have experienced this problem: you may have to delete or edit ~./config/filezilla/filezilla.xml after updating)

Does not address the issue on Fedora 22 (not that it will matter for much longer) -- also causes new error in F22 when opening Site Manager:
ASSERT INFO:
buildinfo.cpp(118): assert "*version >= '0' && *version <= '9'" failed in ConvertToVersionNumber().

BACKTRACE:
[1] wxNavigationEnabled<wxWindow>::AcceptsFocusFromKeyboard() const
[2] wxString wxString::Format<wxString, wxString>(wxFormatString const&, wxString, wxString)
[3] wxString wxString::Format<wxString, wxString>(wxFormatString const&, wxString, wxString)
[4] wxString wxString::Format<wxString, wxString>(wxFormatString const&, wxString, wxString)
[5] wxNavigationEnabled<wxListCtrlBase>::AcceptsFocusRecursively() const
[6] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const
[7] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)
[8] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[9] wxEvtHandler::TryHereOnly(wxEvent&)
[10] wxEvtHandler::ProcessEventLocally(wxEvent&)
[11] wxEvtHandler::ProcessEvent(wxEvent&)
[12] wxWindowBase::TryAfter(wxEvent&)
[13] wxEvtHandler::SafelyProcessEvent(wxEvent&)
[14] wxToolBarBase::OnLeftClick(int, bool)
[15] g_signal_emit_valist
[16] g_signal_emit_by_name
[17] g_signal_emit_valist
[18] g_signal_emit
[19] g_signal_emit_valist
[20] g_signal_emit
[21] ffi_call_unix64
[22] ffi_call
[23] g_cclosure_marshal_generic_va
[24] g_signal_emit_valist
[25] g_signal_emit
[26] g_cclosure_marshal_VOID__BOXEDv
[27] g_signal_emit_valist
[28] g_signal_emit
[29] gtk_event_controller_handle_event
[30] g_signal_emit_valist
[31] g_signal_emit
[32] gtk_main_do_event
[33] g_main_context_dispatch
[34] g_main_loop_run
[35] gtk_main
[36] wxGUIEventLoop::DoRun()
[37] wxEventLoopBase::Run()
[38] wxAppConsoleBase::MainLoop()
[39] wxEntry(int&, wchar_t**)
[40] __libc_start_main

Comment 10 Fedora Update System 2016-07-10 03:52:40 UTC
filezilla-3.14.1-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-fe0fec5495

Comment 11 Fedora Update System 2016-07-10 15:57:55 UTC
filezilla-3.17.0.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e6d61287bf

Comment 12 Fedora Update System 2016-07-12 03:27:35 UTC
filezilla-3.12.0.2-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4fb472f180

Comment 13 Fedora Update System 2016-07-12 15:01:24 UTC
filezilla-3.17.0.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Gwyn Ciesla 2016-07-13 14:27:36 UTC
Ok, I'll pull the f22 update.

Comment 15 Fedora Update System 2016-07-19 22:23:18 UTC
filezilla-3.14.1-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.