Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1360274 - Review Request: qt5-qtvirtualkeyboard - The Qt Virtual Keyboard
Summary: Review Request: qt5-qtvirtualkeyboard - The Qt Virtual Keyboard
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: qt-reviews
TreeView+ depends on / blocked
 
Reported: 2016-07-26 11:48 UTC by Helio Chissini de Castro
Modified: 2016-08-01 14:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-01 14:54:54 UTC
Type: ---
Embargoed:
rdieter: fedora-review+

Attachments (Terms of Use)

Description Helio Chissini de Castro 2016-07-26 11:48:21 UTC 
Spec URL: https://heliocastro.fedorapeople.org/qt5-qtvirtualkeyboard/qt5-qtvirtualkeyboard.spec
SRPM URL: https://heliocastro.fedorapeople.org/qt5-qtvirtualkeyboard/qt5-qtvirtualkeyboard-5.7.0-1.fc24.src.rpm
Description: The Qt Virtual Keyboard project provides an input framework and reference keyboard frontend
for Qt 5 on Linux Desktop/X11, Windows Desktop, and Boot2Qt targets.
The input framework makes it easy to write custom input methods or to
integrate 3rd party input engines. The input methods can be implemented in C++ or QML.
Fedora Account System Username: heliocastro
Comment 1 Rex Dieter 2016-07-26 12:48:17 UTC 
I can review today
Comment 2 Rex Dieter 2016-07-26 13:07:02 UTC 
naming: ok

macros: ok

scriptlets: ok

sources: ok
fa473ab9175483dd82aa4d27b9682715  qtvirtualkeyboard-opensource-src-5.7.0.tar.xz

licensing: ok

dependencies: mostly ok

1. SHOULD: I see:
%{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}}
but no matching
BuildRequires: qt5-qtbase-private-devel
(which is what we currently use to easily track these hard versioned dependencies).  Please add that

 
Otherwise, relatively simple package, matches conventions and style of other existing qt5 packages.

APPROVED.
Comment 3 Gwyn Ciesla 2016-07-26 13:33:31 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/qt5-qtvirtualkeyboard
Comment 4 Rex Dieter 2016-08-01 14:54:54 UTC 
imported and built for rawhide
Note You need to log in before you can comment on or make changes to this bug.