Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1365658 - Several pcp daemons could benefit from auto-restart
Summary: Several pcp daemons could benefit from auto-restart
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pcp
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nathan Scott
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-09 18:54 UTC by Frank Ch. Eigler
Modified: 2016-10-26 00:58 UTC (History)
9 users (show)

Fixed In Version: pcp-3.11.5-1.el5 pcp-3.11.5-1.fc24 pcp-3.11.5-1.fc23 pcp-3.11.5-1.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-25 16:16:44 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
implementation for systemd (2.52 KB, patch)
2016-08-09 18:54 UTC, Frank Ch. Eigler 		no flags Details | Diff
View All

Description Frank Ch. Eigler 2016-08-09 18:54:41 UTC 
Created attachment 1189379 [details]
implementation for systemd

It has been reported that pmwebd sometimes crashes.  While the cause(s) are under investigation, this reminds one of other cases where bugs in libpcp or the tools themselves have caused OOM or crashes for pmwebd and pmmgr.  In order to protect the user from unnecessary outage of these services, they should be auto-restarted.
Comment 1 Nathan Scott 2016-08-09 23:33:40 UTC 
+1  - and the same potential benefits exist for pmcd and pmproxy, of course.

As discussed here ...

    http://www.pcp.io/pipermail/pcp/2016-May/010464.html
    http://www.pcp.io/pipermail/pcp/2016-May/010519.html

... the attached patch is incomplete and needs a little more work.

Thanks for opening the BZ though - let's use it as a reminder that a patch like this one, and some QA testing work, is still needed.
Comment 2 Frank Ch. Eigler 2016-08-10 17:07:48 UTC 
(In reply to Nathan Scott from comment #1)
> +1  - and the same potential benefits exist for pmcd and pmproxy, of course.

Not "of course".  Compared to pmwebd & pmmgr, those daemons pose a much smaller load on libpcp and the system, and have been apprx. unaffected by crashes.


> As discussed here ...
> [...]
> ... the attached patch is incomplete and needs a little more work.

The patches are complete for pmmgr & pmwebd, the affected daemons.
Comment 3 Nathan Scott 2016-08-11 04:59:47 UTC 
(In reply to Frank Ch. Eigler from comment #2)
> 
> [...]  Compared to pmwebd & pmmgr, those daemons pose a much
> smaller load on libpcp and the system,  [...]
> 

pmcd and pmproxy can also potentially fail and so could benefit from this treatment, that's all I'm saying.  In fact, you said it too...

> 
> The patches are complete for pmmgr & pmwebd, the affected daemons.
> 

Your own attached patch explicitly states that pmcd could benefit, and you are right there.  No doubt that was why you attempted to make it work earlier (i.e. before reverting your own changes in that area).


Anyway, in the interests of moving things along I have completed this work and it's all been merged upstream (commit b0b6ab0746 for reference).
Comment 4 Fedora Update System 2016-09-27 20:21:51 UTC 
pcp-3.11.5-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8d14b648a5
Comment 5 Fedora Update System 2016-09-28 05:56:50 UTC 
pcp-3.11.5-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ca5c041e73
Comment 6 Fedora Update System 2016-09-28 06:25:18 UTC 
pcp-3.11.5-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b32e6fdc78
Comment 7 Fedora Update System 2016-09-29 01:15:59 UTC 
pcp-3.11.5-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-63742f1d5b
Comment 8 Fedora Update System 2016-10-25 16:16:44 UTC 
pcp-3.11.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
Comment 9 Fedora Update System 2016-10-25 20:21:31 UTC 
pcp-3.11.5-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 10 Fedora Update System 2016-10-25 23:50:40 UTC 
pcp-3.11.5-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2016-10-26 00:58:01 UTC 
pcp-3.11.5-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.