Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1373218 - Review Request: zstd - Zstd compression library
Summary: Review Request: zstd - Zstd compression library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Gnatenko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-05 13:55 UTC by Pádraig Brady
Modified: 2016-11-14 17:27 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-14 17:27:11 UTC
Type: ---
Embargoed:
ignatenko: fedora-review+


Attachments (Terms of Use)
licensecheck output (4.82 KB, text/plain)
2016-09-29 00:05 UTC, Michael Cullen
no flags Details

Description Pádraig Brady 2016-09-05 13:55:30 UTC
Spec URL: https://pbrady.fedorapeople.org/zstd.spec
SRPM URL: https://pbrady.fedorapeople.org/zstd-1.0.0-1.src.rpm
Description: Zstd, is a fast lossless compression algorithm,
targeting real-time compression scenarios at zlib-level compression ratio.
A zstd command line utility and libzstd are provided.
Fedora Account System Username: pbrady

Comment 1 Pádraig Brady 2016-09-06 19:20:24 UTC
koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=15520262

Comment 2 Pádraig Brady 2016-09-12 10:06:15 UTC
Spec URL: https://pbrady.fedorapeople.org/zstd.spec
SRPM URL: https://pbrady.fedorapeople.org/zstd-1.0.0-1.fc23.src.rpm
Description: Zstd, is a fast lossless compression algorithm,
targeting real-time compression scenarios at zlib-level compression ratio.
A zstd command line utility and libzstd are provided.
Fedora Account System Username: pbrady

Comment 3 Igor Gnatenko 2016-09-12 10:15:46 UTC
* Missing BuildRequires: gcc
* I think you don't really need to package static library

> Source0:        https://github.com/facebook/zstd/archive/v1.0.0.tar.gz#/%{name}-%{version}.tar.gz
Source0:        https://github.com/facebook/zstd/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz

> Patch0:         zstd-lib-no-rebuild.patch
Write comment where you sent this patch upstream or why it's not applicable for upstream

> %{?__global_ldflags:LDFLAGS="%__global_ldflags"}
no need for this

> CFLAGS="$RPM_OPT_FLAGS" LDFLAGS=$LDFLAGS make %{?_smp_mflags} -C "$dir"
CFLAGS="%{optflags}" LDFLAGS="%{__global_ldflags}" %make_build -C $dir

> make -C tests test-zstd
didn't check but I think you have to export CFLAGS/LDFLAGS here as well

> make install \
>   DESTDIR=$RPM_BUILD_ROOT \
>   PREFIX=%{_prefix} \
>   LIBDIR=%{_libdir}
%make_install PREFIX=%{_prefix} LIBDIR=%{_libdir}

> /usr/bin/zstd
%{_bindir}/%{name}

> /usr/bin/unzstd
%{_bindir}/un%{name}

> /usr/bin/zstdcat
%{_bindir}/%{name}cat

> /usr/share/man/man1/zstd.1.gz
%{_mandir}/man1/%{name}.1*

> /usr/share/man/man1/unzstd.1.gz
%{_mandir}/man1/un%{name}.1*

> /usr/share/man/man1/zstdcat.1.gz
%{_mandir}/man1/%{name}cat.1*

Comment 4 Pádraig Brady 2016-09-12 11:02:53 UTC
Spec URL: https://pbrady.fedorapeople.org/zstd.spec
SRPM URL: https://pbrady.fedorapeople.org/zstd-1.0.0-2.fc23.src.rpm
Description: Zstd, is a fast lossless compression algorithm,
targeting real-time compression scenarios at zlib-level compression ratio.
A zstd command line utility and libzstd are provided.
Fedora Account System Username: pbrady

All review items addressed.
Patch sources are inline in the patches now.
Thanks!

Comment 5 Pádraig Brady 2016-09-22 15:00:46 UTC
The dreaded ping

Comment 6 Michael Cullen 2016-09-29 00:02:58 UTC
In order to keep this moving, here are some comments:

Personally, I'd prefer to see a comment in the spec file so I don't have to open the patch files to see what they do.

Secondly, there's a new release you should package (1.1.0) but it was only released yesterday so I understand why it isn't here.

Here's a review from fedora-review. Mostly it looks alright, but I'm concerned about the licenses around the examples. also, that static library really shouldn't exist!

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Static libraries in -static or -devel subpackage, providing -devel if
  present.
  Note: Package has .a files: libzstd-devel. Does not provide -static:
  libzstd-devel.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
- Newer version is now available
- LICENSE-examples not added as a license file, but examples are shipped
- According to LICENSE-examples, examples are "for non-commercial testing and evaluation purposes only" which is not acceptable in Fedora packages
- example Makefile is GPLv2 which should be added to the license list in the -devel package at least

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[!]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD
     like)", "zlib/libpng", "BSD (3 clause)", "BSD (2 clause)". 110 files
     have unknown license. Detailed output of licensecheck in
     /home/rpmbuilder/1373218-zstd/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 10 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libzstd
     , zstd-debuginfo
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: zstd-1.0.0-2.fc23.x86_64.rpm
          libzstd-1.0.0-2.fc23.x86_64.rpm
          libzstd-devel-1.0.0-2.fc23.x86_64.rpm
          zstd-debuginfo-1.0.0-2.fc23.x86_64.rpm
          zstd-1.0.0-2.fc23.src.rpm
zstd.x86_64: W: name-repeated-in-summary C Zstd
zstd.x86_64: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless
zstd.x86_64: W: spelling-error %description -l en_US zlib -> lib, glib, z lib
libzstd.x86_64: W: spelling-error Summary(en_US) Zstd -> Std, Z std
libzstd.x86_64: W: spelling-error %description -l en_US Zstandard -> Standard, Z standard, Hardstand
libzstd.x86_64: W: no-documentation
zstd.src: W: name-repeated-in-summary C Zstd
zstd.src: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless
zstd.src: W: spelling-error %description -l en_US zlib -> lib, glib, z lib
5 packages and 0 specfiles checked; 0 errors, 9 warnings.




Rpmlint (debuginfo)
-------------------
Checking: zstd-debuginfo-1.0.0-2.fc23.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
zstd.x86_64: W: name-repeated-in-summary C Zstd
libzstd.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.



Requires
--------
zstd (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    rtld(GNU_HASH)

libzstd (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6()(64bit)
    rtld(GNU_HASH)

libzstd-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libzstd(x86-64)
    libzstd.so.1()(64bit)

zstd-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
zstd:
    zstd
    zstd(x86-64)

libzstd:
    libzstd
    libzstd(x86-64)
    libzstd.so.1()(64bit)

libzstd-devel:
    libzstd-devel
    libzstd-devel(x86-64)
    pkgconfig(libzstd)

zstd-debuginfo:
    zstd-debuginfo
    zstd-debuginfo(x86-64)



Source checksums
----------------
https://github.com/facebook/zstd/archive/v1.0.0.tar.gz#/zstd-1.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : 197e6ef74da878cbf72844f38461bb18129d144fd5221b3598e973ecda6f5963
  CHECKSUM(SHA256) upstream package : 197e6ef74da878cbf72844f38461bb18129d144fd5221b3598e973ecda6f5963


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1373218
Buildroot used: fedora-23-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 7 Michael Cullen 2016-09-29 00:05:07 UTC
Created attachment 1205720 [details]
licensecheck output

Attached licensecheck output - there's some BSD stuff, some MIT, some GPL and some other.

Comment 8 Pádraig Brady 2016-09-29 09:48:21 UTC
Spec URL: https://pbrady.fedorapeople.org/zstd.spec
SRPM URL: https://pbrady.fedorapeople.org/zstd-1.1.0-1.fc23.src.rpm
Description: Zstd, is a fast lossless compression algorithm,
targeting real-time compression scenarios at zlib-level compression ratio.
A zstd command line utility and libzstd are provided.
Fedora Account System Username: pbrady

- Main license changed to "BSD and MIT", examples no longer included
- static lib removed

thanks!

Comment 9 Ken Dreyer (Red Hat) 2016-09-30 15:09:21 UTC
This package will help Ceph (https://github.com/ceph/ceph/pull/11156). Thanks for packaging it. I've verified that zstd-1.1.0-1.fc23.src.rpm builds fine in Mock for EPEL 7, too (are you going to maintain it there)?

Comment 10 Pádraig Brady 2016-09-30 16:17:03 UTC
Yes I intend to update epel branches also

Comment 11 Gwyn Ciesla 2016-10-03 13:56:24 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/zstd

Comment 12 Fedora Update System 2016-10-04 13:19:53 UTC
zstd-1.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-df3c15fb8a

Comment 13 Fedora Update System 2016-10-04 14:22:55 UTC
zstd-1.1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-722779c63b

Comment 14 Fedora Update System 2016-10-04 22:19:27 UTC
zstd-1.1.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ebb17c7dc5

Comment 15 Fedora Update System 2016-10-05 01:54:51 UTC
zstd-1.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c258c9e3b5

Comment 16 Fedora Update System 2016-10-05 02:26:24 UTC
zstd-1.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3355e1dae4

Comment 17 Christian Kujau 2016-10-05 17:22:07 UTC
The zstd sources also contain a multithreaded version, pzstd. Can this be included in the zstd Fedora package as well?

  git clone https://github.com/facebook/zstd.git && cd zstd
  make && make -C contrib/pzstd/

...would build both executables.

Comment 18 Pádraig Brady 2016-10-05 19:36:48 UTC
I wasn't sure how supported this was, or if it might be temporary in nature, with the functionality being added to the main zstd util? I'll ask upstream...

Comment 19 Pádraig Brady 2016-10-06 18:28:41 UTC
zstd-1.1.0-2 is built now containing pzstd

pzstd is not available on el6 due to requiring c++11,
and is only available on x86 due to test instability on arm platforms at least

I'll let zstd-1.1.0-1 propagate fully before pushing this

Comment 20 Igor Gnatenko 2016-10-06 19:16:40 UTC
(In reply to Pádraig Brady from comment #19)
> zstd-1.1.0-2 is built now containing pzstd
> 
> pzstd is not available on el6 due to requiring c++11,
who cares about el6 in 2016....
> and is only available on x86 due to test instability on arm platforms at
> least
You can do something like:
make check \
%ifarch %{arm}
  || :
%else
  ;
%endif
> 
> I'll let zstd-1.1.0-1 propagate fully before pushing this

Comment 21 Fedora Update System 2016-10-09 18:51:12 UTC
zstd-1.1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 22 Fedora Update System 2016-10-12 23:23:00 UTC
zstd-1.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 23 Fedora Update System 2016-10-13 02:53:36 UTC
zstd-1.1.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2016-10-21 15:51:56 UTC
zstd-1.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 25 Fedora Update System 2016-10-21 18:17:22 UTC
zstd-1.1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.