Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1373486 - Review Request: python34 - Version 3.4 of the Python programming language
Summary: Review Request: python34 - Version 3.4 of the Python programming language
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Charalampos Stratakis
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-06 11:57 UTC by Miro Hrončok
Modified: 2016-10-09 02:50 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-04 18:50:00 UTC
Type: ---
Embargoed:
cstratak: fedora-review+

Attachments (Terms of Use)

Description Miro Hrončok 2016-09-06 11:57:52 UTC 
Spec URL: https://github.com/fedora-python/python34/raw/master/python34.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python34-3.4.3-11.fc26.src.rpm

Description: Python 3.4 package for developers.
No security fixes will be applied.

Fedora Account System Username: churchyard
COPR: https://copr.fedorainfracloud.org/coprs/g/python/python34/

This package is intended for Fedora 24+.

In the review, please note that this is a backport of the python3 package and the spec might be more complicated than necessary for the sake of much easier portability between python34 and python3.

On the other hand, please be thorough about things like conflicts with python3 package, upgrade paths, etc.

Also please note that:

https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Process

Contributors and reviewers MUST follow the Package Review Process, with the following exceptions:

* The package is being created so that multiple versions of the same package can coexist in the distribution. The package MUST be properly named according to the naming guidelines and MUST NOT conflict with all other versions of the same package.

I'd like the reviewer to check this condition first.
Comment 1 Charalampos Stratakis 2016-09-20 17:02:42 UTC 
I plan to test it on Fedora 24 and Fedora 25.

Will need to check that the interpreters can work side by side without clashing in any way, meaning firing up python shells and trying various things as well as executing some basic scripts.

Upgrade paths should be clean (F24->F25, F25->F26) however I will test that, just for consistency.

This should be easier though than python35. Anything else that I might be missing, in order to properly test the package?
Comment 2 Miro Hrončok 2016-09-20 21:26:31 UTC 
(In reply to Charalampos Stratakis from comment #1)
> This should be easier though than python35. Anything else that I might be
> missing, in order to properly test the package?

I think this is going to be pretty straight forward, in case we are not missing anything.
Comment 3 Charalampos Stratakis 2016-09-22 08:54:15 UTC 
Is it possible to upgrade the package to its latest version? (Python 3.4.5)

Changelog: https://docs.python.org/3.4/whatsnew/changelog.html#python-3-4-5
Comment 4 Miro Hrončok 2016-09-22 10:04:45 UTC 
Will do.
Comment 5 Miro Hrončok 2016-09-22 12:37:19 UTC 
Spec URL: https://github.com/fedora-python/python34/raw/master/python34.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python34-3.4.5-1.fc26.src.rpm
Comment 6 Charalampos Stratakis 2016-09-22 14:43:49 UTC 
It seems there is a (minor?) conflict. Same issue also appears at python35.

By invoking 'rpm -ql python34' you get the list of files and dirs owned by the rpm and these directories are shared among system-python-libs, sssd-common and python34 on a Fedora 24 system:

/usr/share/systemtap
/usr/share/systemtap/tapset

Relevant part of the SPEC:

https://github.com/fedora-python/python34/blob/master/python34.spec#L1145

Should these dirs be removed from the SPEC?
Comment 7 Miro Hrončok 2016-09-22 16:14:49 UTC 
This is because those directories aren't owned by any package this can require. It's fine and intentional.
Comment 8 Charalampos Stratakis 2016-09-23 17:11:33 UTC 
Package is updated to 3.4.5, the latest version of Python 3.4 upstream.

Rewheel mode is disabled.

Debug build is disabled.

Package is flat, meaning that there are no subpackages, all the files and directories are at the main package.

Most binaries, as well as libraries and man pages are removed or renamed so they do not conflict with the system python3 package. The binary for this package is renamed to python34.

python(abi) is not required/provided.

setuptools and pip come bundled with this package, so to comply with the packaging guidelines virtual provides are added.

%{pylibdir} gets expanded to %{_libdir}/python3.4 so it will not conflict with %{_libdir}/python3.5 at F24+ (or %{_libdir}/python3.6 in the future at F26+).

Tested on F24, F25 and rawhide VM's. No regressions noted.

'python3' command fires up the python 3.5.1 (F24) or 3.5.2 (F25+)  shell and 'python34' the 3.4.5 shell.

There were no upgrade paths issues and the package name does not conflict with anything so far for branches that it is intended to be built against

Package accepted.
Comment 9 Miro Hrončok 2016-09-23 22:34:46 UTC 
So, we already have python34 in the git, because of EPEL. I'v just requested ACLs on the package for Fedora branches and I'm asking the maintainer (who happens to be Peter Viktorin), if he agrees to use this package in Fedora, as approved by this review.
Comment 10 Miro Hrončok 2016-09-23 22:35:39 UTC 
s/Peter/Petr/
Comment 11 Petr Viktorin (pviktori) 2016-09-24 07:31:31 UTC 
Go ahead!
Comment 12 Fedora Update System 2016-09-27 06:20:44 UTC 
python34-3.4.5-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b6ce74ea2e
Comment 13 Fedora Update System 2016-09-27 07:21:33 UTC 
python34-3.4.5-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3d423e316c
Comment 14 Fedora Update System 2016-10-04 18:50:00 UTC 
python34-3.4.5-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 15 Fedora Update System 2016-10-09 02:50:47 UTC 
python34-3.4.5-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.