Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1377672 - Above sea level is in 'km' instead of 'm' in tooltip
Summary: Above sea level is in 'km' instead of 'm' in tooltip
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: xfce4-weather-plugin
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Christoph Wickert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-20 10:57 UTC by Jaroslav Škarvada
Modified: 2016-10-13 21:54 UTC (History)
3 users (show)

Fixed In Version: xfce4-weather-plugin-0.8.8-2.fc25 xfce4-weather-plugin-0.8.8-2.fc24
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-11 15:42:40 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Wrong display (deleted)
2016-09-20 10:57 UTC, Jaroslav Škarvada 		no flags Details
Settings dialog (deleted)
2016-09-20 10:58 UTC, Jaroslav Škarvada 		no flags Details
screenshot from my system (deleted)
2016-09-21 00:23 UTC, Mukundan Ragavan 		no flags Details
Proposed fix (deleted)
2016-09-21 15:35 UTC, Jaroslav Škarvada 		no flags Details | Diff
View All

Description Jaroslav Škarvada 2016-09-20 10:57:57 UTC 
Created attachment 1202849 [details]
Wrong display

Description of problem:
In the settings dialog the above sea level (ASL) is in meters (m), but in the tooltip the same number is suffixed as kilometers (km). See screenshots for details. I was able to reproduce this in Czech locale, I didn't try different locales.

Version-Release number of selected component (if applicable):
xfce4-screenshooter-1.8.2-6.fc24.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Compare settings dialog and tooltip

Actual results:
In settings dialog the number is in meters (correct), but in the tooltip it's displayed as kilometers (incorrect).

Expected results:
Both displayed in meters.

Additional info:
Comment 1 Jaroslav Škarvada 2016-09-20 10:58:32 UTC 
Created attachment 1202850 [details]
Settings dialog
Comment 2 Mukundan Ragavan 2016-09-21 00:23:54 UTC 
Created attachment 1203090 [details]
screenshot from my system

That's very strange ..

See the attached screenshot from my system - it does seem to show the correct units.

What version of xfce4-weather-plugin do you have installed? the latest from repos?
Comment 3 Mukundan Ragavan 2016-09-21 00:27:40 UTC 
I wonder if this is something that crept through in translation (typoish) .. likely?
Comment 4 Jaroslav Škarvada 2016-09-21 15:35:17 UTC 
Created attachment 1203373 [details]
Proposed fix

Yes, it seems it's typo in the translation. I think the attached patch is correct (but I haven't check it yet, I will check it later today.

Sorry about the wrong NVR in the report, copy and paste error from different bug :)

xfce4-weather-plugin-0.8.8-1.fc24.x86_64

The patch seems to also apply over the rawhide.
Comment 5 Jaroslav Škarvada 2016-09-21 18:26:49 UTC 
The proposed patch fixed the problem for me.
Comment 6 Mukundan Ragavan 2016-09-22 00:56:39 UTC 
Thanks for the patch. I will push this soon (tomorrow most likely) and also submit this upstream.
Comment 7 Mukundan Ragavan 2016-10-01 21:03:13 UTC 
Can you install this and verify that the patch has applied cleanly?

http://koji.fedoraproject.org/koji/buildinfo?buildID=805859


Thanks.
Comment 8 Jaroslav Škarvada 2016-10-04 10:20:05 UTC 
(In reply to Mukundan Ragavan from comment #7)
> Can you install this and verify that the patch has applied cleanly?
> 
> http://koji.fedoraproject.org/koji/buildinfo?buildID=805859
> 
> 
> Thanks.

Thanks, I can confirm the build fixed the problem for me.
Comment 9 Fedora Update System 2016-10-05 01:54:20 UTC 
xfce4-weather-plugin-0.8.8-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9b39bffdbb
Comment 10 Fedora Update System 2016-10-05 02:25:57 UTC 
xfce4-weather-plugin-0.8.8-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-aa38ea6337
Comment 11 Fedora Update System 2016-10-11 15:42:40 UTC 
xfce4-weather-plugin-0.8.8-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2016-10-13 21:54:14 UTC 
xfce4-weather-plugin-0.8.8-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.