Taken!

Looks fine, APPROVED!

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/package/appmenu-qt5
  See:
  https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names

===> Unretirement review, so this is fine here


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

===> Unversioned one is a plugin

[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "LGPL (v3)", "Unknown or generated". 3 files have unknown
     license. Detailed output of licensecheck in /home/review/1382811
     -appmenu-qt5/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in appmenu-
     qt5-profile.d , appmenu-qt5-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)

===> See above, ignore

[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: appmenu-qt5-0.3.0+16.10.20160628.1-0.1.fc26.x86_64.rpm
          appmenu-qt5-profile.d-0.3.0+16.10.20160628.1-0.1.fc26.noarch.rpm
          appmenu-qt5-debuginfo-0.3.0+16.10.20160628.1-0.1.fc26.x86_64.rpm
          appmenu-qt5-0.3.0+16.10.20160628.1-0.1.fc26.src.rpm
appmenu-qt5-profile.d.noarch: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure
appmenu-qt5-profile.d.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
appmenu-qt5-profile.d.noarch: W: no-documentation
appmenu-qt5-profile.d.noarch: E: executable-sourced-script /etc/profile.d/appmenu-qt5.csh 755
appmenu-qt5-profile.d.noarch: E: executable-sourced-script /etc/profile.d/appmenu-qt5.sh 755
4 packages and 0 specfiles checked; 2 errors, 3 warnings.




Rpmlint (debuginfo)
-------------------
Checking: appmenu-qt5-debuginfo-0.3.0+16.10.20160628.1-0.1.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
appmenu-qt5-profile.d.noarch: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure
appmenu-qt5-profile.d.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
appmenu-qt5-profile.d.noarch: W: no-documentation
appmenu-qt5-profile.d.noarch: E: executable-sourced-script /etc/profile.d/appmenu-qt5.sh 755
appmenu-qt5-profile.d.noarch: E: executable-sourced-script /etc/profile.d/appmenu-qt5.csh 755
3 packages and 0 specfiles checked; 2 errors, 3 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /home/review/1382811-appmenu-qt5/srpm/appmenu-qt5.spec	2016-10-07 21:46:16.976670570 +0200
+++ /home/review/1382811-appmenu-qt5/srpm-unpacked/appmenu-qt5.spec	2016-10-07 15:31:56.000000000 +0200
@@ -12,5 +12,5 @@
 BuildRequires:	qt5-qtbase-devel
 BuildRequires:	qt5-qtbase-static
-BuildRequires:	systemd-devel
+BuildRequires:	systemd
 
 Requires:	qt5-qtbase-gui%{?_isa}
@@ -49,5 +49,4 @@
 setenv QT_QPA_PLATFORMTHEME appmenu-qt5
 EOF
-%{_sbindir}/touch -r %{name}.sh %{name}.csh
 
 # Create README.fedora
@@ -85,4 +84,5 @@
 %{_libdir}/qt5/plugins/platformthemes/lib%{name}.so
 
+
 %files profile.d
 %{_sysconfdir}/profile.d/%{name}.*


Requires
--------
appmenu-qt5 (rpmlib, GLIBC filtered):
    libEGL.so.1()(64bit)
    libGL.so.1()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.7)(64bit)
    libQt5DBus.so.5()(64bit)
    libQt5DBus.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Gui.so.5(Qt_5_PRIVATE_API)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libX11.so.6()(64bit)
    libXext.so.6()(64bit)
    libXrender.so.1()(64bit)
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libdbusmenu-qt5.so.2()(64bit)
    libdl.so.2()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgthread-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libinput.so.10()(64bit)
    libm.so.6()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libudev.so.1()(64bit)
    libxkbcommon.so.0()(64bit)
    qt5-qtbase-gui(x86-64)
    rtld(GNU_HASH)

appmenu-qt5-debuginfo (rpmlib, GLIBC filtered):

appmenu-qt5-profile.d (rpmlib, GLIBC filtered):
    appmenu-qt5
    setup



Provides
--------
appmenu-qt5:
    appmenu-qt5
    appmenu-qt5(x86-64)
    libappmenu-qt5.so()(64bit)

appmenu-qt5-debuginfo:
    appmenu-qt5-debuginfo
    appmenu-qt5-debuginfo(x86-64)

appmenu-qt5-profile.d:
    appmenu-qt5-profile.d



Unversioned so-files
--------------------
appmenu-qt5: /usr/lib64/qt5/plugins/platformthemes/libappmenu-qt5.so

Source checksums
----------------
http://archive.ubuntu.com/ubuntu/pool/main/a/appmenu-qt5/appmenu-qt5_0.3.0+16.10.20160628.1.orig.tar.gz :
  CHECKSUM(SHA256) this package     : e69a5e1c5626921a52951d19ce52d435ead0745951c1bff8b96516e1e20af80e
  CHECKSUM(SHA256) upstream package : e69a5e1c5626921a52951d19ce52d435ead0745951c1bff8b96516e1e20af80e


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1382811
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

The main issue I see with this thing is that it is its own "platform", which means enabling it breaks all other platform integration in Qt 5. There is not much you can do about that, but at least it should be documented clearly, in the instructions that say to set QT_QPA_PLATFORMTHEME=appmenu-qt5.

appmenu-qt5-0.3.0+16.10.20160628.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-62e1276309

appmenu-qt5-0.3.0+16.10.20160628.1-1.fc24, cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc24, unity-gtk-module-0.0.0+16.10.20160913-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-aa3eace46c

appmenu-qt5-0.3.0+16.10.20160628.1-1.fc25, cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc25, unity-gtk-module-0.0.0+16.10.20160913-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cda26e7897

appmenu-qt5-0.3.0+16.10.20160628.1-1.fc25, cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc25, unity-gtk-module-0.0.0+16.10.20160913-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

appmenu-qt5-0.3.0+16.10.20160628.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

appmenu-qt5-0.3.0+16.10.20160628.1-1.fc24, cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc24, unity-gtk-module-0.0.0+16.10.20160913-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

If http://blog.broulik.de/2016/10/global-menus-returning/ is to be believed, this plugin isn't needed anymore with Qt 5.7. (Qt already handles this in QGenericUnixTheme now.)