Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1382908 - Review Request: xapps - Common files for XApp desktop apps
Summary: Review Request: xapps - Common files for XApp desktop apps
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Wolfgang Ulbrich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-08 08:16 UTC by leigh scott
Modified: 2016-10-24 02:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-18 11:30:59 UTC
Type: ---
Embargoed:
fedora: fedora-review+


Attachments (Terms of Use)

Description leigh scott 2016-10-08 08:16:17 UTC
Spec URL: https://leigh123linux.fedorapeople.org/pub/review/xapps/1/xapps.spec
SRPM URL: https://leigh123linux.fedorapeople.org/pub/review/xapps/1/xapps-1.0.0-0.1.git7e7567a.fc24.src.rpm

Description:
This package includes files that are shared between several XApp
apps (i18n files and configuration schemas).

Fedora Account System Username: leigh123linux

Comment 1 Wolfgang Ulbrich 2016-10-11 17:39:46 UTC
Only a few issues:

Issues:
=======
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in xapps
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache


and a typo:

xapps.x86_64: W: incoherent-version-in-changelog 0.1-0.1.git7e7567a ['1.0.0-0.1.git7e7567a.fc26', '1.0.0-0.1.git7e7567a']

Comment 3 Wolfgang Ulbrich 2016-10-12 04:16:20 UTC
APPROVED!

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:

[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[-]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gir-1.0
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: glib-compile-schemas is run in %postun and %posttrans if package has
     *.gschema.xml files.
     Note: gschema file(s) in xapps
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
     contains icons.
     Note: icons in xapps
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xapps-
     devel , xapps-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[-]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 1218560 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: xapps-1.0.0-0.2.git7e7567a.fc26.x86_64.rpm
          xapps-devel-1.0.0-0.2.git7e7567a.fc26.x86_64.rpm
          xapps-debuginfo-1.0.0-0.2.git7e7567a.fc26.x86_64.rpm
          xapps-1.0.0-0.2.git7e7567a.fc26.src.rpm
xapps.x86_64: W: no-documentation
xapps.x86_64: W: no-manual-page-for-binary xfce4-set-wallpaper
xapps-devel.x86_64: W: only-non-binary-in-usr-lib
xapps-devel.x86_64: W: no-documentation
xapps.src: W: spelling-error %description -l en_US schemas -> schema, sachems, schemes
4 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (debuginfo)
-------------------
Checking: xapps-debuginfo-1.0.0-0.2.git7e7567a.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
xapps.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libxapp.so.1.0.0 /lib64/libpthread.so.0
xapps.x86_64: W: no-documentation
xapps.x86_64: W: no-manual-page-for-binary xfce4-set-wallpaper
xapps-devel.x86_64: W: only-non-binary-in-usr-lib
xapps-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 5 warnings.



Requires
--------
xapps (rpmlib, GLIBC filtered):
    /bin/bash
    /bin/sh
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libgdk-3.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgnomekbdui.so.8()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-3.so.0()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)

xapps-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libxapp.so.1()(64bit)
    xapps(x86-64)

xapps-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
xapps:
    libxapp.so.1()(64bit)
    xapps
    xapps(x86-64)

xapps-devel:
    pkgconfig(xapp)
    xapps-devel
    xapps-devel(x86-64)

xapps-debuginfo:
    xapps-debuginfo
    xapps-debuginfo(x86-64)



Source checksums
----------------
https://github.com/linuxmint/xapps/archive/7e7567a0e0c7e29928c4557a6196da95a18f8e2c.tar.gz#/xapps-7e7567a0e0c7e29928c4557a6196da95a18f8e2c.tar.gz :
  CHECKSUM(SHA256) this package     : d87df55b50483f65d50a8fbd1bd40778398ee761d1c3b298c6a3dbc26f39e1ab
  CHECKSUM(SHA256) upstream package : d87df55b50483f65d50a8fbd1bd40778398ee761d1c3b298c6a3dbc26f39e1ab


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -v -r -n xapps -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Gwyn Ciesla 2016-10-12 13:25:10 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/xapps

Comment 5 Fedora Update System 2016-10-14 02:20:19 UTC
xapps-1.0.0-0.2.git0f28d18.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0a16083673

Comment 6 Fedora Update System 2016-10-14 03:21:00 UTC
xapps-1.0.0-0.2.git0f28d18.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e90c290f6e

Comment 7 Fedora Update System 2016-10-14 04:56:25 UTC
xapps-1.0.0-0.2.git0f28d18.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2dca52fc36

Comment 8 Fedora Update System 2016-10-18 11:30:59 UTC
xapps-1.0.0-0.2.git0f28d18.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-10-23 22:49:04 UTC
xapps-1.0.0-0.2.git0f28d18.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-10-24 02:48:46 UTC
xapps-1.0.0-0.2.git0f28d18.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.