Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1387873 - Review Request: python2-pyx - Python graphics package
Summary: Review Request: python2-pyx - Python graphics package
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1286341
TreeView+ depends on / blocked
 
Reported: 2016-10-22 21:49 UTC by Michal Ambroz
Modified: 2017-05-08 22:31 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-08 14:18:59 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Michal Ambroz 2016-10-22 21:49:38 UTC
Spec URL: http://rebus.fedorapeople.org//python2-pyx.spec
SRPM URL: http://rebus.fedorapeople.org//python2-pyx-0.12.1-3.fc24.src.rpm

Description:
PyX is a Python package for the creation of PostScript and PDF files. It
combines an abstraction of the PostScript drawing model with a TeX/LaTeX
interface. Complex tasks like 2d and 3d plots in publication-ready quality are
built out of these primitives.

This package contains the last version which is compatible with Python 2.
It expects its configuration in py2pyxrc instead of pyxrc and can be installed
in parallel with the PyX package for Python 3.

Comment 1 Michal Ambroz 2016-10-22 21:57:11 UTC
Please note that the python2 dependency for the PyX is still used by the existing package scapy. See bug #1286341 .

Comment 2 Michal Ambroz 2016-10-22 23:39:52 UTC
Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=16169386

Comment 3 Michael J Gruber 2016-10-24 13:04:44 UTC
I still think that packaging of PyX 0.12 as well as 0.14 should be in the same hands, which explains my being silent. And this submission proves my point:

The python3 package is named PyX, so unless that is being renamed to python3-pyx there is no reason to name the python2 package with a different spelling from the python3 package (and from the former python2 package).

Incidentally, if you go back to version 0.12.1-2 of the spec file you're not only back to a more consistent naming scheme but remove the newly introduced typoes, as well ;)

Comment 4 Michal Ambroz 2016-11-01 21:53:47 UTC
Hello Michael,
>The python3 package is named PyX

I have used the naming in lover-case as I believe it goes best with the python package naming conventions and it has been also suggested to be like that in the bug #1286341 by Jose Matos.

The python3 package actually also contains "provides" of the python3-pyx so naming this one python2-pyx is consistent with that. You actually do "import pyx" and not "import PyX" so I believe naming python module with lowercase is the right thing to do.

> but remove the newly introduced typoes
I beg your pardon. As a non-native speaker I am probably blind to the typoes. If you have some I am happy to fix those in a spec file.

Best regards
Michal Ambroz

Comment 5 Zbigniew Jędrzejewski-Szmek 2016-11-13 16:45:49 UTC
The upstream decision to move to python3 only is quite unfortunate. But what's done that's done. Adding a compat python2 package is reasonable.

The name is OK, it should be lowercase, in line with current guidelines.

I think you should:
- add a fat warning in the %description that this is a compat package and should not be used for new stuff

- drop the documentation parts from the package: documentation is useful for new stuff, and nobody should be using that
- replace the useless macros like %__sed with normal calls [see https://fedoraproject.org/wiki/Packaging:Guidelines#Macros].
- use %py2_build and %py2_install

The first point is "user visible", the remaining three are just cleanup, so just a suggestion.

Comment 6 Michal Ambroz 2016-11-22 03:02:46 UTC
Thanks Zbysek for comments.
Updated package:

Spec URL: http://rebus.fedorapeople.org/SPECS/python2-pyx.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/python2-pyx-0.12.1-4.fc24.src.rpm

Best regards
Michal Ambroz

Comment 7 Zbigniew Jędrzejewski-Szmek 2016-11-22 23:45:47 UTC
%{!?python2_sitearch: %define python_sitearch %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
→ harmless, but unnecessary

Group:          Applications/Publishing
→ not needed

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
→ SHOULD NOT be used [https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]

Provides:	python2-pyx
→ should be removed

python2-pyx.src: E: description-line-too-long C WARNING: This is compat python2 package and should be used only for legacy stuff.
python2-pyx.src:22: W: unversioned-explicit-provides python2-pyx
python2-pyx.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 13)
python2-pyx.src: W: file-size-mismatch pyxfaq.pdf = 159033, http://pyx.sourceforge.net/pyxfaq.pdf = 158776
python2-pyx.src: W: file-size-mismatch manual.pdf = 696879, http://pyx.sourceforge.net/manual.pdf = 707854
python2-pyx.src: W: invalid-url Source0: http://downloads.sourceforge.net/sourceforge/pyx/PyX-0.12.1.tar.gz HTTP Error 404: Not Found

Comment 8 Michal Ambroz 2016-11-23 05:42:56 UTC
Thanks Zbysek for comments.
Updated package:

Spec URL: http://rebus.fedorapeople.org/SPECS/python2-pyx.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/python2-pyx-0.12.1-4.fc24.src.rpm

Download of file was removed from sourceforge, switched to pypi repository.


Best regards
Michal Ambroz

Comment 9 Michal Ambroz 2016-11-23 05:44:36 UTC
Opps - fingers faster than brain - the links should have been:
Spec URL: http://rebus.fedorapeople.org/SPECS/python2-pyx.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/python2-pyx-0.12.1-5.fc24.src.rpm

Comment 10 Zbigniew Jędrzejewski-Szmek 2016-11-23 13:59:30 UTC
%python_provide should be used:
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

BuildRequires:  python-devel → python2-devel
[https://fedoraproject.org/wiki/Packaging:Python#BuildRequires]

fedora-review says:
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1546240 bytes in 201 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
Not terribly important, but like I said, documentation could be dropped from the package.

Comment 11 Michal Ambroz 2016-11-23 16:43:27 UTC
It looked much easier when José Matos <jamatos.pt> claimed in 1286341 :
> Michael if you want to submit this file for review I will approve it immediately.

:D

Comment 12 Michal Ambroz 2016-11-23 16:51:42 UTC
BTW Zbysek please can you make your mind - is or is not that Provides necessary?
I have removed it on your request, now you want it back in form of macro.

Please note this will build only with python2 so in my opinion having there just "Provides: python2-pyx" is the right thing. Using %python_provide is a must only in case building for multiple pythons. We do not want to end-up having there "Provides: python-pyx", because that would suggest python3, by default in f25.

Best regards
Michal Ambroz

Comment 13 Zbigniew Jędrzejewski-Szmek 2016-11-23 17:12:33 UTC
(In reply to Michal Ambroz from comment #12)
> BTW Zbysek please can you make your mind - is or is not that Provides
> necessary?
> I have removed it on your request, now you want it back in form of macro.
I did not request %python_provide to be removed. Comment c#10 was the first place where I mentioned it.

> Please note this will build only with python2 so in my opinion having there
> just "Provides: python2-pyx" is the right thing. Using %python_provide is a
> must only in case building for multiple pythons. We do not want to end-up
> having there "Provides: python-pyx", because that would suggest python3, by
> default in f25.

The goal of having %python_provide is that *now* we get Provides:python-%{name} on all python2 binary packages, and at some point in the *future*, when we want python3 packages to be installed when you ask for python-%{name}, we can do that switch automatically, just by adjusting the definition of that macro and doing a mass rebuild. Having a single or multiple subpackages doesn't really matter here.

That switch hasn't happened yet, and will never happen in F25. Currently, when you ask for python-%{name}, you should get python2 version (either python2-%{name} subpackage for the ones that did the rename, or python-%{name} subpackage for the rest).

So, python2-pyx should have the (automatically generated) Provides:python-pyx tag.

(In reply to Michal Ambroz from comment #11)
> It looked much easier when José Matos <jamatos.pt> claimed in 1286341 :
> > Michael if you want to submit this file for review I will approve it immediately.
> 
> :D

Yeah, it's taking longer than expected ;) As a consolation, look at the this way: after the initial build you're unlikely to ever touch the package again.

Comment 14 Michal Ambroz 2016-11-23 20:49:25 UTC
Hello Zbysek,
OK thanks for your explanations.
Here is the update:
Spec URL: http://rebus.fedorapeople.org/SPECS/python2-pyx.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/python2-pyx-0.12.1-6.fc24.src.rpm

Best regards
Michal Ambroz

Comment 15 Zbigniew Jędrzejewski-Szmek 2016-12-02 00:46:31 UTC
Sorry for the delay.

+ package name is OK
+ package license is acceptable
+ license is specified correctly
+ P/R/BR look correct
+ builds and installs OK
+ fedora-review is happy

rpmlint:
python2-pyx.src: W: spelling-error %description -l en_US compat -> compact, combat, cowpat
python2-pyx.src: W: spelling-error %description -l en_US scapy -> scary, soapy, scaly
python2-pyx.src: W: spelling-error %description -l en_US pyxrc -> pyx
python2-pyx.x86_64: W: spelling-error %description -l en_US compat -> compact, combat, cowpat
python2-pyx.x86_64: W: spelling-error %description -l en_US scapy -> scary, soapy, scaly
python2-pyx.x86_64: W: spelling-error %description -l en_US pyxrc -> pyx
python2-pyx.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/pyx/data/lfs/createlfs.tex
python2-pyx-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/PyX-0.12.1/pyx/font/_t1code.c
python2-pyx-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/PyX-0.12.1/pyx/pykpathsea.c
python2-pyx-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python2-pyx-doc/contrib/epstopng.py
python2-pyx-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python2-pyx-doc/contrib/dvitype.py
python2-pyx-doc.noarch: W: spurious-executable-perm /usr/share/doc/python2-pyx-doc/manual/graph.py
python2-pyx-doc.noarch: W: spurious-executable-perm /usr/share/doc/python2-pyx-doc/examples/graphs/join.py
python2-pyx-doc.noarch: W: spurious-executable-perm /usr/share/doc/python2-pyx-doc/manual/graph2.py
python2-pyx-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python2-pyx-doc/contrib/textboxes.tex
python2-pyx-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python2-pyx-doc/contrib/dviconvert.py
python2-pyx-doc.noarch: E: incorrect-fsf-address /usr/share/doc/python2-pyx-doc/contrib/imgconvert.py
python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/arrows.py /usr/bin/python2
python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/pathstyles.py /usr/bin/python2
python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/gradientname.py /usr/bin/python2
python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/colorname.py /usr/bin/python2
python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/examples/3dgraphs/grid.py /usr/bin/python2
python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/examples/3dgraphs/surface.py /usr/bin/python2
python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/connector.py /usr/bin/python2
python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/examples/3dgraphs/bar.py /usr/bin/python2
python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/examples/3dgraphs/color.py /usr/bin/python2
python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/contrib/callingtex.py /usr/bin/python2
python2-pyx-doc.noarch: W: doc-file-dependency /usr/share/doc/python2-pyx-doc/manual/color.py /usr/bin/python2
4 packages and 0 specfiles checked; 8 errors, 20 warnings.
Nothing important.

Package is APPROVED.

Comment 16 Gwyn Ciesla 2016-12-21 13:38:36 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python2-pyx

Comment 17 Fedora Update System 2017-04-29 01:42:21 UTC
python2-pyx-0.12.1-6.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1365d500f2

Comment 18 Fedora Update System 2017-04-29 01:42:32 UTC
python2-pyx-0.12.1-6.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6542140fc6

Comment 19 Fedora Update System 2017-04-29 01:42:39 UTC
python2-pyx-0.12.1-6.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f47b98e3f

Comment 20 Fedora Update System 2017-04-30 02:23:57 UTC
python2-pyx-0.12.1-6.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f47b98e3f

Comment 21 Fedora Update System 2017-04-30 02:26:37 UTC
python2-pyx-0.12.1-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1365d500f2

Comment 22 Fedora Update System 2017-04-30 03:52:53 UTC
python2-pyx-0.12.1-6.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6542140fc6

Comment 23 Fedora Update System 2017-05-08 14:18:59 UTC
python2-pyx-0.12.1-6.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2017-05-08 22:22:38 UTC
python2-pyx-0.12.1-6.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 25 Fedora Update System 2017-05-08 22:31:53 UTC
python2-pyx-0.12.1-6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.