Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Header files in -devel subpackage, if present.
  Note: mingw32-openal-soft : /usr/i686-w64-mingw32/sys-
  root/mingw/include/AL/al.h mingw32-openal-soft : /usr/i686-w64-mingw32
  /sys-root/mingw/include/AL/alc.h mingw32-openal-soft :
  /usr/i686-w64-mingw32/sys-root/mingw/include/AL/alext.h mingw32-openal-
  soft : /usr/i686-w64-mingw32/sys-root/mingw/include/AL/efx-creative.h
  mingw32-openal-soft : /usr/i686-w64-mingw32/sys-root/mingw/include/AL
  /efx-presets.h mingw32-openal-soft : /usr/i686-w64-mingw32/sys-
  root/mingw/include/AL/efx.h mingw64-openal-soft : /usr/x86_64-w64-mingw32
  /sys-root/mingw/include/AL/al.h mingw64-openal-soft :
  /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/alc.h mingw64-openal-
  soft : /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/alext.h mingw64
  -openal-soft : /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/efx-
  creative.h mingw64-openal-soft : /usr/x86_64-w64-mingw32/sys-
  root/mingw/include/AL/efx-presets.h mingw64-openal-soft :
  /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/efx.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Static libraries in -static or -devel subpackage, providing -devel if
  present.
  Note: Package has .a files: mingw32-openal-soft, mingw64-openal-soft.
  Illegal package name: mingw32-openal-soft, mingw64-openal-soft. Does not
  provide -static: mingw32-openal-soft, mingw64-openal-soft.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[-]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: The placement of pkgconfig(.pc) files are correct.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: mingw32-openal-soft-1.17.2-1.fc24.noarch.rpm
          mingw64-openal-soft-1.17.2-1.fc24.noarch.rpm
          mingw-openal-soft-1.17.2-1.fc24.src.rpm
mingw32-openal-soft.noarch: W: spelling-error %description -l en_US doppler -> Doppler
mingw32-openal-soft.noarch: W: spelling-error %description -l en_US reverb -> revere, revers, revert
mingw32-openal-soft.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti
mingw32-openal-soft.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libOpenAL32.dll.a
mingw32-openal-soft.noarch: W: no-documentation
mingw32-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/AL/al.h
mingw32-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/AL/alc.h
mingw32-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/AL/efx-creative.h
mingw32-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/openal.pc
mingw32-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/AL/efx-presets.h
mingw32-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/AL/efx.h
mingw32-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/libOpenAL32.dll.a
mingw32-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/AL/alext.h
mingw32-openal-soft.noarch: W: non-standard-dir-in-usr i686-w64-mingw32
mingw64-openal-soft.noarch: W: spelling-error %description -l en_US doppler -> Doppler
mingw64-openal-soft.noarch: W: spelling-error %description -l en_US reverb -> revere, revers, revert
mingw64-openal-soft.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti
mingw64-openal-soft.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libOpenAL32.dll.a
mingw64-openal-soft.noarch: W: no-documentation
mingw64-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/alext.h
mingw64-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/alc.h
mingw64-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/efx-presets.h
mingw64-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libOpenAL32.dll.a
mingw64-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/efx-creative.h
mingw64-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/al.h
mingw64-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/efx.h
mingw64-openal-soft.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/openal.pc
mingw64-openal-soft.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32
mingw-openal-soft.src: W: spelling-error %description -l en_US doppler -> Doppler
mingw-openal-soft.src: W: spelling-error %description -l en_US reverb -> revere, revers, revert
mingw-openal-soft.src: W: spelling-error %description -l en_US multi -> mulch, mufti
3 packages and 0 specfiles checked; 2 errors, 29 warnings.


Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
mingw64-openal-soft.noarch: W: spelling-error %description -l en_US doppler -> Doppler
mingw64-openal-soft.noarch: W: spelling-error %description -l en_US reverb -> revere, revers, revert
mingw64-openal-soft.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti
mingw64-openal-soft.noarch: W: no-documentation
mingw32-openal-soft.noarch: W: spelling-error %description -l en_US doppler -> Doppler
mingw32-openal-soft.noarch: W: spelling-error %description -l en_US reverb -> revere, revers, revert
mingw32-openal-soft.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti
mingw32-openal-soft.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 8 warnings.


==== CONCLUSION ====
NOT YET.  %license COPYING are missing for both subpackages.

Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/ngompa/mingw-openal-soft/mingw-openal-soft.git/plain/mingw-openal-soft.spec?id=8f833d624cb4c3918cc48e8fc2285b3a3fbc4e46

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ngompa/mingw-openal-soft/fedora-rawhide-x86_64/00480465-mingw-openal-soft/mingw-openal-soft-1.17.2-2.fc26.src.rpm

Looks good to me.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mingw-openal-soft

mingw-openal-soft-1.17.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-fe4313378f

mingw-openal-soft-1.17.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8bbf5706c7

mingw-openal-soft-1.17.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8bbf5706c7

mingw-openal-soft-1.17.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-fe4313378f

mingw-openal-soft-1.17.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

mingw-openal-soft-1.17.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.