Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1400261 - Review Request (rename): qrmumps - A multithreaded multifrontal QR solver
Summary: Review Request (rename): qrmumps - A multithreaded multifrontal QR solver
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jerry James
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-30 18:24 UTC by Antonio T. (sagitter)
Modified: 2016-12-23 16:21 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-19 06:01:55 UTC
Type: ---
Embargoed:
loganjerry: fedora-review+


Attachments (Terms of Use)

Description Antonio T. (sagitter) 2016-11-30 18:24:20 UTC
Spec URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps.spec
SRPM URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps-2.0-4.fc25.src.rpm

Description:
qr_mumps is a software package for the solution of sparse,
linear systems on multicore computers.
It implements a direct solution method based on the QR
factorization of the input matrix. Therefore, it is suited
to solving sparse least-squares problems and to computing
the minimum-norm solution of sparse, underdetermined problems.
It can obviously be used for solving square problems in which
case the stability provided by the use of orthogonal transformations
comes at the cost of a higher operation count with respect to solvers
based on, e.g., the LU factorization.
qr_mumps supports real and complex, single or double precision arithmetic.

Fedora Account System Username: sagitter

This package is for Fedora and EPEL7.

Note:

This is a re-review of 'qr_mumps' already packed with the scope of rename the package without 'underscore'.
Guidelines: https://fedoraproject.org/wiki/Package_Renaming_Process

I have set Provides Obsoletes tags:

Provides: qr_mumps = 0:%{version}-%{release}
Obsoletes: qr_mumps < 0:2.0-4

Comment 1 Jerry James 2016-12-03 18:29:41 UTC
I will take this review.

Comment 2 Jerry James 2016-12-03 18:54:16 UTC
This package does not build in mock:

Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.kXF2PG
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf qrmumps-2.0
+ /usr/bin/gzip -dc /builddir/build/SOURCES/qr_mumps-2.0.tgz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd qrmumps-2.0
RPM build errors:
/var/tmp/rpm-tmp.kXF2PG: line 37: cd: qrmumps-2.0: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.kXF2PG (%prep)
    Bad exit status from /var/tmp/rpm-tmp.kXF2PG (%prep)
Child return code was: 1

Comment 3 Antonio T. (sagitter) 2016-12-03 19:02:39 UTC
Spec URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps.spec
SRPM URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps-2.0-4.fc25.src.rpm

Just a little typo.

Comment 4 Jerry James 2016-12-03 19:09:43 UTC
It still fails to build in mock (building for fedora-rawhide-x86_64):

make[1]: Leaving directory '/builddir/build/BUILD/qr_mumps-2.0/build'
~/build/BUILD/qr_mumps-2.0/build/lib ~/build/BUILD/qr_mumps-2.0
+ pushd build/lib
+ gfortran -shared -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -fPIC -Wl,-z,now -Wl,--whole-archive libqrm_common.a -Wl,-no-whole-archive -Wl,--as-needed -L/usr/lib64 -lmetis -lgfortran -lm -lrt -Wl,-soname,libqrm-common.so.2.0 -o libqrm-common.so.2.0
+ gfortran -shared -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -fPIC -Wl,-z,now -Wl,--whole-archive libdqrm.a libqrm_common.a -Wl,-no-whole-archive -L./ -lqrm-common -Wl,--as-needed -L/usr/lib64 -lblas -llapack -lscotch -lscotcherr -lmetis -lgfortran -lm -lrt -Wl,-soname,libdqrm.so.2.0 -o libdqrm.so.2.0
/usr/bin/ld: cannot find -lqrm-common
collect2: error: ld returned 1 exit status

Comment 5 Antonio T. (sagitter) 2016-12-03 19:12:13 UTC
Sorry, let me check again later; something is changed after renaming of libraries.

Comment 7 Jerry James 2016-12-04 01:59:54 UTC
Issues
==============
1. The Source0 URL is not correct.  The webserver returns an HTTP 404 for that
   URL.

2. The license should be LGPLv3+ instead of LGPLv3, as the source files contain
   the "any later version" language.

3. Can make be invoked with %{?_smp_mflags}?

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0:
     http://buttari.perso.enseeiht.fr/qr_mumps/releases/2.0/qr_mumps-2.0.tgz
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: qrmumps-2.0-4.fc26.x86_64.rpm
          qrmumps-devel-2.0-4.fc26.x86_64.rpm
          qrmumps-doc-2.0-4.fc26.noarch.rpm
          qrmumps-debuginfo-2.0-4.fc26.x86_64.rpm
          qrmumps-2.0-4.fc26.src.rpm
qrmumps.x86_64: W: spelling-error Summary(en_US) multithreaded -> multicolored
qrmumps.x86_64: W: spelling-error Summary(en_US) multifrontal -> multinational
qrmumps.x86_64: W: spelling-error %description -l en_US multicore -> multicolored
qrmumps.x86_64: W: spelling-error %description -l en_US underdetermined -> under determined, under-determined, undetermined
qrmumps-devel.x86_64: W: only-non-binary-in-usr-lib
qrmumps-devel.x86_64: W: no-documentation
qrmumps.src: W: spelling-error Summary(en_US) multithreaded -> multicolored
qrmumps.src: W: spelling-error Summary(en_US) multifrontal -> multinational
qrmumps.src: W: spelling-error %description -l en_US multicore -> multicolored
qrmumps.src: W: spelling-error %description -l en_US underdetermined -> under determined, under-determined, undetermined
qrmumps.src: W: invalid-url Source0: http://buttari.perso.enseeiht.fr/qr_mumps/releases/2.0/qr_mumps-2.0.tgz HTTP Error 404: Not Found
5 packages and 0 specfiles checked; 0 errors, 11 warnings.




Rpmlint (debuginfo)
-------------------
Checking: qrmumps-debuginfo-2.0-4.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
qrmumps-devel.x86_64: W: only-non-binary-in-usr-lib
qrmumps-devel.x86_64: W: no-documentation
qrmumps.x86_64: W: spelling-error Summary(en_US) multithreaded -> multicolored
qrmumps.x86_64: W: spelling-error Summary(en_US) multifrontal -> multinational
qrmumps.x86_64: W: spelling-error %description -l en_US multicore -> multicolored
qrmumps.x86_64: W: spelling-error %description -l en_US underdetermined -> under determined, under-determined, undetermined
qrmumps.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdqrm.so.2.0 /lib64/libscotcherr.so.0
qrmumps.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzqrm.so.2.0 /lib64/libscotcherr.so.0
qrmumps.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsqrm.so.2.0 /lib64/libscotcherr.so.0
qrmumps.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libcqrm.so.2.0 /lib64/libscotcherr.so.0
4 packages and 0 specfiles checked; 0 errors, 10 warnings.



Requires
--------
qrmumps-debuginfo (rpmlib, GLIBC filtered):

qrmumps-devel (rpmlib, GLIBC filtered):
    qrmumps(x86-64)

qrmumps (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    gcc-gfortran(x86-64)
    libblas.so.3()(64bit)
    libc.so.6()(64bit)
    libgfortran.so.3()(64bit)
    libgfortran.so.3(GFORTRAN_1.0)(64bit)
    libgfortran.so.3(GFORTRAN_1.4)(64bit)
    liblapack.so.3()(64bit)
    libm.so.6()(64bit)
    libmetis.so.0()(64bit)
    libscotch.so.0()(64bit)
    libscotcherr.so.0()(64bit)
    rtld(GNU_HASH)

qrmumps-doc (rpmlib, GLIBC filtered):



Provides
--------
qrmumps-debuginfo:
    qrmumps-debuginfo
    qrmumps-debuginfo(x86-64)

qrmumps-devel:
    qrmumps-devel
    qrmumps-devel(x86-64)

qrmumps:
    libcqrm.so.2.0()(64bit)
    libdqrm.so.2.0()(64bit)
    libqrm_common.so.2.0()(64bit)
    libsqrm.so.2.0()(64bit)
    libzqrm.so.2.0()(64bit)
    qr_mumps
    qrmumps
    qrmumps(x86-64)

qrmumps-doc:
    qrmumps-doc



Source checksums
----------------
http://www.cise.ufl.edu/research/sparse/MM/vanHeukelum/cage6.tar.gz :
  CHECKSUM(SHA256) this package     : 044d9fdaf462faf044ed57c5856238e80ea57c164914c53f179bb442649792f9
  CHECKSUM(SHA256) upstream package : 044d9fdaf462faf044ed57c5856238e80ea57c164914c53f179bb442649792f9
http://www.cise.ufl.edu/research/sparse/MM/Meszaros/pltexpa.tar.gz :
  CHECKSUM(SHA256) this package     : 69539f891a02b85263c3edb7e5bf401f4706b5459954171b4e43d5224f7a5121
  CHECKSUM(SHA256) upstream package : 69539f891a02b85263c3edb7e5bf401f4706b5459954171b4e43d5224f7a5121
http://www.cise.ufl.edu/research/sparse/MM/Yoshiyasu/image_interp.tar.gz :
  CHECKSUM(SHA256) this package     : c1e02b7f81a6d3dbdb67cd8cbc045985af8af6d4293fbde86a6e12fad6df98c3
  CHECKSUM(SHA256) upstream package : c1e02b7f81a6d3dbdb67cd8cbc045985af8af6d4293fbde86a6e12fad6df98c3


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1400261 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 8 Antonio T. (sagitter) 2016-12-04 11:40:20 UTC
(In reply to Jerry James from comment #7)
> Issues
> ==============
> 1. The Source0 URL is not correct.  The webserver returns an HTTP 404 for
> that
>    URL.
>

This is a private source link provided by upstream directly.
 
> 2. The license should be LGPLv3+ instead of LGPLv3, as the source files
> contain
>    the "any later version" language.
> 

Fixed.

> 3. Can make be invoked with %{?_smp_mflags}?
> 

It's not supported.

Spec URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps.spec
SRPM URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps-2.0-4.fc25.src.rpm

Comment 9 Jerry James 2016-12-04 20:43:09 UTC
(In reply to Antonio Trande from comment #8)
> This is a private source link provided by upstream directly.

If there is no public link for the sources, then Source0 should refer to just the filename, not to a URL.

That's a minor issue.  This package is APPROVED.

Comment 10 Gwyn Ciesla 2016-12-06 18:53:42 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/qrmumps

Comment 11 Fedora Update System 2016-12-06 22:01:25 UTC
qrmumps-2.0-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ec29baa85

Comment 12 Fedora Update System 2016-12-06 22:01:32 UTC
qrmumps-2.0-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b67f3530e0

Comment 13 Fedora Update System 2016-12-06 22:01:37 UTC
qrmumps-2.0-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2036a8c913

Comment 14 Fedora Update System 2016-12-08 04:51:38 UTC
qrmumps-2.0-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2036a8c913

Comment 15 Fedora Update System 2016-12-08 04:55:06 UTC
qrmumps-2.0-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ec29baa85

Comment 16 Fedora Update System 2016-12-08 05:48:23 UTC
qrmumps-2.0-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b67f3530e0

Comment 17 Fedora Update System 2016-12-19 06:01:55 UTC
qrmumps-2.0-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2016-12-19 07:52:28 UTC
qrmumps-2.0-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2016-12-23 16:21:30 UTC
qrmumps-2.0-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.