Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1401337 - Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library
Summary: Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tomas Orsava
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1392089 (view as bug list)
Depends On:
Blocks: IoT 1392090 1393176
TreeView+ depends on / blocked
 
Reported: 2016-12-04 22:28 UTC by Miro Hrončok
Modified: 2017-03-24 18:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-24 18:55:16 UTC
Type: ---
Embargoed:
torsava: fedora-review+


Attachments (Terms of Use)

Description Miro Hrončok 2016-12-04 22:28:53 UTC
Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-zeroconf.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-zeroconf-0.17.6-1.fc25.src.rpm

Description:

A pure Python implementation of multicast DNS service discovery
supporting Bonjour/Avahi.

Fedora Account System Username: churchyard

Comment 1 Tomas Orsava 2016-12-09 15:46:01 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


List of Issues
==============

- There is only one subpackage: python3-zeroconf, and the %python_provide macro used there still defaults to Python 2, therefore the name `python-zeroconf` is not provided by any subpackage.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "LGPL (v2.1 or later)", "Unknown or generated". 8 files have
     unknown license. Detailed output of licensecheck in
     /home/torsava/rpmbuild/SPECS/python-zeroconf/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.4/site-
     packages, /usr/lib/python3.4/site-packages/__pycache__,
     /usr/lib/python3.4
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: python3-zeroconf-0.17.6-1.fc23.noarch.rpm
          python-zeroconf-0.17.6-1.fc23.src.rpm
python3-zeroconf.noarch: W: spelling-error %description -l en_US multicast -> Multics, simulcast
python-zeroconf.src: W: spelling-error %description -l en_US multicast -> Multics, simulcast
2 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
1 packages and 0 specfiles checked; 0 errors, 0 warnings.



Requires
--------
python3-zeroconf (rpmlib, GLIBC filtered):
    python(abi)
    python3-netifaces
    python3-six



Provides
--------
python3-zeroconf:
    python3-zeroconf



Source checksums
----------------
https://github.com/jstasiak/python-zeroconf/archive/0.17.6.tar.gz#/zeroconf-0.17.6.tar.gz :
  CHECKSUM(SHA256) this package     : 11fa4adb2100a1dc2bd0ce390b060334b3b5d886701edb754f7bf938d82d8118
  CHECKSUM(SHA256) upstream package : 11fa4adb2100a1dc2bd0ce390b060334b3b5d886701edb754f7bf938d82d8118


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -rn ../SRPMS/python-zeroconf-0.17.6-1.fc24.src.rpm
Buildroot used: fedora-23-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6



Status: Close but no cigar. :)

Comment 2 Miro Hrončok 2016-12-09 17:48:19 UTC
(In reply to Tomas Orsava from comment #1)
> 
> - There is only one subpackage: python3-zeroconf, and the %python_provide
> macro used there still defaults to Python 2, therefore the name
> `python-zeroconf` is not provided by any subpackage.

How is that an issue? I decided not to include the python2 subpackage because I don't need it. If someone needs it later, i can add it any time.

python-zeroconf not being provided is exactly the result of that.

Comment 3 Tomas Orsava 2016-12-09 18:39:23 UTC
(In reply to Miro Hrončok from comment #2)
> (In reply to Tomas Orsava from comment #1)
> > 
> > - There is only one subpackage: python3-zeroconf, and the %python_provide
> > macro used there still defaults to Python 2, therefore the name
> > `python-zeroconf` is not provided by any subpackage.
> 
> How is that an issue? I decided not to include the python2 subpackage
> because I don't need it. If someone needs it later, i can add it any time.
> 
> python-zeroconf not being provided is exactly the result of that.

Oh, you are absolutely right. My first reaction was to provide the name `python-` by at least one subpackage for user friendliness, but it would be a little confusing to have a Python 3 package named `python-`. Apologies.

Status: Approved!

Comment 4 Gwyn Ciesla 2016-12-12 13:59:18 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-zeroconf

Comment 5 Peter Robinson 2016-12-21 01:31:57 UTC
(In reply to Miro Hrončok from comment #0)
> Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-zeroconf.spec
> SRPM URL:
> https://churchyard.fedorapeople.org/SRPMS/python-zeroconf-0.17.6-1.fc25.src.
> rpm
> 
> Description:
> 
> A pure Python implementation of multicast DNS service discovery
> supporting Bonjour/Avahi.
> 
> Fedora Account System Username: churchyard

Miro: you're suppose search for existing review requests. Bug 1392089 was open a full month before you submitted this.

Comment 6 Peter Robinson 2016-12-21 04:22:24 UTC
*** Bug 1392089 has been marked as a duplicate of this bug. ***

Comment 7 Miro Hrončok 2016-12-21 07:41:52 UTC
I'm very sorry about that :( I normally do that. I'll add probinson as a maintainer, so he can add the python2 package.

Comment 8 Miro Hrončok 2016-12-21 07:52:14 UTC
Adding python2 subpackage myself. Trying in mock first.

Comment 9 Miro Hrončok 2016-12-21 08:04:44 UTC
It's there. Sorry about this once more. Peter, please let me know if I can do a review for you or something as an apology.

Comment 10 Peter Robinson 2016-12-21 09:47:23 UTC
(In reply to Miro Hrončok from comment #9)
> It's there. Sorry about this once more. Peter, please let me know if I can
> do a review for you or something as an apology.

Miro: thanks for the quick fixes/updates it's much appreciated!

Comment 11 Fedora Update System 2017-03-15 12:52:04 UTC
python-zeroconf-0.18.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7ea7818e6e

Comment 12 Fedora Update System 2017-03-16 23:20:30 UTC
python-zeroconf-0.18.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7ea7818e6e

Comment 13 Fedora Update System 2017-03-24 18:55:16 UTC
python-zeroconf-0.18.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.