Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1424015 - opal-prd: FTBFS in rawhide
Summary: opal-prd: FTBFS in rawhide
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: opal-prd
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vasant Hegde
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F26FTBFS
TreeView+ depends on / blocked
 
Reported: 2017-02-17 15:36 UTC by Fedora Release Engineering
Modified: 2017-04-24 04:38 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-24 04:38:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
build.log (99.17 KB, text/plain)
2017-02-17 15:36 UTC, Fedora Release Engineering
no flags Details
root.log (73.94 KB, text/plain)
2017-02-17 15:36 UTC, Fedora Release Engineering
no flags Details
state.log (623 bytes, text/plain)
2017-02-17 15:36 UTC, Fedora Release Engineering
no flags Details
skiboot_bypass_fallthrough.patch (1.85 KB, patch)
2017-02-20 13:03 UTC, Michel Normand
no flags Details | Diff

Description Fedora Release Engineering 2017-02-17 15:36:03 UTC
Your package opal-prd failed to build from source in current rawhide.

https://koji.fedoraproject.org/koji/taskinfo?taskID=17746244

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild

Comment 1 Fedora Release Engineering 2017-02-17 15:36:09 UTC
Created attachment 1253359 [details]
build.log

Comment 2 Fedora Release Engineering 2017-02-17 15:36:13 UTC
Created attachment 1253360 [details]
root.log

Comment 3 Fedora Release Engineering 2017-02-17 15:36:16 UTC
Created attachment 1253361 [details]
state.log

Comment 4 Michel Normand 2017-02-20 11:29:04 UTC
the build.log extract is pointing to a line in skiboot.h
But I do not understand what is wrong with it.

=== extract build.log
gcc        -I/builddir/build/BUILD/skiboot-skiboot-5.2.0/include -Iinclude -MMD -include /builddir/build/BUILD/skiboot-skiboot-5.2.0/include/config.h -I/builddir/build/BUILD/skiboot-skiboot-5.2.0/libfdt -I/builddir/build/BUILD/skiboot-skiboot-5.2.0/libflash -I/builddir/build/BUILD/skiboot-skiboot-5.2.0/libc/include -I/builddir/build/BUILD/skiboot-skiboot-5.2.0 -I/builddir/build/BUILD/skiboot-skiboot-5.2.0/libpore -D__HAVE_LIBPORE__ -D__SKIBOOT__ -nostdinc -isystem /usr/lib/gcc/ppc64le-redhat-linux/7/include -DBITS_PER_LONG=64 -DHAVE_BIG_ENDIAN -ffreestanding -fno-strict-aliasing -fstack-protector-all -pie -mbig-endian -m64 -Wl,--oformat,elf64-powerpc -mabi=elfv1 -std=gnu11 -fstack-protector -fstack-protector-strong -Wjump-misses-init -Wsuggest-attribute=const -Wsuggest-attribute=noreturn -Wstack-usage=1024 -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -Werror-implicit-function-declaration -Wdeclaration-after-statement -Wno-pointer-sign -Wextra -Wno-sign-compare -Wmissing-prototypes -Wmissing-declarations -Wwrite-strings -Wcast-align -Winit-self -Wframe-larger-than=1024 -Werror -Os -ffunction-sections -g -msoft-float -mno-string -mno-multiple -mno-vsx -mno-direct-move -mno-altivec  -c hw/phb3.c -o hw/phb3.o
In file included from hw/p7ioc-phb.c:17:0:
hw/p7ioc-phb.c: In function 'p7ioc_sm_slot_power_off':
/builddir/build/BUILD/skiboot-skiboot-5.2.0/include/skiboot.h:107:31: error: this statement may fall through [-Werror=implicit-fallthrough=]
 #define prlog(l, f, ...) do { _prlog(l, pr_fmt(f), ##__VA_ARGS__); } while(0)
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
=== extract of skiboot.h
void _prlog(int log_level, const char* fmt, ...) __attribute__((format (printf, 2, 3)));
#define prlog(l, f, ...) do { _prlog(l, pr_fmt(f), ##__VA_ARGS__); } while(0)
===

Comment 5 Michel Normand 2017-02-20 13:03:37 UTC
Created attachment 1255678 [details]
skiboot_bypass_fallthrough.patch

my suggested patch added as new attachment

Comment 6 Michel Normand 2017-02-20 13:32:26 UTC
(In reply to Michel Normand from comment #5)
> Created attachment 1255678 [details]
> skiboot_bypass_fallthrough.patch
> 
> my suggested patch added as new attachment

note that similar changes already implemented upstream in main branch.

Comment 7 Michel Normand 2017-02-20 14:59:11 UTC
(In reply to Michel Normand from comment #6)
> (In reply to Michel Normand from comment #5)
> > Created attachment 1255678 [details]
> > skiboot_bypass_fallthrough.patch
> > 
> > my suggested patch added as new attachment
> 
> note that similar changes already implemented upstream in main branch.

and completed scatchbuild with above patch 
https://koji.fedoraproject.org/koji/taskinfo?taskID=17970134

Comment 8 Fedora End Of Life 2017-02-28 11:53:05 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 9 Upstream Release Monitoring 2017-04-19 09:35:06 UTC
hegdevasant's opal-prd-5.5.0-2.fc27 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=881423

Comment 10 Vasant Hegde 2017-04-19 09:40:58 UTC
I've built opal-prd for rawhide as well as for fedora 26.

-Vasant

Comment 11 Vasant Hegde 2017-04-19 09:41:40 UTC
FC 26 build : https://koji.fedoraproject.org/koji/taskinfo?taskID=19076040

Can someone tag this build to next fc26 build?

-Vasant

Comment 12 Vasant Hegde 2017-04-24 04:38:15 UTC
(In reply to Vasant Hegde from comment #11)
> FC 26 build : https://koji.fedoraproject.org/koji/taskinfo?taskID=19076040
> 
> Can someone tag this build to next fc26 build?
> 
> -Vasant

This is handled in #1414489


Closing this bug.

-Vasant


Note You need to log in before you can comment on or make changes to this bug.