1424851 – (xplayer-plparser) Review Request: xplayer-plparser - Xplayer playlist parser

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1424851 (xplayer-plparser) - Review Request: xplayer-plparser - Xplayer playlist parser

Summary: Review Request: xplayer-plparser - Xplayer playlist parser

Keywords:
Status:	CLOSED ERRATA
Alias:	xplayer-plparser
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	All
OS:	Linux
Priority:	medium
Severity:	medium
Target Milestone:	---
Assignee:	leigh scott
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	1359390
TreeView+	depends on / blocked

Reported:	2017-02-19 21:07 UTC by Björn 'besser82' Esser
Modified:	2017-05-10 04:00 UTC (History)
CC List:	2 users (show)
Fixed In Version:
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2017-05-10 03:54:58 UTC
Type:	---
Embargoed:
Dependent Products:
Flags:	leigh123linux: fedora-review+

Attachments	(Terms of Use)

Description Björn 'besser82' Esser 2017-02-19 21:07:57 UTC

Description:

  Xplayer-pl-parser is a simple GObject-based library to
  parse a host of playlist formats, as well as save those.


Koji Build:

  https://koji.fedoraproject.org/koji/taskinfo?taskID=17959739


Issues:

  No known issues.  Some minor complains from rpmlint.


FAS-User:

  besser82


Urls:

  Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/xplayer-plparser.spec
  SRPM URL:  https://pagure.io/besser82/package-review/raw/master/f/xplayer-plparser-1.0.2-0.1.fc26.src.rpm


Thanks for review in advance!

Comment 1 leigh scott 2017-02-21 14:39:29 UTC

.typelib should be moved from -devel to main

/usr/lib64/girepository-1.0/XplayerPlParser-1.0.typelib


.gir should be moved from main to -devel

/usr/share/gir-1.0/XplayerPlParser-1.0.gir


These can be removed as gnome-common requires them

BuildRequires:	autoconf
BuildRequires:	automake
BuildRequires:	gettext


Please change this from

NOCONFIGURE=1 %{_bindir}/gnome-autogen.sh


to (the commands aren't equal and miss a required macro).

NOCONFIGURE=1 ./autogen.sh

Comment 2 Björn 'besser82' Esser 2017-02-21 15:32:08 UTC

(In reply to leigh scott from comment #1)
> .typelib should be moved from -devel to main
> 
> /usr/lib64/girepository-1.0/XplayerPlParser-1.0.typelib
> 
> 
> .gir should be moved from main to -devel
> 
> /usr/share/gir-1.0/XplayerPlParser-1.0.gir

Fixed in updated package.


> These can be removed as gnome-common requires them
> 
> BuildRequires:	autoconf
> BuildRequires:	automake
> BuildRequires:	gettext

Explicit BRs don't hurt, I think…


> Please change this from
> 
> NOCONFIGURE=1 %{_bindir}/gnome-autogen.sh
> 
> 
> to (the commands aren't equal and miss a required macro).
> 
> NOCONFIGURE=1 ./autogen.sh

Well, it doesn't change the result of the build.  Using ./autogen.sh is just needed for out-of-tree builds…

***

Updated package:

Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/xplayer-plparser.spec
  SRPM URL:  https://pagure.io/besser82/package-review/raw/master/f/xplayer-plparser-1.0.2-0.2.fc26.src.rpm

Comment 3 leigh scott 2017-02-21 15:56:36 UTC

Approved

Please fix ownership for (when you import)

%doc %{_datadir}/gtk-doc

change it to

%doc %{_datadir}/gtk-doc/html/%{name}



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "LGPL", "GPL (v2 or later)", "Unknown or generated", "MIT/X11
     (BSD like)", "LGPL (v2 or later)", "FSF All Permissive", "GPL (v2)".
     194 files have unknown license. Detailed output of licensecheck in
     /home/leigh/Desktop/1424851-xplayer-plparser/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/girepository-1.0,
     /usr/share/gir-1.0
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/gtk-doc(gnome-
     desktop3-devel, libgnome-keyring-devel, libsecret-devel, gcr-devel,
     polkit-docs, p11-kit-devel, libpeas-devel, harfbuzz-devel,
     libcanberra-devel, json-glib-devel, clutter-gst3-devel, libgdata-
     devel, gnome-bluetooth-libs-devel, gtk-doc), /usr/share/gtk-doc/html
     (gnome-desktop3-devel, libgnome-keyring-devel, libsecret-devel, gcr-
     devel, polkit-docs, p11-kit-devel, libpeas-devel, harfbuzz-devel,
     libcanberra-devel, json-glib-devel, clutter-gst3-devel, libgdata-
     devel, gnome-bluetooth-libs-devel, gtk-doc)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 163840 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xplayer-
     plparser-devel , xplayer-plparser-doc , xplayer-plparser-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Package should not use obsolete m4 macros
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: xplayer-plparser-1.0.2-0.2.fc26.x86_64.rpm
          xplayer-plparser-devel-1.0.2-0.2.fc26.x86_64.rpm
          xplayer-plparser-doc-1.0.2-0.2.fc26.noarch.rpm
          xplayer-plparser-debuginfo-1.0.2-0.2.fc26.x86_64.rpm
          xplayer-plparser-1.0.2-0.2.fc26.src.rpm
xplayer-plparser.x86_64: W: spelling-error Summary(en_US) playlist -> play list, play-list, pluralist
xplayer-plparser.x86_64: W: spelling-error %description -l en_US playlist -> play list, play-list, pluralist
xplayer-plparser.x86_64: E: incorrect-fsf-address /usr/share/licenses/xplayer-plparser/COPYING.LIB
xplayer-plparser-devel.x86_64: W: only-non-binary-in-usr-lib
xplayer-plparser-devel.x86_64: W: no-documentation
xplayer-plparser-doc.noarch: E: incorrect-fsf-address /usr/share/licenses/xplayer-plparser/COPYING.LIB
xplayer-plparser.src: W: spelling-error Summary(en_US) playlist -> play list, play-list, pluralist
xplayer-plparser.src: W: spelling-error %description -l en_US playlist -> play list, play-list, pluralist
xplayer-plparser.src:101: W: macro-in-%changelog %{_datadir}
5 packages and 0 specfiles checked; 2 errors, 7 warnings.




Rpmlint (debuginfo)
-------------------
Checking: xplayer-plparser-debuginfo-1.0.2-0.2.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
xplayer-plparser-doc.noarch: E: incorrect-fsf-address /usr/share/licenses/xplayer-plparser/COPYING.LIB
xplayer-plparser.x86_64: W: spelling-error Summary(en_US) playlist -> play list, play-list, pluralist
xplayer-plparser.x86_64: W: spelling-error %description -l en_US playlist -> play list, play-list, pluralist
xplayer-plparser.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libxplayer-plparser-mini.so.18.1.0 /lib64/libpthread.so.0
xplayer-plparser.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libxplayer-plparser.so.18.1.0 /lib64/libgthread-2.0.so.0
xplayer-plparser.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libxplayer-plparser.so.18.1.0 /lib64/libdl.so.2
xplayer-plparser.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libxplayer-plparser.so.18.1.0 /lib64/libgpg-error.so.0
xplayer-plparser.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libxplayer-plparser.so.18.1.0 /lib64/libpthread.so.0
xplayer-plparser.x86_64: E: incorrect-fsf-address /usr/share/licenses/xplayer-plparser/COPYING.LIB
xplayer-plparser-devel.x86_64: W: only-non-binary-in-usr-lib
xplayer-plparser-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 2 errors, 9 warnings.



Requires
--------
xplayer-plparser-doc (rpmlib, GLIBC filtered):

xplayer-plparser (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libarchive.so.13()(64bit)
    libc.so.6()(64bit)
    libdl.so.2()(64bit)
    libgcrypt.so.20()(64bit)
    libgcrypt.so.20(GCRYPT_1.6)(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgmime-2.6.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgpg-error.so.0()(64bit)
    libgthread-2.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    libquvi-0.9-0.9.4.so()(64bit)
    libsoup-2.4.so.1()(64bit)
    libxml2.so.2()(64bit)
    libxml2.so.2(LIBXML2_2.4.30)(64bit)
    rtld(GNU_HASH)

xplayer-plparser-debuginfo (rpmlib, GLIBC filtered):

xplayer-plparser-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libxplayer-plparser-mini.so.18()(64bit)
    libxplayer-plparser.so.18()(64bit)
    pkgconfig(gio-2.0)
    pkgconfig(glib-2.0)
    pkgconfig(gmime-2.6)
    pkgconfig(gobject-2.0)
    pkgconfig(gthread-2.0)
    pkgconfig(libxml-2.0)
    xplayer-plparser(x86-64)



Provides
--------
xplayer-plparser-doc:
    xplayer-plparser-doc

xplayer-plparser:
    libxplayer-plparser-mini.so.18()(64bit)
    libxplayer-plparser.so.18()(64bit)
    xplayer-plparser
    xplayer-plparser(x86-64)

xplayer-plparser-debuginfo:
    xplayer-plparser-debuginfo
    xplayer-plparser-debuginfo(x86-64)

xplayer-plparser-devel:
    pkgconfig(xplayer-plparser)
    pkgconfig(xplayer-plparser-mini)
    xplayer-plparser-devel
    xplayer-plparser-devel(x86-64)



Source checksums
----------------
https://github.com/linuxmint/xplayer-plparser/archive/1.0.2.tar.gz#/xplayer-plparser-1.0.2.tar.gz :
  CHECKSUM(SHA256) this package     : 42d5056e6e7c76893882f9df7bb936180be14a525fdc7387026184a64a567fd3
  CHECKSUM(SHA256) upstream package : 42d5056e6e7c76893882f9df7bb936180be14a525fdc7387026184a64a567fd3


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1424851
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Gwyn Ciesla 2017-02-21 22:30:26 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/xplayer-plparser

Comment 5 Fedora Update System 2017-05-07 09:08:36 UTC

xplayer-plparser-1.0.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-590fc86e51

Comment 6 Fedora Update System 2017-05-07 09:08:43 UTC

xplayer-plparser-1.0.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ef33e1ec72

Comment 7 Fedora Update System 2017-05-09 00:45:32 UTC

xplayer-plparser-1.0.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-590fc86e51

Comment 8 Fedora Update System 2017-05-09 06:01:01 UTC

xplayer-plparser-1.0.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ef33e1ec72

Comment 9 Fedora Update System 2017-05-10 03:54:58 UTC

xplayer-plparser-1.0.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2017-05-10 04:00:06 UTC

xplayer-plparser-1.0.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.