This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=18164175

Looks good Tom.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (2 clause)", "Unknown or generated", "BSL (v1.0)". 49
     files have unknown license. Detailed output of licensecheck in
     /home/mk/fedora/1429001-pyosmium/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-osmium , python3-osmium , pyosmium-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[-]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 1433600 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-osmium-2.11.0-1.fc27.x86_64.rpm
          python3-osmium-2.11.0-1.fc27.x86_64.rpm
          pyosmium-debuginfo-2.11.0-1.fc27.x86_64.rpm
          pyosmium-2.11.0-1.fc27.src.rpm
python2-osmium.x86_64: W: spelling-error Summary(en_US) libosmium -> lib osmium, lib-osmium, osmium
python2-osmium.x86_64: W: hidden-file-or-dir /usr/share/doc/python2-osmium/html/.buildinfo
python3-osmium.x86_64: W: spelling-error Summary(en_US) libosmium -> lib osmium, lib-osmium, osmium
python3-osmium.x86_64: W: hidden-file-or-dir /usr/share/doc/python3-osmium/html/.buildinfo
pyosmium.src: W: spelling-error Summary(en_US) libosmium -> lib osmium, lib-osmium, osmium
4 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (debuginfo)
-------------------
Checking: pyosmium-debuginfo-2.11.0-1.fc27.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
python3-osmium.x86_64: W: spelling-error Summary(en_US) libosmium -> lib osmium, lib-osmium, osmium
python3-osmium.x86_64: W: hidden-file-or-dir /usr/share/doc/python3-osmium/html/.buildinfo
python2-osmium.x86_64: W: spelling-error Summary(en_US) libosmium -> lib osmium, lib-osmium, osmium
python2-osmium.x86_64: W: hidden-file-or-dir /usr/share/doc/python2-osmium/html/.buildinfo
3 packages and 0 specfiles checked; 0 errors, 4 warnings.



Requires
--------
python3-osmium (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libboost_python3.so.1.63.0()(64bit)
    libbz2.so.1()(64bit)
    libc.so.6()(64bit)
    libexpat.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libpython3.6m.so.1.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libz.so.1()(64bit)
    libz.so.1(ZLIB_1.2.0)(64bit)
    libz.so.1(ZLIB_1.2.3.5)(64bit)
    python(abi)
    rtld(GNU_HASH)

pyosmium-debuginfo (rpmlib, GLIBC filtered):

python2-osmium (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libboost_python.so.1.63.0()(64bit)
    libbz2.so.1()(64bit)
    libc.so.6()(64bit)
    libexpat.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libz.so.1()(64bit)
    libz.so.1(ZLIB_1.2.0)(64bit)
    libz.so.1(ZLIB_1.2.3.5)(64bit)
    python(abi)
    rtld(GNU_HASH)



Provides
--------
python3-osmium:
    python3-osmium
    python3-osmium(x86-64)
    python3.6dist(osmium)
    python3dist(osmium)

pyosmium-debuginfo:
    pyosmium-debuginfo
    pyosmium-debuginfo(x86-64)

python2-osmium:
    python-osmium
    python-osmium(x86-64)
    python2-osmium
    python2-osmium(x86-64)
    python2.7dist(osmium)
    python2dist(osmium)



Unversioned so-files
--------------------
python2-osmium: /usr/lib64/python2.7/site-packages/osmium/_osmium.so
python2-osmium: /usr/lib64/python2.7/site-packages/osmium/geom.so
python2-osmium: /usr/lib64/python2.7/site-packages/osmium/index.so
python2-osmium: /usr/lib64/python2.7/site-packages/osmium/io.so
python2-osmium: /usr/lib64/python2.7/site-packages/osmium/osm/_osm.so
python2-osmium: /usr/lib64/python2.7/site-packages/osmium/replication/_replication.so
python3-osmium: /usr/lib64/python3.6/site-packages/osmium/_osmium.cpython-36m-x86_64-linux-gnu.so
python3-osmium: /usr/lib64/python3.6/site-packages/osmium/geom.cpython-36m-x86_64-linux-gnu.so
python3-osmium: /usr/lib64/python3.6/site-packages/osmium/index.cpython-36m-x86_64-linux-gnu.so
python3-osmium: /usr/lib64/python3.6/site-packages/osmium/io.cpython-36m-x86_64-linux-gnu.so
python3-osmium: /usr/lib64/python3.6/site-packages/osmium/osm/_osm.cpython-36m-x86_64-linux-gnu.so
python3-osmium: /usr/lib64/python3.6/site-packages/osmium/replication/_replication.cpython-36m-x86_64-linux-gnu.so

Source checksums
----------------
https://github.com/osmcode/pyosmium/archive/v2.11.0/pyosmium-2.11.0.tar.gz :
  CHECKSUM(SHA256) this package     : 22c532a94aa957fc10a9b0107b5dae5a8bff66fe55dd37ecf63d2b517ed59f1f
  CHECKSUM(SHA256) upstream package : 22c532a94aa957fc10a9b0107b5dae5a8bff66fe55dd37ecf63d2b517ed59f1f


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1429001
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Thanks!

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/pyosmium

osmium-tool-1.5.1-1.fc25 pyosmium-2.11.0-1.fc25 libosmium-2.11.0-2.fc25 rapidjson-1.1.0-1.fc25 protozero-1.5.1-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-895f23ba2a

libosmium-2.11.0-2.fc25, osmium-tool-1.5.1-1.fc25, protozero-1.5.1-3.fc25, pyosmium-2.11.0-1.fc25, rapidjson-1.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-895f23ba2a

libosmium-2.11.1-1.fc25 osmium-tool-1.5.1-2.fc25 protozero-1.5.1-3.fc25 pyosmium-2.11.0-2.fc25 rapidjson-1.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-895f23ba2a

libosmium-2.11.1-1.fc25, osmium-tool-1.5.1-2.fc25, protozero-1.5.1-3.fc25, pyosmium-2.11.0-2.fc25, rapidjson-1.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-895f23ba2a

libosmium-2.11.1-1.fc25, osmium-tool-1.5.1-2.fc25, protozero-1.5.1-3.fc25, pyosmium-2.11.0-2.fc25, rapidjson-1.1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.