Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1433756 - Review Request: pyee - A port of node.js's EventEmitter to python
Summary: Review Request: pyee - A port of node.js's EventEmitter to python
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Patrick Uiterwijk
QA Contact: Fedora Extras Quality Assurance
: 1875495 (view as bug list)
Depends On:
Blocks: IoT 1877359
TreeView+ depends on / blocked
Reported: 2017-03-19 20:23 UTC by Peter Robinson
Modified: 2020-10-09 12:10 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2017-04-23 09:52:20 UTC
Type: Bug
puiterwijk: fedora-review+

Attachments (Terms of Use)

Description Peter Robinson 2017-03-19 20:23:04 UTC

A port of node.js's EventEmitter to python


Comment 1 Patrick Uiterwijk 2017-03-19 20:26:25 UTC
I will take this review.

Comment 2 Patrick Uiterwijk 2017-03-19 20:48:56 UTC
This package is APPROVED.
It would be ideal to add a %check with the upstream tests, but the package looks good to me.
Also, the source URL is wrong, but the real one is trivial to find. Please update before you import though, correct one is:

MUST: The package must be named according to the Package Naming Guidelines .

MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . 

MUST: The package must meet the Packaging Guidelines .

MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .

MUST: The License field in the package spec file must match the actual license. [3]

MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %license.[4]

MUST: The spec file must be written in American English. [5]

MUST: The spec file for the package MUST be legible. [6]

MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. 

MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7]

MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.

MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.

MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]

MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10]

MUST: Packages must NOT bundle copies of system libraries.[11]

MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [12]

MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13]

MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)[14]

MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [15]

MUST: Each package must consistently use macros. [16]

MUST: The package must contain code, or permissible content. [17]

MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [18]

MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [18]

MUST: Static libraries must be in a -static package. [19]

MUST: Development files must be in a -devel package. [20]

MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [21]

MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[19]

MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [22]

MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [23]

MUST: All filenames in rpm packages must be valid UTF-8. [24]

Comment 3 Gwyn Ciesla 2017-03-20 13:15:31 UTC
Package request has been approved:

Comment 4 Peter Robinson 2020-10-09 12:10:50 UTC
*** Bug 1875495 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.