Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1433859 - Fedora - Request to add ppc64-diag and its dependency packages as default in Fedora
Summary: Fedora - Request to add ppc64-diag and its dependency packages as default in ...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: ppc64-diag
Version: rawhide
Hardware: ppc64le
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Rafael Fonseca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PPCTracker
TreeView+ depends on / blocked
 
Reported: 2017-03-20 08:01 UTC by IBM Bug Proxy
Modified: 2017-04-23 17:57 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-23 17:57:55 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
IBM Linux Technology Center 143708 0 None None None 2017-03-20 08:01:18 UTC

Description IBM Bug Proxy 2017-03-20 08:01:07 UTC
Comment 1 IBM Bug Proxy 2017-03-20 08:01:14 UTC 
To support the dynamic pci hotplug in guest ppc64-diag and its dependency packages are needed, it would be good to have it provided in default iso image and it would be good to have them installed by default.

We do have ppc64-diag package in fedora .. I would think we can include this in the base installation ..
Comment 2 Dan Horák 2017-03-20 09:13:22 UTC 
A change like this to the Core comps group (https://pagure.io/fedora-comps) is needed

diff --git a/comps-f27.xml.in b/comps-f27.xml.in
index db2c85a..1e9671d 100644
--- a/comps-f27.xml.in
+++ b/comps-f27.xml.in
@@ -719,6 +719,7 @@
       <packagereq type="default">dracut-config-rescue</packagereq>
       <packagereq type="default">firewalld</packagereq>
       <packagereq type="default">NetworkManager</packagereq>
+      <packagereq type="default">ppc64-diag</packagereq>
       <packagereq type="default">ppc64-utils</packagereq>
       <packagereq type="optional">dracut-config-generic</packagereq>
       <packagereq type="optional">initial-setup</packagereq>

The question is whether type should be "default" (user can de-select in installer gui) or "mandatory" (always installed).
Comment 3 Peter Robinson 2017-03-20 09:56:52 UTC 
No, this isn't the way to do this. It's already handled in the lorax templates that generate the installer isos
Comment 4 Peter Robinson 2017-03-20 09:59:33 UTC 
> +      <packagereq type="default">ppc64-diag</packagereq>
>        <packagereq type="default">ppc64-utils</packagereq>

See this:

https://github.com/rhinstaller/lorax/blob/master/share/templates.d/99-generic/runtime-install.tmpl#L53
Comment 5 Dan Horák 2017-03-20 10:35:09 UTC 
The lorax template controls what goes into the installer ISO, but not the system being installed. I guess we need both.
Comment 6 Peter Robinson 2017-03-20 13:12:19 UTC 
(In reply to Dan Horák from comment #5)
> The lorax template controls what goes into the installer ISO, but not the
> system being installed. I guess we need both.

I think for arch dependent installs there's actually somewhere in anaconda/pykickstart/server profile that's better for it. I'll check
Comment 7 Fedora Admin XMLRPC Client 2017-03-21 11:00:20 UTC 
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.
Comment 8 Peter Robinson 2017-04-23 17:57:55 UTC 
PR for comps: https://pagure.io/fedora-comps/pull-request/111
PR for lorax: https://github.com/rhinstaller/lorax/pull/204
Note You need to log in before you can comment on or make changes to this bug.