APPROVED

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v3)", "Unknown or generated". 9 files have unknown
     license. Detailed output of licensecheck in

The outpu of licensecheck is clearly wrong, the only assumption is makes is based
on the contents of the LICENSE file which clearly states the LESSER GPL v3:
GPL (v3)
--------
xmlrunner-1.7.7/LICENSE

Unknown or generated
--------------------
xmlrunner-1.7.7/README.markdown
xmlrunner-1.7.7/release.sh
xmlrunner-1.7.7/setup.cfg
xmlrunner-1.7.7/setup.py
xmlrunner-1.7.7/xmlrunner/__init__.py
xmlrunner-1.7.7/xmlrunner/extra/djangotestrunner.py
xmlrunner-1.7.7/xmlrunner/tests/test_xmlrunner.py
xmlrunner-1.7.7/xmlrunner/version.py
xmlrunner-1.7.7/xmlrunner/xmlrunner.py


[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs must not download any dependencies during the build
     process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-xmlrunner , python3-xmlrunner
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-xmlrunner-1.7.7-1.fc26.noarch.rpm
          python3-xmlrunner-1.7.7-1.fc26.noarch.rpm
          xmlrunner-1.7.7-1.fc26.src.rpm
python2-xmlrunner.noarch: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities
python2-xmlrunner.noarch: W: spelling-error Summary(en_US) xml -> XML, ml, x ml
python2-xmlrunner.noarch: W: spelling-error %description -l en_US Unittest -> Unit test, Unit-test, Unities
python2-xmlrunner.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml
python2-xmlrunner.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities
python3-xmlrunner.noarch: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities
python3-xmlrunner.noarch: W: spelling-error %description -l en_US Unittest -> Unit test, Unit-test, Unities
python3-xmlrunner.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml
python3-xmlrunner.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities
xmlrunner.src: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities
xmlrunner.src: W: spelling-error Summary(en_US) xml -> XML, ml, x ml
xmlrunner.src: W: spelling-error %description -l en_US Unittest -> Unit test, Unit-test, Unities
xmlrunner.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml
xmlrunner.src: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities
3 packages and 0 specfiles checked; 0 errors, 14 warnings.




Rpmlint (installed packages)
----------------------------
python2-xmlrunner.noarch: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities
python2-xmlrunner.noarch: W: spelling-error Summary(en_US) xml -> XML, ml, x ml
python2-xmlrunner.noarch: W: spelling-error %description -l en_US Unittest -> Unit test, Unit-test, Unities
python2-xmlrunner.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml
python2-xmlrunner.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities
python3-xmlrunner.noarch: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities
python3-xmlrunner.noarch: W: spelling-error %description -l en_US Unittest -> Unit test, Unit-test, Unities
python3-xmlrunner.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml
python3-xmlrunner.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities
2 packages and 0 specfiles checked; 0 errors, 9 warnings.



Requires
--------
python2-xmlrunner (rpmlib, GLIBC filtered):
    python(abi)
    python-six
    python2-coverage
    python2-django

python3-xmlrunner (rpmlib, GLIBC filtered):
    python(abi)
    python-six
    python3-coverage
    python3-django



Provides
--------
python2-xmlrunner:
    python-xmlrunner
    python2-xmlrunner
    python2.7dist(xmlrunner)
    python2dist(xmlrunner)

python3-xmlrunner:
    python3-xmlrunner
    python3.6dist(xmlrunner)
    python3dist(xmlrunner)



Source checksums
----------------
https://github.com/pycontribs/xmlrunner/archive/1.7.7.tar.gz :
  CHECKSUM(SHA256) this package     : 66826c78be04c21f73f72d274792c855000b1e7341ce6555a72e16507acb1eda
  CHECKSUM(SHA256) upstream package : 66826c78be04c21f73f72d274792c855000b1e7341ce6555a72e16507acb1eda


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02