Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1457878 (festival-broken) - festival package broken
Summary: festival package broken
Keywords:
Status: CLOSED RAWHIDE
Alias: festival-broken
Product: Fedora
Classification: Fedora
Component: festival
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Bruno Wolff III
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1393019 1423563 1461366 1524776 1551436 (view as bug list)
Depends On:
Blocks: F26FTBFS 1592208
TreeView+ depends on / blocked
 
Reported: 2017-06-01 12:39 UTC by Seb L.
Modified: 2019-10-17 23:01 UTC (History)
24 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-10-17 00:12:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Seb L. 2017-06-01 12:39:56 UTC
Description of problem:
festival package is broken (segfault at startup)

Version-Release number of selected component (if applicable):
1.96-32

How reproducible:
All the time.

Steps to Reproduce:
1. echo hello | text2wave -o /tmp/hello.wav

Actual results:
Crashes instantly, prints "Segmentation fault (core dumped)", no /tmp/hello.wav file created.

Expected results:
No crash, no error message printed and valid /tmp/hello.wav audio file created.


Additional info:

Attempt to read from a NULL pointer, cf. valgrind info:

Invalid read of size 8
   at 0x55371EF: EST_Item::EST_Item(EST_Relation*, EST_Item*) (in /usr/lib64/libestbase.so.1.2.96.1)
   by 0x553D18C: EST_Relation::append(EST_Item*) (in /usr/lib64/libestbase.so.1.2.96.1)
   by 0x4EF409C: add_token(EST_Utterance*, EST_Token&) (in /usr/lib64/libFestival.so.1.96.0)
   by 0x4EF34F2: tts_chunk_stream(EST_TokenStream&, void (*)(EST_Item*), void (*)(obj*), obj*, obj*) (in /usr/lib64/libFestival.so.1.96.0)
   by 0x4EF3A82: tts_file_raw(obj*) (in /usr/lib64/libFestival.so.1.96.0)
   by 0x4EF3D06: tts_file(obj*, obj*) (in /usr/lib64/libFestival.so.1.96.0)
   by 0x51ECB59: leval(obj*, obj*) (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51ECB22: leval(obj*, obj*) (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51EEAC1: ??? (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51ECC3B: leval(obj*, obj*) (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51EE8C2: ??? (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51ECC3B: leval(obj*, obj*) (in /usr/lib64/libestools.so.1.2.96.1)
 Address 0x0 is not stack'd, malloc'd or (recently) free'd


Variant:

$ festival
Festival Speech Synthesis System 1.96:beta July 2004
Copyright (C) University of Edinburgh, 1996-2004. All rights reserved.
For details type `(festival_warranty)'
festival> (SayText "Hello")
Erreur de segmentation (core dumped)

Identical valgrind diagnostic:

Invalid read of size 8
   at 0x55371EF: EST_Item::EST_Item(EST_Relation*, EST_Item*) (in /usr/lib64/libestbase.so.1.2.96.1)
   by 0x553D18C: EST_Relation::append(EST_Item*) (in /usr/lib64/libestbase.so.1.2.96.1)
   by 0x4EF409C: add_token(EST_Utterance*, EST_Token&) (in /usr/lib64/libFestival.so.1.96.0)
   by 0x4EF2E62: FT_Text_Utt(obj*) (in /usr/lib64/libFestival.so.1.96.0)
   by 0x51ECAE6: leval(obj*, obj*) (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51EE838: ??? (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51ECC53: leval(obj*, obj*) (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51EE838: ??? (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51ECC53: leval(obj*, obj*) (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51ED388: leval_args(obj*, obj*) (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51ECC90: leval(obj*, obj*) (in /usr/lib64/libestools.so.1.2.96.1)
   by 0x51ED091: ??? (in /usr/lib64/libestools.so.1.2.96.1)
 Address 0x0 is not stack'd, malloc'd or (recently) free'd


Bug already reported numerous times with Fedora 24 but never with Fedora 25:
  https://bugzilla.redhat.com/show_bug.cgi?id=1336981
  https://bugzilla.redhat.com/show_bug.cgi?id=1349198
  https://bugzilla.redhat.com/show_bug.cgi?id=1359395
  https://bugzilla.redhat.com/show_bug.cgi?id=1370990
  https://bugzilla.redhat.com/show_bug.cgi?id=1393019

Comment 1 Piero Finizio 2017-06-01 21:18:58 UTC
I confirm this bug on Fedora 25 64-bit package festival-1.96-32.fc24


festival> (SayText "test")

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff74281ef in EST_Item::EST_Item(EST_Relation*, EST_Item*) ()
   from /lib64/libestbase.so.1.2.96.1
(gdb) bt
#0  0x00007ffff74281ef in EST_Item::EST_Item(EST_Relation*, EST_Item*) ()
   from /lib64/libestbase.so.1.2.96.1
#1  0x00007ffff742e18d in EST_Relation::append(EST_Item*) ()
   from /lib64/libestbase.so.1.2.96.1
#2  0x00007ffff7b6409d in add_token(EST_Utterance*, EST_Token&) ()
   from /lib64/libFestival.so.1.96.0
#3  0x00007ffff7b62e63 in FT_Text_Utt(obj*) () from /lib64/libFestival.so.1.96.0
#4  0x00007ffff7841ae7 in leval(obj*, obj*) () from /lib64/libestools.so.1.2.96.1
#5  0x00007ffff7843839 in leval_progn(obj**, obj**) ()
   from /lib64/libestools.so.1.2.96.1
#6  0x00007ffff7841c54 in leval(obj*, obj*) () from /lib64/libestools.so.1.2.96.1
#7  0x00007ffff7843839 in leval_progn(obj**, obj**) ()
   from /lib64/libestools.so.1.2.96.1
#8  0x00007ffff7841c54 in leval(obj*, obj*) () from /lib64/libestools.so.1.2.96.1
#9  0x00007ffff7842389 in leval_args(obj*, obj*) ()
   from /lib64/libestools.so.1.2.96.1
#10 0x00007ffff7841c91 in leval(obj*, obj*) () from /lib64/libestools.so.1.2.96.1
#11 0x00007ffff7842092 in repl(repl_hooks*) () from /lib64/libestools.so.1.2.96.1
#12 0x00007ffff7842276 in repl_driver(long, long, repl_hooks*) ()
   from /lib64/libestools.so.1.2.96.1
#13 0x00007ffff7849740 in siod_repl(int) () from /lib64/libestools.so.1.2.96.1
---Type <return> to continue, or q <return> to quit---
#14 0x00000000004028c3 in ?? ()
#15 0x0000000000401809 in main ()

Comment 2 Paul DeStefano 2017-06-02 07:40:26 UTC
Man, i just spend 3 hours trying to install rawhide just to give and that data point here.  All methods failed.

In any case, I was just going to say that it's broken in rawhide, too, right?  Isn't that how this Fedora likes to work?  Report a problem in Rawhide where all development happens?  Then it can stay there until it's fixed and not get aged out?  I don't know, but that's the sense I get over the years.

In any case, it should go at least against F26, right?

Comment 3 Trevor Cordes 2017-06-02 08:40:40 UTC
Sorry, still swamped for the forseeable future so I can't commit to anything new,  :-(  someone else will have to do it for now.

Comment 4 Matthew Miller 2017-06-02 13:13:32 UTC
*** Bug 1443271 has been marked as a duplicate of this bug. ***

Comment 5 Matthew Miller 2017-06-02 13:13:50 UTC
*** Bug 1393019 has been marked as a duplicate of this bug. ***

Comment 6 Matthew Miller 2017-06-02 13:15:11 UTC
(In reply to Paul DeStefano from comment #2)
> In any case, it should go at least against F26, right?

Yeah, it's very thoroughly broken across all releases. Moving it up to Rawhide.

Comment 7 Jaroslav Škarvada 2017-06-02 13:27:06 UTC
Short-term workaround in bug 1393019 comment 2.

Comment 8 Matthew Miller 2017-06-02 13:34:45 UTC
I'll apply the CXXFLAGS short-term fix -- thanks.

Long term, I think this package should be completely deconstructed and built as several packages, with separate speech_tools and festival packages, to reflect the upstream.

Comment 9 Gary Sprang 2017-06-03 19:14:31 UTC
Hi,
I compiled and ran this package... 

http://tts.speech.cs.cmu.edu/awb/for_gcc6/

...on FC25, no problems.  I will ping Alan Black to see if he has a new release ready yet.

-Gary

Comment 10 Jan Kurik 2017-08-15 07:09:17 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle.
Changing version to '27'.

Comment 11 Nick Lee 2017-10-13 17:00:06 UTC
I confirm this bug on fc27.x86_64

Comment 12 Patrick Stanistreet 2018-01-23 00:33:28 UTC
http://festvox.org/packed/festival/2.5/

I tested these packages on fedora 27 and
the basic tests work for me.   ie --tts  and SayText

Comment 13 Matthew Miller 2018-01-23 12:32:55 UTC
Yeah, this basically just needs someone to do the work of taking the ancient packages in Fedora and updating them.

Comment 14 Matthew Miller 2018-03-05 08:13:17 UTC
*** Bug 1423563 has been marked as a duplicate of this bug. ***

Comment 15 Matthew Miller 2018-03-05 08:13:34 UTC
*** Bug 1461366 has been marked as a duplicate of this bug. ***

Comment 16 Matthew Miller 2018-03-05 08:13:48 UTC
*** Bug 1514856 has been marked as a duplicate of this bug. ***

Comment 17 Matthew Miller 2018-03-05 08:13:55 UTC
*** Bug 1524776 has been marked as a duplicate of this bug. ***

Comment 18 Matthew Miller 2018-03-05 08:14:04 UTC
*** Bug 1551436 has been marked as a duplicate of this bug. ***

Comment 19 W. Michael Petullo 2018-07-22 20:17:32 UTC
I made a first pass at updating the Festival package. There are a number of things left to do, and I dropped all of the patches at this point. My aim is to return the features provided by the patches a bit at a time. I tried to list the things I skipped past in the changelog entry.

SRPM: https://www.flyn.org/SRPMS/festival-2.5.0-1.fc28.src.rpm
Spec: https://www.flyn.org/SRPMS/festival.spec

Comment 20 jamie 2018-07-22 21:00:50 UTC
I will test this on FC27 if you make binaries(or even a source RPM) for that platform.

Comment 21 W. Michael Petullo 2018-07-22 23:14:48 UTC
Some further changes:

- Set soname
- Place audsp where festival can find it
- Configure festival to use pulseaudio

SRPM: https://www.flyn.org/SRPMS/festival-2.5.0-2.fc28.src.rpm
Spec: https://www.flyn.org/SRPMS/festival.spec

Comment 22 Matthew Miller 2018-07-30 11:27:39 UTC
Michael -- I missed your update as I was on vacation. Can you take a look at https://fedoraproject.org/wiki/Changes/Update_festival_to_2.5 and coordinate with  Lukáš?

Comment 23 Lukáš Tyrychtr 2018-07-30 12:26:26 UTC
Just to add, i already have a successful review for speech tools, see bug 1592220 and a copr at https://copr.fedorainfracloud.org/coprs/tyrylu/festival-reborn/, you can get to the specs, they're at pagure under the same names. Some coordination would be appreciated, because getting the 2.5 branch of Festival to the repository should really be done.

Comment 24 W. Michael Petullo 2018-08-28 23:36:57 UTC
I have adjusted the festival to make use of the separate package proposed in the following report:

    https://bugzilla.redhat.com/show_bug.cgi?id=1592220

The new files:

SRPM: https://www.flyn.org/SRPMS/festival-2.5.0-3.fc28.src.rpm
Spec: https://www.flyn.org/SRPMS/festival.spec

There is presently a problem with the build, and I am not yet sure whether this is a problem in speech-tools or festival.spec. Here is the error:

+ make EST=/usr/lib64/speech_tools FTLIBDIR=/usr/share/festival/lib 'CFLAGS=-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC' 'CXXFLAGS=-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC'
Check system type
../config/common_make_rules:67: ../../speech_tools/config/rules/common_make_rules.mak: No such file or directory
make: *** No rule to make target '../../speech_tools/config/rules/common_make_rules.mak'.  Stop.
/usr/lib64/speech_tools/config/rules/modules.mak:133: config/modincludes.inc: No such file or directory
make: *** No rule to make target 'config/modincludes.inc'.  Stop.
error: Bad exit status from /tmp/rpm-tmp.Y8O3HR (%build)

This appears related to the definition on EST at line 336 of festival.spec. This is necessary for the build process to find $(EST)/config/rules/top_level.mak, but subsequent recursive includes somehow malfunction.

Comment 25 Lukáš Tyrychtr 2018-08-29 08:05:17 UTC
Hi.
For some reason i still see the definitions of %package speechtools-libs in the spec (maybe the URL is incorrect)? For some reason, when setting EST from outside, and also when it was set using another variable in the config file, it did the same things for me, see https://pagure.io/festival for the hacks to make this work (note that it currently does not build against the version of speech-tools which will enter the main repositories shortly, or after fixing it it does, i didn't try yet).

Comment 26 Zbigniew Jędrzejewski-Szmek 2018-08-29 08:40:06 UTC
Various links in the specfile above return 404, http://festvox.org/packed/festival/2.5.0/ doesn't exist.

> Requires(post): /sbin/ldconfig
> Requires(postun): /sbin/ldconfig
Not needed anymore. See https://bugzilla.redhat.com/show_bug.cgi?id=1380878.

I think the problem is on the festival side. EST is overridden in ./config/config. Typical case of "Let's design our own custom build system. Hmmm, let's use recursive make. WCGW?":

config/common_make_rules:67: EST=/usr/lib64/speech_tools
../config/common_make_rules:67: EST=../../speech_tools
../config/common_make_rules:68: ../../speech_tools/config/rules/common_make_rules.mak: No such file or directory

Comment 27 Lukáš Tyrychtr 2018-08-29 08:59:47 UTC
Yes, i also disliked this build system. :) The links work without the .0 in the url.

Comment 28 W. Michael Petullo 2018-08-30 02:06:26 UTC
Builds again. Some further changes:

- Do not explicitly run ldconfig
- Remove speechtools definitions
- Make use of system-installed speech-tools
- BuildRequire speech-tools-libs-static
- Fix some URLs
- Set debug_package to null; see comment at top
- Set LIBDIR on make
- Create $RPM_BUILD_ROOT%{_libdir} before make install

SRPM: https://www.flyn.org/SRPMS/festival-2.5.0-4.fc28.src.rpm
Spec: https://www.flyn.org/SRPMS/festival.spec

Comment 29 Lukáš Tyrychtr 2018-08-30 06:49:12 UTC
It's good to hear. To be more compatible with my plans for festival in Fedora (some czech voices, easier Orca integration etc.), could you please take look at https://pagure.io/festival/tree/master and maybe incorporate the systemd service and the filesistem standard patch? Its purpose is to make the paths more logical (e. g. system configuration in /etc, not somewhere in /usr, and other minor things). The patch is largely based on the debian's one, so you may have a look there, i suppose you used the pulseaudio patch from there and need a

Comment 30 Lukáš Tyrychtr 2018-08-30 06:54:50 UTC
Sorry for the broken last comment, but just a question, am i right when i suppose that your pulseaudio support patch needs the corresponding one in speech-tools as well?

Comment 31 Lukáš Tyrychtr 2018-08-30 09:24:00 UTC
Speech-tools has a rawhide build now.

Comment 32 Zbigniew Jędrzejewski-Szmek 2018-08-30 10:23:23 UTC
Lukáš, please build for F29 too.

Comment 33 Lukáš Tyrychtr 2018-08-30 12:36:59 UTC
I would gladly do so. Unfortunately once again the unability to push a fxx branch appeared, so i am just reporting it to fedora-infrastructure and will do the build as soon as someone responds (it is very likely once again some broken acl or something like that).

Comment 34 Zbigniew Jędrzejewski-Szmek 2018-08-30 12:40:35 UTC
Did you run 'fedpkg --release master --module-name speech-tools request-branch f29' ?

Comment 35 Lukáš Tyrychtr 2018-08-30 12:46:17 UTC
Thank you, that will be it.

Comment 36 Lukáš Tyrychtr 2018-08-30 14:19:28 UTC
Alright, speech-tools was submitted as an update to f29 (unfortunately we crossed the bothi activation date by some margin, so this longer route).

Comment 37 Zbigniew Jędrzejewski-Szmek 2018-08-30 14:50:53 UTC
Please also create a buildroot override so that the updated festival package can be built against speech-tools. See https://fedoraproject.org/wiki/Bodhi/BuildRootOverrides.

Comment 38 Lukáš Tyrychtr 2018-08-30 17:27:47 UTC
I'll do that after i fix some little details in the package and make sure that bodhi has the correct builds.

Comment 39 Lukáš Tyrychtr 2018-08-31 07:14:39 UTC
Buildroot override has benn created, just so you know.

Comment 40 Zbigniew Jędrzejewski-Szmek 2018-09-06 16:33:44 UTC
What's the status here? Can the updated festival package be built for F29?

Comment 41 Lukáš Tyrychtr 2018-09-06 17:24:49 UTC
I was today wondering the same thing and wrote an email to Michael asking about the status. I could probably just go with the pulseaudio patch and post my festival package, but i did not want to just ignore his work in this way. How long would you wait before going with this solution?

Comment 42 W. Michael Petullo 2018-09-07 01:31:57 UTC
More changes:

- Patch to use more reasonable install locations
- Provide systemd service file

This package was pretty crufty to begin with, so someone might want to do a top-down review. I would not be offended if we shifted to Lukáš's work---I was just trying to get things moving.

This is what I have time for tonight. The following is broken:

$ festival --tts
Initialization file /usr/share/festival/init.scm not found
SIOD ERROR: unbound variable : tts

Packaging software with non-standard build systems is not fun.

SRPM: https://www.flyn.org/SRPMS/festival-2.5.0-4.fc28.src.rpm
Spec: https://www.flyn.org/SRPMS/festival.spec

Comment 43 W. Michael Petullo 2018-09-07 01:33:00 UTC
Ignore previous.


More changes:

- Patch to use more reasonable install locations
- Provide systemd service file

This package was pretty crufty to begin with, so someone might want to do a top-down review. I would not be offended if we shifted to Lukáš's work---I was just trying to get things moving.

This is what I have time for tonight. The following is broken:

$ festival --tts
Initialization file /usr/share/festival/init.scm not found
SIOD ERROR: unbound variable : tts

Packaging software with non-standard build systems is not fun.

SRPM: https://www.flyn.org/SRPMS/festival-2.5.0-5.fc28.src.rpm
Spec: https://www.flyn.org/SRPMS/festival.spec

Comment 44 Lukáš Tyrychtr 2018-09-07 08:08:29 UTC
Hello. You're basically now where i was, plus you have the pulseaudio patch. Did you test the pulseaudio patch build with my speech-tools builds, or do they require some similar patch as well, i saw one in the Debian's packaging. I agree, packaging this software is no easy task and the workarounds are not something anyone would want to like. What about, using once again an ugly patch, moving the init file to the sysconf dir? Now, if you want to do a system wide customization, you have to edit a file in /usr/share, which is not something arbitrary user expects. See this patch: https://pagure.io/festival/raw/master/f/siteinit.patch for inspiration.

Comment 45 W. Michael Petullo 2018-09-09 18:00:39 UTC
More changes:

- Apply siteinit patch
- Drop lib from %{_datadir}/festival/lib
- Move audsp
- Drop email_filter

Running "festival --tts" works fine even though I have not applied a pulseaudio patch to speech-tools.

SRPM: https://www.flyn.org/SRPMS/festival-2.5.0-6.fc28.src.rpm
Spec: https://www.flyn.org/SRPMS/festival.spec

Comment 46 Lukáš Tyrychtr 2018-09-10 07:41:20 UTC
Alright. What about getting it reviewed? Now, it seems, you are at the same place as i was, plus the pulseaudio patch.

Comment 47 Zbigniew Jędrzejewski-Szmek 2018-09-10 11:37:47 UTC
Missing:
BR: gcc
BR: gcc-c++
BR: alsa-lib-devel

Why '%define festivalversion 2.5.0'? Just put the version in Version:, and use %version to refer to this string. This makes it easier for anyone looking at this spec file see what is going on, without having to look for the definition of this custom macro.

Drop "Group:" [https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]

Don't use %define [https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define]

I'd move the use of %{systemd_requires} below BuildRequires: systemd, since that package provides that macro (it doesn't matter for rpm, but might be easier for a human reader).

> #Ideally, this would be a "suggests" instead of a hard requirement.
Why not use Recommends: then?

> Requires(post): systemd-units systemd-sysv
> Requires(preun): systemd-units
> Requires(postun): systemd-units
Drop this, the macro above is enough.

Maybe use %autosetup to get rid of all the manual %patch invocations?

> pushd lib/dicts/cmu
>   make
> popd
Just 'make -C lib/dicts/cmu'.

> cp -a src/lib/libFestival.a $RPM_BUILD_ROOT%{_libdir}
Is the static library really needed? [https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries]

> %post
> /sbin/ldconfig
ldconfig calls are not needed anymore.

> %doc COPYING
→ %license ...

Comment 48 Zbigniew Jędrzejewski-Szmek 2018-09-11 07:52:15 UTC
There is no version requirement on the festvox-* packages. It's safer to require the same version, so the packages are upgraded always in lockstep. If you are sure it it OK to use older/newer festvox-* packages with some festival version, that this is not needed.

I didn't test the server, but festival, saytime, text2wave all seem to work fine.

Comment 49 Zbigniew Jędrzejewski-Szmek 2018-11-02 16:42:30 UTC
Hmm, any progress here?

Comment 50 Ben Cotton 2018-11-27 13:41:06 UTC
This message is a reminder that Fedora 27 is nearing its end of life.
On 2018-Nov-30  Fedora will stop maintaining and issuing updates for
Fedora 27. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora  'version' of '27'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 27 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 51 Lukáš Tyrychtr 2018-11-27 17:07:31 UTC
By the way, any progress?

Comment 52 Matthew Miller 2018-11-27 17:26:29 UTC
(In reply to Lukáš Tyrychtr from comment #51)
> By the way, any progress?

Lukáš it looks from comment #49 that Zbigniew is waiting on _you_. :)

Comment 53 Lukáš Tyrychtr 2019-01-10 19:47:55 UTC
Any progress on sponsorship etc.? Or should i go forward with my festival package (basically the current state of this one minus the pulseaudio patch, which could be added simply enough)?

Comment 54 Zbigniew Jędrzejewski-Szmek 2019-01-10 20:50:17 UTC
Hmm, unless I'm missing something, the sponsorship process is all done and you have full packager rights.

There are various comments about the festival package update, e.g. see comment #47 above.
Somebody needs to integrate those comments and update festival and rebuild...

Comment 55 Lukáš Tyrychtr 2019-01-10 20:52:24 UTC
That's correct. I was just wondering whether Michael will finish this or not, of course, i could finish it myself.

Comment 56 W. Michael Petullo 2019-01-11 01:03:52 UTC
I think we have both advanced this, but I have been swamped lately. I doubt I will get to this over this weekend, so you are free to take it if you have the time.

Comment 57 Lukáš Tyrychtr 2019-01-11 01:06:24 UTC
I doubt that i'll manage it over the weekend myself, because of the university exams, which are, maybe unfortunately, but yes, more important than this. But, you are further, likely only by the pulseaudio patch, but you are. :-)

Comment 58 W. Michael Petullo 2019-01-27 22:21:32 UTC
More changes:

- Add more BuildRequires
- Remove use of festivalversion
- Drop Group:
- Replace define with global
- Reorder BuildRequires
- Remove deprecated post, preun, and postun statements
- Remove verbose pushd use
- Do not explicitly call ldconfig
- Label COPYING properly

SRPM: https://www.flyn.org/SRPMS/festival-2.5.0-7.fc29.src.rpm
Spec: https://www.flyn.org/SRPMS/festival.spec

I would like to propose postponing the other suggestions from comment #47 because they follow from things inherited from the existing package.

Comment 59 Ben Cotton 2019-02-19 17:12:11 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 30 development cycle.
Changing version to '30.

Comment 60 bug.report.tracker 2019-05-13 17:12:53 UTC
Thanks W. Michael Petullo and everybody involved in the development.
I've been able to build festival 2.5 with no problems on x86_64 Fedora 30, and it works!

While v1.96 binary still crashes, and compilation from src rpm fails at the beginning
with lots of errors.

I have a couple of questions though.

On the older fedora with festival 1.xx, I use voice_nitech_us_rms_arctic_hts as default voice.
I don't seem to find the same voice in version 2.5. However, "voice_cmu_us_rms_cg" in v2.5
sounds a lot like "voice_nitech_us_rms_arctic_hts" in 1.xx. Did the voice names change?

The other thing is that the older version used to be a bit faster, while version 2.5
eats up 100% CPU while synthesizing speech. Is it expected behaviour?

Thanks,
V.

Comment 61 Lukáš Tyrychtr 2019-05-13 22:42:35 UTC
I am afraid that the voices aren't just differently named, i remember some potential license issues with the hts voices... But i didn't try any 1.2 voices, so i can't comment reliably enough.
Samething similar is also valid for the CPU usage concerns. They might be valid, very likely dependent on the voice used.

Comment 62 bug.report.tracker 2019-05-14 02:12:23 UTC
(In reply to Lukáš Tyrychtr from comment #61)
> I am afraid that the voices aren't just differently named, i remember some
> potential license issues with the hts voices... But i didn't try any 1.2
> voices, so i can't comment reliably enough.
> Samething similar is also valid for the CPU usage concerns. They might be
> valid, very likely dependent on the voice used.

Thank you for the clarification.

Just another couple of nitpicks here.

According to the spec file, festival-2.5.0-7 depends on festvox-slt-arctic-hts package.
I used the following command to install festival which I had built from source:
dnf install ./RPMS/x86_64/festival-2.5.0-7.fc30.x86_64.rpm

Since no festvox-slt-arctic-hts version is implied in the spec, and festvox-slt-arctic-hts-2.5.0-7.fc30.noarch.rpm
was not listed in the command line, dnf silently downloaded and installed festvox-slt-arctic-hts-0.20061229-39.fc29.noarch.rpm,
which is needed for version 1.96.

While we have both (incompatible) festival versions available, I think, we might need
to set version requirements explicitly in the spec file to avoid this kind of issues.

BTW, festival does not really seem to depend on the festvox-slt-arctic-hts package.
Looks like it's just been chosen the default voice for some reason.
Do we really need to force it, even if people prefer other voices?

Thanks,
V.

Comment 63 Zbigniew Jędrzejewski-Szmek 2019-06-07 09:10:22 UTC
Do you need any help? Is there anything that could be done to move this along?

Comment 64 Lukáš Tyrychtr 2019-06-07 09:52:39 UTC
Probably nothing you can help with, but Michael going for review with the festival package would help a lot.

Comment 65 W. Michael Petullo 2019-10-13 15:51:34 UTC
In response to comment #62, what do you mean "while we have both (incompatible) festival versions available"? The version proposed here should replace 1.96, right?

Festival was retired:

    https://bugzilla.redhat.com/show_bug.cgi?id=1674883

I have asked to be assigned the new owner of the festival package, and I intend to bring it out of retirement with the new version first proposed here:

    https://bugzilla.redhat.com/show_bug.cgi?id=1761236

Comment 66 W. Michael Petullo 2019-10-17 00:12:04 UTC
See https://bugzilla.redhat.com/show_bug.cgi?id=1761236.

Comment 67 bug.report.tracker 2019-10-17 22:39:54 UTC
(In reply to W. Michael Petullo from comment #65)
> In response to comment #62, what do you mean "while we have both
> (incompatible) festival versions available"? The version proposed here
> should replace 1.96, right?

When I wrote that comment there was both festival versions available, and there
was estvox-slt-arctic-hts-0.20061229-39.fc29.noarch (v1.96) package available as well.
Looks like it has been removed since. But I still see some of the 1.96 packages remaining.
For example, "dnf info festival-lib festival-devel" shows the following:

Available Packages
Name         : festival-lib
Version      : 1.96
Release      : 39.fc29
Architecture : i686
Size         : 436 k
Source       : festival-1.96-39.fc29.src.rpm
Repository   : fedora
Summary      : Library for the Festival speech synthesis system
URL          : http://www.cstr.ed.ac.uk/projects/festival/
License      : MIT and GPL+ and TCL
Description  : The shared library used by the Festival text-to-speech and speech synthesis
             : system.

Available Packages
Name         : festival-devel
Version      : 1.96
Release      : 39.fc29
Architecture : i686
Size         : 18 k
Source       : festival-1.96-39.fc29.src.rpm
Repository   : fedora
Summary      : Development files for the Festival speech synthesis system
URL          : http://www.cstr.ed.ac.uk/projects/festival/
License      : MIT and GPL+ and TCL
Description  : Development files for the Festival speech synthesis system. Install
             : festival-devel if you want to use Festival's capabilities from within your
             : own programs, or if you intend to compile other programs using it. Note that
             : you can also interface with Festival in via the shell or with BSD sockets.

> 
> Festival was retired:
> 
>     https://bugzilla.redhat.com/show_bug.cgi?id=1674883
> 
> I have asked to be assigned the new owner of the festival package, and I
> intend to bring it out of retirement with the new version first proposed
> here:
> 
>     https://bugzilla.redhat.com/show_bug.cgi?id=1761236

Thanks,
V.

Comment 68 W. Michael Petullo 2019-10-17 23:01:08 UTC
See the latest festival builds at https://koji.fedoraproject.org. It will take some time to get them into the release updates.


Note You need to log in before you can comment on or make changes to this bug.