Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1465335 - Review Request: python-asn1crypto - Fast Python ASN.1 parser and serializer
Summary: Review Request: python-asn1crypto - Fast Python ASN.1 parser and serializer
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nathaniel McCallum
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-27 09:08 UTC by Christian Heimes
Modified: 2017-09-19 15:20 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-07 17:21:02 UTC
Type: ---
Embargoed:
npmccallum: fedora-review+


Attachments (Terms of Use)

Description Christian Heimes 2017-06-27 09:08:35 UTC
Spec URL: https://fedorapeople.org/~cheimes/python-asn1crypto/python-asn1crypto.spec
SRPM URL: https://fedorapeople.org/~cheimes/python-asn1crypto/python-asn1crypto-0.22.0-1.fc26.src.rpm
Description: Fast ASN.1 parser and serializer with definitions for private keys, public keys, certificates, CRL, OCSP, CMS, PKCS#3, PKCS#7, PKCS#8, PKCS#12, PKCS#5, X.509 and TSP.
Fedora Account System Username: cheimes

asn1crypto is a new dependency for python-cryptography 1.8.0, https://cryptography.readthedocs.io/en/latest/changelog/#id4

Comment 1 Nathaniel McCallum 2017-06-27 13:59:21 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[-]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[-]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[?]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-asn1crypto-0.22.0-1.fc25.noarch.rpm
          python3-asn1crypto-0.22.0-1.fc25.noarch.rpm
          python-asn1crypto-0.22.0-1.fc25.src.rpm
python2-asn1crypto.noarch: W: spelling-error Summary(en_US) serializer -> serialize, serializes, serialized
python2-asn1crypto.noarch: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
python2-asn1crypto.noarch: W: no-documentation
python3-asn1crypto.noarch: W: spelling-error Summary(en_US) serializer -> serialize, serializes, serialized
python3-asn1crypto.noarch: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
python3-asn1crypto.noarch: W: no-documentation
python-asn1crypto.src: W: spelling-error Summary(en_US) serializer -> serialize, serializes, serialized
python-asn1crypto.src: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
python-asn1crypto.src:63: W: macro-in-comment %{__python2}
python-asn1crypto.src:64: W: macro-in-comment %{__python3}
3 packages and 0 specfiles checked; 0 errors, 10 warnings.




Rpmlint (installed packages)
----------------------------
python3-asn1crypto.noarch: W: spelling-error Summary(en_US) serializer -> serialize, serializes, serialized
python3-asn1crypto.noarch: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
python3-asn1crypto.noarch: W: no-documentation
python2-asn1crypto.noarch: W: spelling-error Summary(en_US) serializer -> serialize, serializes, serialized
python2-asn1crypto.noarch: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized
python2-asn1crypto.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 6 warnings.



Requires
--------
python3-asn1crypto (rpmlib, GLIBC filtered):
    python(abi)

python2-asn1crypto (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python3-asn1crypto:
    python3-asn1crypto
    python3.5dist(asn1crypto)
    python3dist(asn1crypto)

python2-asn1crypto:
    python-asn1crypto
    python2-asn1crypto
    python2.7dist(asn1crypto)
    python2dist(asn1crypto)



Source checksums
----------------
https://files.pythonhosted.org/packages/source/a/asn1crypto/asn1crypto-0.22.0.tar.gz :
  CHECKSUM(SHA256) this package     : cbbadd640d3165ab24b06ef25d1dca09a3441611ac15f6a6b452474fdf0aed1a
  CHECKSUM(SHA256) upstream package : cbbadd640d3165ab24b06ef25d1dca09a3441611ac15f6a6b452474fdf0aed1a

Comment 2 Nathaniel McCallum 2017-06-27 14:01:06 UTC
Everything looks good to me. However, you should contact upstream and propose that they distribute the license as a separate file (or perhaps even submit a PR with the license file).

Comment 3 Gwyn Ciesla 2017-06-27 15:11:31 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-asn1crypto

Comment 4 Fedora Update System 2017-06-27 19:44:43 UTC
python-asn1crypto-0.22.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bff7476f05

Comment 5 Christian Heimes 2017-06-27 19:56:49 UTC
Thank Gwyn!

Nathaniel, I have build the package for rawhide, f26, f25 and f24, https://koji.fedoraproject.org/koji/packageinfo?packageID=24330212

Upstream has open issues for LICENSE https://github.com/wbond/asn1crypto/issues/58 and tests https://github.com/wbond/asn1crypto/issues/59

Comment 6 Fedora Update System 2017-06-28 19:20:25 UTC
python-asn1crypto-0.22.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-bff7476f05

Comment 7 Fedora Update System 2017-06-28 21:51:19 UTC
python-asn1crypto-0.22.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e38fabae68

Comment 8 Fedora Update System 2017-06-28 21:53:08 UTC
python-asn1crypto-0.22.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d8f8656eac

Comment 9 Fedora Update System 2017-08-04 09:57:58 UTC
python-cryptography-vectors-2.0.2-1.fc26 python-cryptography-2.0.2-1.fc26 python-asn1crypto-0.22.0-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-02bf9ee236

Comment 10 Fedora Update System 2017-08-05 02:21:17 UTC
python-asn1crypto-0.22.0-4.fc26, python-cryptography-2.0.2-1.fc26, python-cryptography-vectors-2.0.2-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-02bf9ee236

Comment 11 Fedora Update System 2017-08-07 17:21:02 UTC
python-asn1crypto-0.22.0-4.fc26, python-cryptography-2.0.2-1.fc26, python-cryptography-vectors-2.0.2-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2017-09-19 03:21:26 UTC
python-asn1crypto-0.22.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2017-09-19 15:20:57 UTC
python-asn1crypto-0.22.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.