> Rpmlint
> -------
> Checking: dtksettings-0.1.7-1.git32225b9.fc25.x86_64.rpm
>           dtksettings-devel-0.1.7-1.git32225b9.fc25.x86_64.rpm
>           dtksettings-debuginfo-0.1.7-1.git32225b9.fc25.x86_64.rpm
>           dtksettings-0.1.7-1.git32225b9.fc25.src.rpm
> dtksettings.x86_64: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure
> dtksettings.x86_64: W: spelling-error Summary(en_US) json -> son, j son
> dtksettings.x86_64: W: name-repeated-in-summary C DtkSettings
> dtksettings.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
> dtksettings.x86_64: W: spelling-error %description -l en_US json -> son, j son
> dtksettings.x86_64: E: library-without-ldconfig-postin /usr/lib64/libdtksettings.so.1.0.0
> dtksettings.x86_64: E: library-without-ldconfig-postun /usr/lib64/libdtksettings.so.1.0.0
> dtksettings.x86_64: E: library-without-ldconfig-postin /usr/lib64/libdtksettingsview.so.1.0.0
> dtksettings.x86_64: E: library-without-ldconfig-postun /usr/lib64/libdtksettingsview.so.1.0.0

You should add ldconfig, something like
%post -n %{name} -p /sbin/ldconfig

> dtksettings.x86_64: W: no-manual-page-for-binary dtk-settings-tool
> dtksettings-devel.x86_64: W: only-non-binary-in-usr-lib
> dtksettings-devel.x86_64: W: no-documentation
> dtksettings.src: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure
> dtksettings.src: W: spelling-error Summary(en_US) json -> son, j son
> dtksettings.src: W: name-repeated-in-summary C DtkSettings
> dtksettings.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
> dtksettings.src: W: spelling-error %description -l en_US json -> son, j son
> 4 packages and 0 specfiles checked; 4 errors, 13 warnings.

I somehow uploaded an old version of my spec file. Sorry for that!

Updated:

Spec URL: https://blog.felixc.at/rpms/dtksettings/dtksettings.spec
SRPM URL: https://blog.felixc.at/rpms/dtksettings/dtksettings-0.1.7-1.git32225b9.fc25.src.rpm

> %define  debug_package %{nil}
Why not generating debug_package? If there is a clear reason, please add comment. Otherwise we should have debug package by default.
> [!]: If the source package does not include license text(s) as a separate
>     file from upstream, the packager SHOULD query upstream to include it.
Since you are one of the upstream team, can you push them to add a license file?

Others looks good at the moment.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v3 or later)", "Unknown or generated". 33 files have
     unknown license. Detailed output of licensecheck in
     /home/zsun/1468861-dtksettings/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[ ]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define debug_package %{nil}
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: dtksettings-0.1.7-1.git32225b9.fc25.x86_64.rpm
          dtksettings-devel-0.1.7-1.git32225b9.fc25.x86_64.rpm
          dtksettings-0.1.7-1.git32225b9.fc25.src.rpm
dtksettings.x86_64: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure
dtksettings.x86_64: W: spelling-error Summary(en_US) json -> son, j son
dtksettings.x86_64: W: name-repeated-in-summary C DtkSettings
dtksettings.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
dtksettings.x86_64: W: spelling-error %description -l en_US json -> son, j son
dtksettings.x86_64: W: unstripped-binary-or-object /usr/lib64/libdtksettingsview.so.1.0.0
dtksettings.x86_64: W: unstripped-binary-or-object /usr/lib64/libdtksettings.so.1.0.0
dtksettings.x86_64: W: unstripped-binary-or-object /usr/bin/dtk-settings-tool
dtksettings.x86_64: W: no-manual-page-for-binary dtk-settings-tool
dtksettings-devel.x86_64: W: only-non-binary-in-usr-lib
dtksettings-devel.x86_64: W: no-documentation
dtksettings.src: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure
dtksettings.src: W: spelling-error Summary(en_US) json -> son, j son
dtksettings.src: W: name-repeated-in-summary C DtkSettings
dtksettings.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
dtksettings.src: W: spelling-error %description -l en_US json -> son, j son
3 packages and 0 specfiles checked; 0 errors, 16 warnings.




Rpmlint (installed packages)
----------------------------
dtksettings-devel.x86_64: W: only-non-binary-in-usr-lib
dtksettings-devel.x86_64: W: no-documentation
dtksettings.x86_64: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure
dtksettings.x86_64: W: spelling-error Summary(en_US) json -> son, j son
dtksettings.x86_64: W: name-repeated-in-summary C DtkSettings
dtksettings.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
dtksettings.x86_64: W: spelling-error %description -l en_US json -> son, j son
dtksettings.x86_64: W: unstripped-binary-or-object /usr/bin/dtk-settings-tool
dtksettings.x86_64: W: unstripped-binary-or-object /usr/lib64/libdtksettings.so.1.0.0
dtksettings.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdtksettings.so.1.0.0 /lib64/libpthread.so.0
dtksettings.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdtksettings.so.1.0.0 /lib64/libm.so.6
dtksettings.x86_64: W: unstripped-binary-or-object /usr/lib64/libdtksettingsview.so.1.0.0
dtksettings.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdtksettingsview.so.1.0.0 /lib64/libGL.so.1
dtksettings.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdtksettingsview.so.1.0.0 /lib64/libpthread.so.0
dtksettings.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdtksettingsview.so.1.0.0 /lib64/libm.so.6
dtksettings.x86_64: W: no-manual-page-for-binary dtk-settings-tool
2 packages and 0 specfiles checked; 0 errors, 16 warnings.



Requires
--------
dtksettings-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    dtksettings(x86-64)
    libdtksettings.so.1()(64bit)
    libdtksettingsview.so.1()(64bit)

dtksettings (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libGL.so.1()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.7)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libdtksettings.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)



Provides
--------
dtksettings-devel:
    dtksettings-devel
    dtksettings-devel(x86-64)
    pkgconfig(dtksettings)
    pkgconfig(dtksettingsview)

dtksettings:
    dtksettings
    dtksettings(x86-64)
    libdtksettings.so.1()(64bit)
    libdtksettingsview.so.1()(64bit)



Source checksums
----------------
https://github.com/linuxdeepin/dtksettings/archive/32225b9ad60e1fcaee81312ea521f45b6fa5c78f/dtksettings-32225b9ad60e1fcaee81312ea521f45b6fa5c78f.tar.gz :
  CHECKSUM(SHA256) this package     : ea97f0c7e99501984bf228bb9bb46951906cc55c56e99e4b90c5f28c3c4a4c48
  CHECKSUM(SHA256) upstream package : ea97f0c7e99501984bf228bb9bb46951906cc55c56e99e4b90c5f28c3c4a4c48


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1468861
Buildroot used: fedora-25-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

I should have addressed these problems.

Spec URL: https://raw.githubusercontent.com/felixonmars/fedora-staging/115ecf207f86073dc0177f316b08d387eae25a57/dtksettings/dtksettings.spec
SRPM URL: https://raw.githubusercontent.com/felixonmars/fedora-staging/115ecf207f86073dc0177f316b08d387eae25a57/dtksettings/dtksettings-0.1.7-1.git34d321e.fc25.src.rpm

Thanks for your time!

> dtksettings.x86_64: W: name-repeated-in-summary C DtkSettings
I think you can write summary like : A powerful tool to generate config from json.

Otherwise this looks good.

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v3 or later)", "Unknown or generated". 34 files have
     unknown license. Detailed output of licensecheck in /home/zsun/tmp
     /review-dtksettings/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     dtksettings-debuginfo
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Scriptlets must be sane, if used.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: dtksettings-0.1.7-1.git34d321e.fc25.x86_64.rpm
          dtksettings-devel-0.1.7-1.git34d321e.fc25.x86_64.rpm
          dtksettings-debuginfo-0.1.7-1.git34d321e.fc25.x86_64.rpm
          dtksettings-0.1.7-1.git34d321e.fc25.src.rpm
dtksettings.x86_64: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure
dtksettings.x86_64: W: spelling-error Summary(en_US) json -> son, j son
dtksettings.x86_64: W: name-repeated-in-summary C DtkSettings
dtksettings.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
dtksettings.x86_64: W: spelling-error %description -l en_US json -> son, j son
dtksettings.x86_64: W: no-manual-page-for-binary dtk-settings-tool
dtksettings-devel.x86_64: W: only-non-binary-in-usr-lib
dtksettings-devel.x86_64: W: no-documentation
dtksettings.src: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure
dtksettings.src: W: spelling-error Summary(en_US) json -> son, j son
dtksettings.src: W: name-repeated-in-summary C DtkSettings
dtksettings.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
dtksettings.src: W: spelling-error %description -l en_US json -> son, j son
4 packages and 0 specfiles checked; 0 errors, 13 warnings.




Rpmlint (debuginfo)
-------------------
Checking: dtksettings-debuginfo-0.1.7-1.git34d321e.fc25.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
dtksettings-devel.x86_64: W: only-non-binary-in-usr-lib
dtksettings-devel.x86_64: W: no-documentation
dtksettings.x86_64: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure
dtksettings.x86_64: W: spelling-error Summary(en_US) json -> son, j son
dtksettings.x86_64: W: name-repeated-in-summary C DtkSettings
dtksettings.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
dtksettings.x86_64: W: spelling-error %description -l en_US json -> son, j son
dtksettings.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdtksettingsview.so.1.0.0 /lib64/libGL.so.1
dtksettings.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdtksettingsview.so.1.0.0 /lib64/libpthread.so.0
dtksettings.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdtksettingsview.so.1.0.0 /lib64/libm.so.6
dtksettings.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdtksettings.so.1.0.0 /lib64/libpthread.so.0
dtksettings.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libdtksettings.so.1.0.0 /lib64/libm.so.6
dtksettings.x86_64: W: no-manual-page-for-binary dtk-settings-tool
3 packages and 0 specfiles checked; 0 errors, 13 warnings.



Requires
--------
dtksettings-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    dtksettings(x86-64)
    libdtksettings.so.1()(64bit)
    libdtksettingsview.so.1()(64bit)

dtksettings-debuginfo (rpmlib, GLIBC filtered):

dtksettings (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libGL.so.1()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.7)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libdtksettings.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)



Provides
--------
dtksettings-devel:
    dtksettings-devel
    dtksettings-devel(x86-64)
    pkgconfig(dtksettings)
    pkgconfig(dtksettingsview)

dtksettings-debuginfo:
    dtksettings-debuginfo
    dtksettings-debuginfo(x86-64)

dtksettings:
    dtksettings
    dtksettings(x86-64)
    libdtksettings.so.1()(64bit)
    libdtksettingsview.so.1()(64bit)



Source checksums
----------------
https://github.com/linuxdeepin/dtksettings/archive/34d321e517524d7eb3110dee2c9d3049771ede05/dtksettings-34d321e517524d7eb3110dee2c9d3049771ede05.tar.gz :
  CHECKSUM(SHA256) this package     : b8e8c08473317e2ddd37f276cd512bde93d96ded9053be42f21d82f4d98e3887
  CHECKSUM(SHA256) upstream package : b8e8c08473317e2ddd37f276cd512bde93d96ded9053be42f21d82f4d98e3887


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -n dtksettings
Buildroot used: fedora-25-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Summary updated. I'll pay more attention to the warnings in the future.

Spec URL: https://raw.githubusercontent.com/felixonmars/fedora-staging/1547f44ecb9a4c9f14a8a798476ef259f36948a4/dtksettings/dtksettings.spec
SRPM URL: https://raw.githubusercontent.com/felixonmars/fedora-staging/1547f44ecb9a4c9f14a8a798476ef259f36948a4/dtksettings/dtksettings-0.1.7-1.git34d321e.fc25.src.rpm

%description
This package provides a Dtk module which can generate user configuration and UI dialog from json.

("generate config" is unclear)


%description devel
→ add "." at the end. All %description:s should have a dot (but Summary:ies not).

Thank you. I have also adjusted the Summary field a bit.

Spec URL: https://raw.githubusercontent.com/felixonmars/fedora-staging/0231c295d5cea631a304f6e3c3ca356a6bb9282b/dtksettings/dtksettings.spec
SRPM URL: https://raw.githubusercontent.com/felixonmars/fedora-staging/0231c295d5cea631a304f6e3c3ca356a6bb9282b/dtksettings/dtksettings-0.1.7-1.git34d321e.fc26.src.rpm

Sorry I overlooked the description-line-too-long error. Updated again:

Spec URL: https://raw.githubusercontent.com/felixonmars/fedora-staging/37efb2c44daec4badb0442422c184a2eec9c46e1/dtksettings/dtksettings.spec
SRPM URL: https://raw.githubusercontent.com/felixonmars/fedora-staging/37efb2c44daec4badb0442422c184a2eec9c46e1/dtksettings/dtksettings-0.1.7-1.git34d321e.fc26.src.rpm

Now you need to request a new package in the pkgdb: https://admin.fedoraproject.org/pkgdb/request/package/. https://fedoraproject.org/wiki/PackageDB_admin_requests has some additional docs.

Requested, status is now "Awaiting Review".

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/dtksettings

Thanks for the review and the repository.