Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1474069 - [Packaging] Please don't ship source file packages
Summary: [Packaging] Please don't ship source file packages
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: eclipse-pydev
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mat Booth
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-23 14:47 UTC by Christian Stadelmann
Modified: 2017-12-12 13:40 UTC (History)
4 users (show)

Fixed In Version: eclipse-pydev-6.1.0-1.fc27 eclipse-pydev-6.1.0-1.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-12 11:17:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Christian Stadelmann 2017-07-23 14:47:56 UTC
Version-Release number of selected component (if applicable):
eclipse-pydev-5.8.0-1.fc26.x86_64

How reproducible:
always (caused by packaging)

Steps to Reproduce:
1. download or install eclipse-pydev
2. have a look at the internal file structure

Actual results:
for every folder in /usr/lib/eclipse/plugins, eclipse-pydev contains a source .jar file

Expected results:
Do not contain a source .jar file. Most of the code is written in python, so source code is not required. Source code belongs into a SRPM file.

Additional info:
See https://fedoraproject.org/wiki/Packaging:Guidelines#Source_RPM_Buildtime_Macros for details.

Comment 1 Mat Booth 2017-07-24 09:20:44 UTC
I'm not sure this is true. Can you give an example?

The first few I looked at, e.g.:

..../com.python.pydev_5.8.0.v20170616-0956/pydev.jar
..../com.python.pydev.analysis_5.8.0.v20170616-0956/analysis.jar
..../com.python.pydev.debug_5.8.0.v20170616-0956/debug.jar

These contain only bytecode (i.e. *.class files) and no source at all.

Upstream Pydev makes the choice to install dir-shaped bundles, with the Java bytecode contained in embedded jars that are referenced from the bundle manifest with the "Bundle-ClassPath" directive.

This is admittedly a non-standard way to ship a plug-in, but it is valid nonetheless.

Comment 2 Christian Stadelmann 2017-07-24 18:15:42 UTC
The folder where the source files are installed: /usr/lib/eclipse/droplets/pydev-core/eclipse/plugins

An example: com.python.pydev.debug.source_5.8.0.v20170616-0956.jar in that folder.

PS: sorry, I put the wrong path in comment #0.

Comment 3 Fedora Update System 2017-11-23 09:26:32 UTC
eclipse-pydev-6.1.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-81e0db662d

Comment 4 Fedora Update System 2017-11-23 09:26:48 UTC
eclipse-pydev-6.1.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cd300764ca

Comment 5 Fedora Update System 2017-11-25 00:35:48 UTC
eclipse-pydev-6.1.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-81e0db662d

Comment 6 Fedora Update System 2017-11-25 01:34:41 UTC
eclipse-pydev-6.1.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cd300764ca

Comment 7 Fedora Update System 2017-12-12 11:17:02 UTC
eclipse-pydev-6.1.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2017-12-12 13:40:33 UTC
eclipse-pydev-6.1.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.