Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1480957 (golang-github-axgle-mahonia) - Review Request: golang-github-axgle-mahonia - Character-set conversion library implemented in Go
Summary: Review Request: golang-github-axgle-mahonia - Character-set conversion librar...
Keywords:
Status: CLOSED RAWHIDE
Alias: golang-github-axgle-mahonia
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DeepinDEPackageReview deepin-daemon
TreeView+ depends on / blocked
 
Reported: 2017-08-13 08:11 UTC by sensor.wen
Modified: 2018-07-22 13:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-22 13:31:07 UTC
Type: Bug
Embargoed:
zbyszek: fedora-review+

Attachments (Terms of Use)

Description sensor.wen 2017-08-13 08:11:26 UTC 
Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00589818-golang-github-axgle-mahonia/golang-github-axgle-mahonia.spec
SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00589818-golang-github-axgle-mahonia/golang-github-axgle-mahonia-0-0.1.fc25.src.rpm

Description: Character-set conversion library implemented in Go

Fedora Account System Username: mosquito
Comment 1 Zbigniew Jędrzejewski-Szmek 2017-08-14 01:05:34 UTC 
Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/gocode/src/github.com/axgle/mahonia
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

rpmlint:
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Shouldn't the Release tag include the git hash? There seems to be no released version.

+ package name is OK
? license is acceptable (MIT)
? license is not specified correctly
Where did you see the MIT license? README.md says this is derived from http://code.google.com/p/mahonia/, which lists BSD 3-clause.

Either way, you should open a ticket upstream asking for a license file to be included. Actually adding the license file is not necessary, but the ticket should be opened according to the guidelines [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text].

+ latest version
+ P/R/BR look OK
+ builds and install OK
+ fedora-review and rmplint are happy (modulo the issue listed above)

rpmlint:
golang-github-BurntSushi-freetype-go-unit-test-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Comment 2 Zbigniew Jędrzejewski-Szmek 2017-08-14 01:06:21 UTC 
Blah, please ignore the last paragraph, I pasted the wrong text, the right rpmlint output is above.
Comment 3 sensor.wen 2017-08-14 17:15:40 UTC 
I opened a new ticket in the upstream for license.

https://github.com/axgle/mahonia/issues/4

Release and license tag is fixed.
Comment 4 sensor.wen 2017-08-19 17:12:58 UTC 
https://github.com/FZUG/repo/blob/master/rpms/deepin_project/golang-github-axgle-mahonia.spec

I think project owner is leave. Could you approve it?
Comment 5 Zbigniew Jędrzejewski-Szmek 2017-09-02 09:10:17 UTC 
Sorry for the delay, I am travelling.

Everything looks good, package is APPROVED.
Comment 6 Gwyn Ciesla 2017-09-04 18:07:45 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-axgle-mahonia
Comment 7 Fedora Update System 2017-10-09 15:07:32 UTC 
golang-github-axgle-mahonia-0-0.1.gitc528b74.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b71d187af0
Comment 8 Fedora Update System 2017-10-11 06:27:16 UTC 
golang-github-axgle-mahonia-0-0.1.gitc528b74.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b71d187af0
Comment 9 Zamir SUN 2018-07-22 13:31:07 UTC 
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
Note You need to log in before you can comment on or make changes to this bug.