Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1494079 - Use mariadb-connector-c-devel instead of mysql-devel or mariadb-devel
Summary: Use mariadb-connector-c-devel instead of mysql-devel or mariadb-devel
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: grass
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: markusN
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1486480
TreeView+ depends on / blocked
 
Reported: 2017-09-21 12:35 UTC by Michal Schorm
Modified: 2019-01-09 12:54 UTC (History)
6 users (show)

Fixed In Version: grass-7.4.0-1.fc28 grass-7.4.0-2.fc27
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-17 00:17:03 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Michal Schorm 2017-09-21 12:35:06 UTC
Hello, a MariaDB went through big changes and your package will probabbly need a patch. However your package FTBFS for a long time, so I have no way to test the patch.

In most cases, this command was enough to fix all the issues:

sed -i "s/mysql-devel/mariadb-connector-c-devel/" $(fedpkg gimmespec) ; \
sed -i "s/mariadb-devel/mariadb-connector-c-devel/" $(fedpkg gimmespec) ; \
sed -i "s/%{_libdir}\/mysql/%{_libdir}\/mariadb/" $(fedpkg gimmespec) ; \
sed -i "s/mariadb-connector-c-devel/mariadb-connector-c-devel openssl-devel/" $(fedpkg gimmespec) ;

This change is currently applicable to the Rawhide (f28) only.



For more information check the tracking bugzilla.

Comment 1 Michal Schorm 2017-12-13 12:41:19 UTC
Hello,
 any update regarding this issue?

Comment 2 markusN 2018-01-26 16:02:24 UTC
The FTBFS issues we have addressed some months ago (fixed the GCC7 support)
but our updated code has not yet been used in Fedora. Happy to help!

The updated SPEC file is here:
https://trac.osgeo.org/grass/browser/grass/branches/releasebranch_7_4/rpm/grass.spec

Comment 3 Michal Schorm 2018-01-26 17:13:17 UTC
(In reply to markusN from comment #2)
> The FTBFS issues we have addressed some months ago (fixed the GCC7 support)
> but our updated code has not yet been used in Fedora. Happy to help!
> 
> The updated SPEC file is here:
> https://trac.osgeo.org/grass/browser/grass/branches/releasebranch_7_4/rpm/
> grass.spec

You say, none of the maintainers, listed here:
https://src.fedoraproject.org/rpms/grass
are active?

In such case, I can search for the maintainers and let them know!
(Starting by adding them to the NEEDINFO)

Comment 4 markusN 2018-01-26 17:33:02 UTC
(In reply to Michal Schorm from comment #3)
> (In reply to markusN from comment #2)
> > The FTBFS issues we have addressed some months ago (fixed the GCC7 support)
> > but our updated code has not yet been used in Fedora. Happy to help!
> > 
> > The updated SPEC file is here:
> > https://trac.osgeo.org/grass/browser/grass/branches/releasebranch_7_4/rpm/
> > grass.spec
> 
> You say, none of the maintainers, listed here:
> https://src.fedoraproject.org/rpms/grass
> are active?

Maybe yes, maybe not. I simply don't know.

> In such case, I can search for the maintainers and let them know!
> (Starting by adding them to the NEEDINFO)

Thanks. I have also added a review request for GRASS GIS 7.4.0 (released today;
I am the project coordinator and release manager) as bug #1539116

Comment 5 Oliver Falk 2018-02-12 12:19:05 UTC
I'm not _really_ a maintainer of that package. I remember some build issues on Alpha and since I've been the main secondary arch maintainer for Alpha, somehow, it happend I became co-maintainer.

Anyway. I really hoped someone else is going to step up in this bug. But since nobody did yet, I'll try to be helpful. 

Markus, as you have submitted a review request for GRASS GIS 7.4 already, does it make any sense to change the current spec!?
Do you want me to make you a maintainer for GRASS? (Although Fedora build/package system change so much since I actively used it and therefore I do have to read the docs on how to do this first...)

Comment 6 markusN 2018-02-12 17:19:16 UTC
(In reply to Oliver Falk from comment #5)
> Anyway. I really hoped someone else is going to step up in this bug. But
> since nobody did yet, I'll try to be helpful. 

Thanks for that!
 
> Markus, as you have submitted a review request for GRASS GIS 7.4 already,
> does it make any sense to change the current spec!?

The current spec as per as bug #1539116 already uses mariadb-connector-c-devel instead of mysql-devel. Anything else to change therein?

> Do you want me to make you a maintainer for GRASS? (Although Fedora
> build/package system change so much since I actively used it and therefore I
> do have to read the docs on how to do this first...)

Since the other/former maintainers remain silent and I would really be interested to get GRASS GIS back in shape on Fedora, you may add me to the list of maintainers for GRASS. Then I'll have to study the docs as well on how to upload the package.

Comment 7 Michal Schorm 2018-02-13 00:43:00 UTC
I sent an e-mail, looking for the maintainers, to fedora-devel mailing list.
But nobody replied.

The archived mail can be found here:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/MMRFZAWWI3EH74JE3OQE5MUZWNOQJHSD/

--

I'm happy to see your interest in keeping the package alive through involvement :)

Oliver,
I'll try to describe in short:
1) The main crossroad for the package is now: https://src.fedoraproject.org/rpms/grass
2) If you log in, you can find blue "settings" text top right under for button. Then just simply scrool to "Users and Groups" and "Add user".
3) There might be a problem - if you are not main admin or admin, you maybe can't add more users. In such case, you will need to trie to contact the main admin directly, and if non-responsive, file new issue at https://pagure.io/fesco/ explaining situation, requesting to become admin or main admin.

--

Markus,
you can see here:
https://src.fedoraproject.org/rpms/grass/blob/master/f/grass.spec
that the package still use "BuildRequires: mysql-devel", which is not correct.

Comment 8 Oliver Falk 2018-02-13 06:20:11 UTC
As you already guessed, Michal, I don't have the rights to add users, probably because I'm not the main admin for grass. However, I followed your suggestion and opened a ticket at fesco.

Well, I'm not an active user of any GIS related stuff (I used to be for some time), but sure I want to keep grass alive, especially if Markus is going to take care about the spec / build stuff :-)

Markus, I suggest to add some information about the package owner transfer and the new spec in the %changelog, so the move from the current, to the new spec, is clear for everyone looking at the package changelog.

Comment 9 markusN 2018-02-13 19:39:10 UTC
(In reply to Michal Schorm from comment #7)
...
> Markus,
> you can see here:
> https://src.fedoraproject.org/rpms/grass/blob/master/f/grass.spec
> that the package still use "BuildRequires: mysql-devel", which is not
> correct.

Michal,
the indicated SPEC file you cite above is "antique" :)

Please verify

https://trac.osgeo.org/grass/browser/grass/branches/releasebranch_7_4/rpm/grass.spec?format=txt


Oliver,
concerning the requested changelog file change on ownership, any best practice to follow since the wording is important here?

thanks, Markus

Comment 10 Michal Schorm 2018-02-13 23:32:15 UTC
Yes, the SPECfile on trac.osgeo.org LGTM, in case of mysql / mariadb Buildrequires.

--

I agree with Oliver about the well-describing changelog entry.

IMHO
In general, I'd briefly describe the situation and add link to our discussion in this bugzilla.
Same with the commit message.

Comment 11 Oliver Falk 2018-02-15 08:02:41 UTC
Short update: The owner change from devrim to me is on the Fesco meeting agenda for tomorrow.

Regarding CL: Agree with Michal; Do, briefly, describe the situation and link to this BZ#.

Comment 12 markusN 2018-02-15 21:59:13 UTC
(In reply to Oliver Falk from comment #11)
> Regarding CL: Agree with Michal; Do, briefly, describe the situation and
> link to this BZ#.

The situation is the following: the GRASS GIS package was to some extent abadoned. Together with Markus Metz we have cleaned up the SPEC file and tested it on COPR. Also the mysql / mariadb Buildrequires got fixed. The SPEC file works on Fedora and well as EPEL6 and EPEL7. Also the g.extension bug 1489158 and the installation bug 1472991 are fixed.

Comment 13 Devrim Gündüz 2018-02-16 02:15:45 UTC
Hi,

Markus, I gave you commit bits.

Thanks!

Devrim

Comment 14 markusN 2018-02-18 10:57:25 UTC
(In reply to Devrim GÜNDÜZ from comment #13)
> Hi,
> 
> Markus, I gave you commit bits.

Thanks, Devrim!

Any RTFM pointer to "what's next"?

Comment 15 Oliver Falk 2018-02-19 06:22:38 UTC
Seems I'm not needed any longer - going to remove myself from this bug.
All the best with the "new" package, Markus!

Comment 16 Devrim Gündüz 2018-02-19 08:56:05 UTC
(In reply to markusN from comment #14)
> (In reply to Devrim GÜNDÜZ from comment #13)
> > Hi,
> > 
> > Markus, I gave you commit bits.
> 
> Thanks, Devrim!
> 
> Any RTFM pointer to "what's next"?

A few things to start with:

https://fedoraproject.org/wiki/Packaging:Guidelines

https://fedoraproject.org/wiki/Package_maintenance_guide

(you may also want to read this)

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join

Cheers, Devrim

Comment 17 Fedora End Of Life 2018-02-20 15:23:19 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 18 markusN 2018-02-26 17:45:46 UTC
I have updated the GRASS GIS 7.2.2 rpms for F27, F28 and rawhide packages on koji:

https://koji.fedoraproject.org/koji/packageinfo?packageID=1972

Not sure what's next (sorry, still studying :-)

(once understood I can tackle GRASS GIS 7.4.0)

Comment 19 Fedora Update System 2018-03-25 19:47:17 UTC
grass-7.2.3-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1788c9054c

Comment 20 Fedora Update System 2018-03-26 15:01:18 UTC
grass-7.2.3-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1788c9054c

Comment 21 Fedora Update System 2018-04-11 07:14:39 UTC
grass-7.4.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-64644ab8c5

Comment 22 Fedora Update System 2018-04-11 22:58:10 UTC
grass-7.4.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-64644ab8c5

Comment 23 Fedora Update System 2018-04-17 00:17:03 UTC
grass-7.4.0-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2018-04-27 16:46:53 UTC
grass-7.4.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e13babe183

Comment 25 Fedora Update System 2018-04-28 01:54:03 UTC
grass-7.4.0-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-e13babe183

Comment 26 Fedora Update System 2018-05-02 12:36:13 UTC
grass-7.4.0-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.