Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1495293 - Review Request: python-Naked - A command line application framework
Summary: Review Request: python-Naked - A command line application framework
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Clint Savage
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-09-25 17:59 UTC by greg.hellings
Modified: 2018-03-06 17:19 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-06 17:19:27 UTC
Type: ---
Embargoed:
csavage: fedora-review+

Attachments (Terms of Use)
rpmlint.txt from fedora-review (27.67 KB, text/plain)
2017-09-26 15:18 UTC, Clint Savage 		no flags Details
fedora-review results (review.txt) 20180118 (36.08 KB, text/plain)
2018-01-18 22:27 UTC, Clint Savage 		csavage: review+
Details
View All

Description greg.hellings 2017-09-25 17:59:42 UTC 
Spec URL: https://fedorapeople.org/~greghellings/python-Naked/python-Naked.spec
SRPM URL: https://fedorapeople.org/~greghellings/python-Naked/python-Naked-0.1.31-1.fc26.src.rpm
Description: Naked is a new Python command line application framework that makes creating command line options and sub-commands simpler.
Fedora Account System Username: greghellings
Comment 1 Clint Savage 2017-09-26 15:18:04 UTC 
Created attachment 1331164 [details]
rpmlint.txt from fedora-review

rpmlint errors

rpmlint gives a really long list of errors. I reviewed them, and even built the package against mock. 

- The description is definitely too long, could be trimmed.
- Maybe the non-executable-script errors should be give execution permissions?
- not sure about the wrong-script-interpreter error, maybe other wsgi apps could help?
Comment 2 greg.hellings 2017-11-17 04:51:00 UTC 
The description was fine, but the line length was obscene. I've added line breaks and now it's recording OK.

The non-executable scripts should have their spurious shebang lines removed, which I've done. It also addresses the wrong-script-interpreter issue as well. I've simply deleted the line from the top of the offending files.

New spec file: https://fedorapeople.org/~greghellings/python-Naked/python-Naked.spec
New SRPM: https://fedorapeople.org/~greghellings/python-Naked/python-Naked-0.1.31-2.fc27.src.rpm
Comment 3 Clint Savage 2018-01-18 22:27:31 UTC 
Created attachment 1383081 [details]
fedora-review results (review.txt) 20180118
Comment 4 Clint Savage 2018-01-18 22:28:40 UTC 
I think all of my concerns from above were met. I noted a few nits in the attached review.txt, but nothing preventing approval.
Comment 5 greg.hellings 2018-02-02 13:54:29 UTC 
@Clint - You need to set the fedora-review flag to "+". I tried to update it myself, but the repo creation tool checks that, and won't allow me to set it on my own request (I should have realized that...). If you can set that, I can move forward with closing this one out.
Comment 6 Gwyn Ciesla 2018-02-02 18:28:26 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-Naked. You may commit to the branch "f27" in about 10 minutes.
Comment 7 Fedora Update System 2018-02-03 22:58:54 UTC 
python-Naked-0.1.31-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-472ea01f77
Comment 8 Fedora Update System 2018-02-04 20:18:19 UTC 
python-Naked-0.1.31-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-472ea01f77
Comment 9 Fedora Update System 2018-02-13 15:26:20 UTC 
python-Naked-0.1.31-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-91d06f2add
Comment 10 Fedora Update System 2018-02-14 18:26:52 UTC 
python-Naked-0.1.31-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-91d06f2add
Comment 11 Fedora Update System 2018-03-06 17:19:27 UTC 
python-Naked-0.1.31-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.