Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1519324 - Review Request: onedrive - OneDrive Free Client written in D
Summary: Review Request: onedrive - OneDrive Free Client written in D
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Robin Lee
QA Contact: Fedora Extras Quality Assurance
: 1546985 (view as bug list)
Depends On:
TreeView+ depends on / blocked
Reported: 2017-11-30 15:25 UTC by Zamir SUN
Modified: 2018-02-20 09:59 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2018-01-31 21:57:07 UTC
Type: ---
robinlee.sysu: fedora-review+

Attachments (Terms of Use)

Comment 1 Artur Frenszek-Iwicki 2017-12-01 22:14:41 UTC
>Group: Applications/Internet
The "Group:" tag should not be used.

I think this should use the %{repo} macro declared at the start of the spec.

>This do not support OneDrive for business
Broken grammar. "This does not support OneDrive For Business", or maybe "OneDrive For Business is not supported".

>sed -i 's/\/usr\/local/\/usr/' Makefile
Sed allows to use any character as the regex delimiter; if you use something else than the slash (e.g. a pipe "|"), you won't have to escape every slash.

Also, you either forgot to roll the "Release:" tag back to 1, or there's a missing changelog entry for 1.0.1-2.

Comment 3 Robin Lee 2017-12-28 01:49:23 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[!]: %build honors applicable compiler flags or justifies otherwise.
     %{_d_optflags} should be used:
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
     /usr should be replaced with %_prefix.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.
[!]: Follow ldc.spec to add 'ExclusiveArch: %{ldc_arches}'

Checking: onedrive-1.0.1-1.fc28.x86_64.rpm
onedrive.x86_64: W: name-repeated-in-summary C OneDrive
onedrive.x86_64: W: no-manual-page-for-binary onedrive
onedrive.src: W: name-repeated-in-summary C OneDrive
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

Rpmlint (debuginfo)
Checking: onedrive-debuginfo-1.0.1-1.fc28.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)
sh: /usr/bin/python: No such file or directory
onedrive.x86_64: W: name-repeated-in-summary C OneDrive
onedrive.x86_64: W: no-manual-page-for-binary onedrive
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

onedrive-debuginfo (rpmlib, GLIBC filtered):

onedrive (rpmlib, GLIBC filtered):



Source checksums
---------------- :
  CHECKSUM(SHA256) this package     : e862c2d9d65fc11cc2befbfd8d0065a08821e723cbcfe16943a5b2215bc9caf8
  CHECKSUM(SHA256) upstream package : e862c2d9d65fc11cc2befbfd8d0065a08821e723cbcfe16943a5b2215bc9caf8

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1519324
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP

Comment 5 Robin Lee 2017-12-28 06:54:07 UTC
[!]: %build honors applicable compiler flags or justifies otherwise.
     %{_d_optflags} should be used:
This was not fixed. From build.log:

+ export 'DFLAGS=-release -w -g -O1'
+ DFLAGS='-release -w -g -O1'
+ /usr/bin/make -O -j6
sed "s|@PREFIX@|/usr|g" > onedrive.service
ldmd2 -g -inline -O -release -ofonedrive -L-lcurl -L-lsqlite3 -L-ldl -J. src/config.d src/itemdb.d src/log.d src/main.d src/monitor.d src/onedrive.d src/qxor.d src/selective.d src/sqlite.d src/sync.d src/upload.d src/util.d

DFLAGS seems not actually honored.

Comment 6 Zamir SUN 2017-12-28 10:19:01 UTC
Oh, right. I guess it is also hard-coded in Makefile. I'll look into the Makefile later.

Comment 8 Robin Lee 2017-12-28 14:54:34 UTC
This package is approved by cheeselee.

Comment 9 Gwyn Ciesla 2018-01-02 15:12:15 UTC
(fedrepo-req-admin):  The Pagure repository was created at

Comment 10 Fedora Update System 2018-01-05 14:55:11 UTC
onedrive-1.0.1-1.fc27 has been submitted as an update to Fedora 27.

Comment 11 Fedora Update System 2018-01-06 21:09:38 UTC
onedrive-1.0.1-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See for
instructions on how to install test updates.
You can provide feedback for this update here:

Comment 12 Fedora Update System 2018-01-31 21:57:07 UTC
onedrive-1.0.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Tom Hughes 2018-02-20 09:59:15 UTC
*** Bug 1546985 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.