Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1520915 - Review Request: tldr - command line client for tldr
Summary: Review Request: tldr - command line client for tldr
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-05 13:00 UTC by Lumír Balhar
Modified: 2017-12-19 21:34 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-10 19:20:02 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Lumír Balhar 2017-12-05 13:00:05 UTC
Spec URL: https://lbalhar.fedorapeople.org/tldr.spec
SRPM URL: https://lbalhar.fedorapeople.org/tldr-0.4.1-1.fc27.src.rpm
Description: A Python command line client for tldr - Simplified and community-driven man pages http://tldr-pages.github.io/.
Fedora Account System Username: lbalhar

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23558310 (not finished yet due to Koji issues)

Comment 1 Miro Hrončok 2017-12-05 13:03:30 UTC
Why don't you %py3_isntall?

Comment 2 Lumír Balhar 2017-12-05 13:27:28 UTC
Because it installs a lot more than is necessary (Python module, egg-info, multiple binaries (duplicities) etc.) with the same content.

Comment 3 Miro Hrončok 2017-12-05 13:31:22 UTC
I'd rather have that all and just rm /usr/bin/tldr.py and keep the entrypoint, to stay in sync with upstream.

Comment 4 Robert-André Mauchin 🐧 2017-12-05 14:04:37 UTC
Indeed you should use %py3_install. Here the %files if you do:

%files
%license LICENSE
%doc README.md
%{_bindir}/%{name}
%{_bindir}/%{name}.py
%{python3_sitelib}/%{name}.py
%{python3_sitelib}/__pycache__/*.pyc
%{python3_sitelib}/%{name}-%{version}-py?.?.egg-info

 - You should then remove the shebang from %{python3_sitelib}/%{name}.py:
   tldr.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/tldr.py /usr/bin/env python

sed -i '1{\@^#!/usr/bin/env python@d}' %{buildroot}%{python3_sitelib}/%{name}.py

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 9 files have
     unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/tldr/review-tldr/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: tldr-0.4.1-1.fc28.noarch.rpm
          tldr-0.4.1-1.fc28.src.rpm
tldr.noarch: W: name-repeated-in-summary C tldr
tldr.noarch: W: no-manual-page-for-binary tldr
tldr.src: W: name-repeated-in-summary C tldr
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

Comment 5 Peter Oliver 2017-12-05 16:51:35 UTC
The summary says that tldr is a command-line client for tldr.  Could this be made a bit less circular, somehow, for the benefit of people who don't already know what tldr is?  "Simplified and community-driven man pages", perhaps?

Comment 6 Lumír Balhar 2017-12-05 17:50:39 UTC
Thanks for the reviews.

Summary, %install and %files fixed and spec/SRPM updated.

Comment 7 Robert-André Mauchin 🐧 2017-12-05 23:27:25 UTC
This is great, package accepted.

Comment 8 Fedora Update System 2017-12-08 15:03:47 UTC
tldr-0.4.1-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8f6c9bf2c5

Comment 9 Fedora Update System 2017-12-08 15:10:12 UTC
tldr-0.4.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-dd41b9d50d

Comment 10 Fedora Update System 2017-12-09 07:28:50 UTC
tldr-0.4.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-dd41b9d50d

Comment 11 Fedora Update System 2017-12-10 00:33:25 UTC
tldr-0.4.1-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8f6c9bf2c5

Comment 12 Fedora Update System 2017-12-10 19:20:02 UTC
tldr-0.4.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2017-12-19 21:34:57 UTC
tldr-0.4.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.