Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1536782 (golang-github-cryptix-wav) - Review Request: golang-github-cryptix-wav - golang wav reader and writer
Summary: Review Request: golang-github-cryptix-wav - golang wav reader and writer
Keywords:
Status: CLOSED RAWHIDE
Alias: golang-github-cryptix-wav
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DeepinDEPackageReview
TreeView+ depends on / blocked
 
Reported: 2018-01-21 06:33 UTC by sensor.wen
Modified: 2018-07-22 13:33 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-22 13:32:26 UTC
Type: Bug
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description sensor.wen 2018-01-21 06:33:08 UTC 
Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00690503-golang-github-cryptix-wav/golang-github-cryptix-wav.spec

SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00690503-golang-github-cryptix-wav/golang-github-cryptix-wav-0-0.1.git7b3d650.fc26.src.rpm

Description: golang wav reader and writer

Fedora Account System Username: mosquito
Comment 1 Robert-André Mauchin 🐧 2018-01-21 17:25:05 UTC 
 - add examples/ to %doc

 - when you package a development snapshot, you must add the commit date in Release:

%global   commit          7b3d650b50a50a0137376e392770f372edc3d968
%global   shortcommit     %(c=%{commit}; echo ${c:0:7})
%global   commitdate      20171018

Name:           golang-%{provider}-%{project}-%{repo}
Version:        0
Release:        0.1.%{commitdate}git%{shortcommit}%{?dist}


   And in %changelog:

* Thu Dec 21 2017 mosquito <sensor.wen> - 0-0.1.20171018git7b3d650
Comment 2 sensor.wen 2018-02-10 03:01:07 UTC 
SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-27-x86_64/00713241-golang-github-cryptix-wav/golang-github-cryptix-wav.spec
SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-27-x86_64/00713241-golang-github-cryptix-wav/golang-github-cryptix-wav-0-0.1.20171018git7b3d650.fc27.src.rpm

I fixed it, thank you. Please review again.
Comment 3 Robert-André Mauchin 🐧 2018-02-10 11:43:03 UTC 
Tests require github.com/cheekybits/is, it would be nice to package it, and add it to the SPEC to run the tests correctly.

Package otherwise approved.
Comment 4 Gwyn Ciesla 2018-02-15 17:18:42 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-cryptix-wav
Comment 5 Zamir SUN 2018-07-22 13:32:26 UTC 
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
Comment 6 Zamir SUN 2018-07-22 13:33:15 UTC 
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
Note You need to log in before you can comment on or make changes to this bug.