Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1541554 - Review Request: podman - Manage Pods, Containers and Container Images
Summary: Review Request: podman - Manage Pods, Containers and Container Images
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Frantisek Kluknavsky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-02 21:34 UTC by Lokesh Mandvekar
Modified: 2018-02-16 17:48 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-16 17:48:10 UTC
Type: ---
Embargoed:
fkluknav: fedora-review+


Attachments (Terms of Use)

Description Lokesh Mandvekar 2018-02-02 21:34:31 UTC
Spec URL: https://pagure.io/podman/blob/master/f/podman.spec
SRPM URL: https://pagure.io/podman/blob/master/f/SRPMS/podman-0-0.2.git0387f69.fc27.src.rpm

Description: 
libpod provides a library for applications looking to use the Container Pod concept popularized by Kubernetes.

Fedora Account System Username: lsm5

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=24656961
(currently x86_64 only, other arches have build failures which are being worked on ATM)

Comment 1 Lokesh Mandvekar 2018-02-02 21:38:05 UTC
raw format probably preferable for fedora-review tool.

Spec URL: https://pagure.io/podman/raw/master/f/podman.spec

Comment 2 Frantisek Kluknavsky 2018-02-05 23:51:26 UTC
"MUST:rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review."

$ rpmlint ./podman-*
podman.src: W: spelling-error %description -l en_US libpod -> lib pod, lib-pod, libido
podman.src: E: description-line-too-long C libpod provides a library for applications looking to use the Container Pod concept popularized by Kubernetes.
podman.x86_64: W: spelling-error %description -l en_US libpod -> lib pod, lib-pod, libido
podman.x86_64: E: description-line-too-long C libpod provides a library for applications looking to use the Container Pod concept popularized by Kubernetes.
podman.x86_64: W: only-non-binary-in-usr-lib
podman.x86_64: W: manual-page-warning /usr/share/man/man1/podman-run.1.gz 846: warning: macro `You' not defined
podman-debugsource.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 2 errors, 5 warnings.

Spelling error is obviously a false positive.
only-non-binary-in-usr-lib is a known bug.
Too long description should be fixed. I created a pull request.
I am not aware if every subpackage must have some documentation, it does not make much sense here.
Manual page is readable, the warning should probably be investigated anyway.

"If a Fedora package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number should then be placed in a comment, next to the corresponding ExcludeArch line. New packages will not have bugzilla entries during the review process, so they should put this description in the comment until the package is approved, then file the bugzilla entry, and replace the long explanation with the bug number."

The custom definition of %gobuild macro seems a buggy remnant of developing the spec, but in Fedora the spec does not use this definition, it should not be a problem.

Overall, I can not find any serious blockers.

Comment 3 Lokesh Mandvekar 2018-02-06 00:05:45 UTC
Thanks for the review and approval. 

I merged your PR, the link should be the same as the original posted above.

RE: manpage macro, it's probably because the '.' character appears first on a newline followed by the word "You" in the mardown file. That will be taken care of once fixed upstream.

Right now there's no ExcludeArch but ExclusiveArch, so I think we should be fine.

RE: %gobuild, that's needed for debuginfo.

Comment 4 Gwyn Ciesla 2018-02-06 14:49:57 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/podman. You may commit to the branch "f27" in about 10 minutes.

Comment 5 Daniel Walsh 2018-02-06 15:25:18 UTC
Can we add me as a maintainer of this package.

Comment 6 Fedora Update System 2018-02-06 22:20:44 UTC
podman-0-0.3.git367213a.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-665045691d

Comment 7 Fedora Update System 2018-02-07 14:09:48 UTC
podman-0-0.3.git367213a.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-665045691d

Comment 8 Fedora Update System 2018-02-12 20:21:13 UTC
podman-0.2-1.git3d0100b.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-803745b92f

Comment 9 Fedora Update System 2018-02-13 16:41:16 UTC
podman-0.2-1.git3d0100b.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-803745b92f

Comment 10 Fedora Update System 2018-02-14 14:28:12 UTC
podman-0.2-2.git3d0100b.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-23fa359f4c

Comment 11 Fedora Update System 2018-02-14 18:28:45 UTC
podman-0.2-2.git3d0100b.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-23fa359f4c

Comment 12 Fedora Update System 2018-02-16 17:48:10 UTC
podman-0.2-3.git3d0100b.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.