Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1546394 - Review Request: open-amp - Open Asymmetric Multi Processing (OpenAMP) framework project
Summary: Review Request: open-amp - Open Asymmetric Multi Processing (OpenAMP) framewo...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
Depends On: 1546376
Blocks: IoT
TreeView+ depends on / blocked
Reported: 2018-02-16 22:56 UTC by Jared Smith
Modified: 2020-03-05 19:47 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2020-03-05 19:47:35 UTC
Type: ---
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2018-02-16 22:56:08 UTC
Spec URL:
Description: The OpenAMP framework provides software components that enable development of software applications for Asymmetric Multiprocessing (AMP) systems.
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2018-02-16 23:04:59 UTC

Same as before:

 - This should be in the -devel subpackage:



 - Your -devel subpackage should require the main package:

%package devel
Summary: Development files for OpenAMP
Requires: %{name}%{?_isa} = %{version}-%{release}

   Consequently you don't need to add %license in the -devel subpackage.

 - There should probably be a %make_build before %make_install to use parallel computation:

%cmake -DCMAKE_INSTALL_LIBDIR=%{_libdir} \
	-DCMAKE_INCLUDE_PATH=%{_includedir}/libmetal/ \
	-DCMAKE_LIBRARY_PATH=%{_libdir} \

 - It's also usual to build in a subdir:

mkdir build && cd build
%cmake -DCMAKE_INSTALL_LIBDIR=%{_libdir} \
	-DCMAKE_INCLUDE_PATH=%{_includedir}/libmetal/ \
	-DCMAKE_LIBRARY_PATH=%{_libdir} \

cd build

 - Use a more meaningful name for the archive, with:


 - Not an error, just a preference: you could move %ldconfig_scriptlets
 after %install

Comment 3 Robert-André Mauchin 🐧 2018-02-20 02:10:27 UTC
All ok, package approved.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT/X11 (BSD like)", "zlib/libpng",
     "*No copyright* BSD (3 clause)", "BSD (2 clause) GPL (v2 or later)",
     "BSD (3 clause)", "BSD (2 clause)", "GPL (v2)". 121 files have unknown
     license. Detailed output of licensecheck in /home/bob/packaging/review
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Checking: open-amp-2017.10-1.fc28.x86_64.rpm
open-amp.x86_64: W: no-manual-page-for-binary echo_test-shared
open-amp.x86_64: W: no-manual-page-for-binary echo_testd-shared
open-amp.x86_64: W: no-manual-page-for-binary matrix_multiply-shared
open-amp.x86_64: W: no-manual-page-for-binary matrix_multiplyd-shared
open-amp.x86_64: W: no-manual-page-for-binary rpc_demod-shared
open-amp-devel.x86_64: W: spelling-error %description -l en_US baremetal -> bare metal, bare-metal, metatarsal
open-amp-devel.x86_64: W: only-non-binary-in-usr-lib
open-amp-devel.x86_64: W: no-documentation
open-amp-debugsource.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 9 warnings.

Comment 4 Gwyn Ciesla 2018-02-20 13:57:15 UTC
(fedrepo-req-admin):  The Pagure repository was created at

Note You need to log in before you can comment on or make changes to this bug.