Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1578564 - Review Request: golang-github-mdlayher-wifi - Provides access to IEEE 802.11 WiFi device actions and statistics
Summary: Review Request: golang-github-mdlayher-wifi - Provides access to IEEE 802.11 ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1578562
Blocks: 1512702
TreeView+ depends on / blocked
 
Reported: 2018-05-15 20:44 UTC by Paul Gier
Modified: 2019-01-16 06:52 UTC (History)
5 users (show)

Fixed In Version: golang-github-mdlayher-wifi-0-0.1.20180522git17fb838.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-01-16 06:52:29 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Paul Gier 2018-05-15 20:44:42 UTC 
Spec URL: https://pgier.fedorapeople.org/golang/golang-github-mdlayher-wifi/golang-github-mdlayher-wifi.spec
SRPM URL: https://pgier.fedorapeople.org/golang/golang-github-mdlayher-wifi/golang-github-mdlayher-wifi-0-0.1.20180515git17fb838.fc27.src.rpm
Description: Package wifi provides access to IEEE 802.11 WiFi device actions and statistics.
Fedora Account System Username: pgier
Comment 1 Paul Gier 2018-05-15 20:45:28 UTC 
This is a dependency of prometheus node_exporter
Comment 2 Robert-André Mauchin 🐧 2018-05-16 15:18:08 UTC 
warning: bogus date in %changelog: Sat May 15 2018 Paul Gier <pgier> - 0-0.1.20180515git17fb83

 - May 15 is a Tuesday not a Saturday. Please fix this.

 - Testing fails:

Testing: github.com/mdlayher/wifi
Testing: "/builddir/build/BUILD/wifi-17fb8383f38adbf6a7f12e6cbd1d461760aabf5c/_build/src/github.com/mdlayher/wifi"
+ GOPATH=/builddir/build/BUILD/wifi-17fb8383f38adbf6a7f12e6cbd1d461760aabf5c/_build:/usr/share/gocode
+ go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
BUILDSTDERR: # github.com/mdlayher/wifi
BUILDSTDERR: client_linux_test.go:18:2: cannot find package "github.com/google/go-cmp/cmp" in any of:
BUILDSTDERR: 	/usr/lib/golang/src/github.com/google/go-cmp/cmp (from $GOROOT)
BUILDSTDERR: 	/builddir/build/BUILD/wifi-17fb8383f38adbf6a7f12e6cbd1d461760aabf5c/_build/src/github.com/google/go-cmp/cmp (from $GOPATH)
BUILDSTDERR: 	/usr/share/gocode/src/github.com/google/go-cmp/cmp
BUILDSTDERR: FAIL	github.com/mdlayher/wifi [setup failed]


   Add:

BuildRequires: golang(github.com/google/go-cmp/cmp)
Comment 3 Paul Gier 2018-05-17 20:43:17 UTC 
Spec file and SRPM have been updated.
Scratch build here: https://koji.fedoraproject.org/koji/taskinfo?taskID=27021017
Comment 4 Robert-André Mauchin 🐧 2018-05-18 14:43:32 UTC 
Package approved.
Comment 5 Gwyn Ciesla 2018-05-22 01:18:50 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-mdlayher-wifi
Comment 6 Paul Gier 2018-05-22 16:18:53 UTC 
Koji Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1083959
Comment 7 Jonathan Dieter 2018-11-07 18:06:00 UTC 
It looks like you've got this into Fedora, so feel free to close this bug.  This will make it more obvious what still needs to be done to get node_exporter into Fedora.
Comment 8 Elliott Sales de Andrade 2019-01-16 06:52:29 UTC 
This is built; please close review requests when they're complete.
Note You need to log in before you can comment on or make changes to this bug.