Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1579403 - Review Request: golang-github-soundcloud-runit - go library wrapping runit service status
Summary: Review Request: golang-github-soundcloud-runit - go library wrapping runit se...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1512702
TreeView+ depends on / blocked
 
Reported: 2018-05-17 14:42 UTC by Paul Gier
Modified: 2020-02-21 07:35 UTC (History)
5 users (show)

Fixed In Version: golang-github-soundcloud-runit-0-0.1.20180521git06ad41a.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-21 07:35:32 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Paul Gier 2018-05-17 14:42:26 UTC 
Spec URL: https://pgier.fedorapeople.org/golang/golang-github-soundcloud-go-runit/golang-github-soundcloud-go-runit.spec
SRPM URL: https://pgier.fedorapeople.org/golang/golang-github-soundcloud-go-runit/golang-github-soundcloud-runit-0-0.1.20180517git06ad41a.fc27.src.rpm
Description: go library wrapping runit service status
Fedora Account System Username: pgier
Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=27014336
Comment 1 Paul Gier 2018-05-17 14:43:14 UTC 
This is a dependency of prometheus node_exporter
Comment 2 Paul Gier 2018-05-17 14:56:15 UTC 
new scratch build for minor spec update: https://koji.fedoraproject.org/koji/taskinfo?taskID=27014658
Comment 3 Robert-André Mauchin 🐧 2018-05-17 15:01:03 UTC 
 - You should rename the SPEC golang-github-soundcloud-runit.spec for it to be the same as the name of the package.

 - The git shortcommit in the %changelog should be 7 characters:

* Thu May 17 2018 Paul Gier <pgier> - 0-0.1.20180517git06ad41a

 - You should start the Summary and Description with a capital


 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved. Fix the aforementioned errors before import.
Comment 4 Paul Gier 2018-05-17 19:25:45 UTC 
Thanks!  I updated the shortcommit, summary, and description.
I also renamed the specfile and moved the hosted files to match the specfile name: https://pgier.fedorapeople.org/golang/golang-github-soundcloud-runit/

new scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=27020722
Comment 5 Paul Gier 2018-05-17 20:44:56 UTC 
scm request: https://pagure.io/releng/fedora-scm-requests/issue/6590
Comment 6 Gwyn Ciesla 2018-05-17 21:22:24 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-soundcloud-runit
Comment 7 Paul Gier 2018-05-22 12:44:02 UTC 
Koji build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1083831
Comment 8 Jonathan Dieter 2018-11-07 18:05:22 UTC 
It looks like you've got this into Fedora, so feel free to close this bug.  This will make it more obvious what still needs to be done to get node_exporter into Fedora.
Comment 9 Elliott Sales de Andrade 2020-02-21 07:35:32 UTC 
Please close your review requests after you have imported and built the package.
Note You need to log in before you can comment on or make changes to this bug.